Re: [Qemu-devel] [RFC PATCH v2 19/21] Implement "info memtotal" and "query-memtotal"

[Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>]

Hi,

On Wed, Jul 11, 2012 at 09:14:29AM -0600, Eric Blake wrote:
> On 07/11/2012 04:32 AM, Vasilis Liaskovitis wrote:
> > Returns total memory of guest in bytes, including hotplugged memory.
> > 
> > Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
> 
> Should this instead be merged with query-balloon output, so that we have
> a single command that shows all aspects of memory usage (both balloon
> and hotplug at once)?
> 
> 
> > @@ -1888,3 +1888,15 @@
> >  # Since: 1.1.3
> >  ##
> >  { 'command': 'query-memhp', 'returns': ['MemHpInfo'] }
> > +
> > +##
> > +# @query-memtotal:
> 
> A more generic name might be 'query-memory', especially if we merge
> balloon and hotplug information into one command.

"query-memory" sounds reasonable to me.

"query-balloon" should also be updated to show the correct memory. 
Do you foresee any issues with merging them?  the "query-memory" command
should work independently of the balloon driver.

> > +#
> > +# Returns total memory in bytes, including hotplugged dimms
> > +#
> > +# Returns: a l
> 
> truncated

sorry about that.

thanks,

- Vasilis

> 
> -- 
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 
> 
>