From: Shawn Guo <shawn.guo@linaro.org>
To: Richard Zhao <richard.zhao@freescale.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Kevin Hilman <khilman@ti.com>,
Nishanth Menon <nm@ti.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Mike Turquette <mturquette@linaro.org>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
cpufreq@vger.kernel.org
Subject: Re: [PATCH 3/3] cpufreq: Add a generic cpufreq-cpu0 driver
Date: Mon, 30 Jul 2012 16:17:53 +0800 [thread overview]
Message-ID: <20120730081750.GC31509@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <20120727063334.GC3347@b20223-02.ap.freescale.net>
On Fri, Jul 27, 2012 at 02:33:35PM +0800, Richard Zhao wrote:
> > +Generic cpufreq driver for CPU0
> It's going to have generic name if it will become more generic.
>
I'm not in the position to say that it will become even more generic.
> > +- voltage-tolerance: Specify the CPU voltage tolerance in percentage.
> Why do we have the same tolerance for all points?
Because I haven't seen any case that needs different tolerance for
different operating points.
> I think you can
> either remove tolerance or add it to opps.
I'm not going to remove it, because I have seen potential cpufreq-cpu0
candidates, e.g. omap-cpufreq, need it. It's also improper to encode
it in operating-points, since OPP library does not have it.
> > + ret = clk_set_rate(cpu_clk, freqs.new * 1000);
> Check return value and fall back to previous point if it needs?
Right, the voltage should be reverted back if clk_set_rate fails.
> > + cpu_dev->of_node = np;
> hmm.. sys dev can not set of_node when populate it?
Since the sys dev is not populated from device tree, the of_node is
not set, and we have to do it here on our own.
> And why not do it in module init?
What's the advantage of doing it in module init over here?
> static u32 max_freq = UINT_MAX / 1000; /* kHz */
> module_param(max_freq, uint, 0);
> MODULE_PARM_DESC(max_freq, "max cpu frequency in unit of kHz");
>
> It's for debug. Make sense?
>
It does not look so useful to me, as it never came to me when I was
debugging the driver.
--
Regards,
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] cpufreq: Add a generic cpufreq-cpu0 driver
Date: Mon, 30 Jul 2012 16:17:53 +0800 [thread overview]
Message-ID: <20120730081750.GC31509@S2101-09.ap.freescale.net> (raw)
In-Reply-To: <20120727063334.GC3347@b20223-02.ap.freescale.net>
On Fri, Jul 27, 2012 at 02:33:35PM +0800, Richard Zhao wrote:
> > +Generic cpufreq driver for CPU0
> It's going to have generic name if it will become more generic.
>
I'm not in the position to say that it will become even more generic.
> > +- voltage-tolerance: Specify the CPU voltage tolerance in percentage.
> Why do we have the same tolerance for all points?
Because I haven't seen any case that needs different tolerance for
different operating points.
> I think you can
> either remove tolerance or add it to opps.
I'm not going to remove it, because I have seen potential cpufreq-cpu0
candidates, e.g. omap-cpufreq, need it. It's also improper to encode
it in operating-points, since OPP library does not have it.
> > + ret = clk_set_rate(cpu_clk, freqs.new * 1000);
> Check return value and fall back to previous point if it needs?
Right, the voltage should be reverted back if clk_set_rate fails.
> > + cpu_dev->of_node = np;
> hmm.. sys dev can not set of_node when populate it?
Since the sys dev is not populated from device tree, the of_node is
not set, and we have to do it here on our own.
> And why not do it in module init?
What's the advantage of doing it in module init over here?
> static u32 max_freq = UINT_MAX / 1000; /* kHz */
> module_param(max_freq, uint, 0);
> MODULE_PARM_DESC(max_freq, "max cpu frequency in unit of kHz");
>
> It's for debug. Make sense?
>
It does not look so useful to me, as it never came to me when I was
debugging the driver.
--
Regards,
Shawn
next prev parent reply other threads:[~2012-07-30 8:17 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 15:54 [PATCH 0/3] Add a generic cpufreq-cpu0 driver Shawn Guo
2012-07-19 15:54 ` Shawn Guo
2012-07-19 15:54 ` [PATCH 1/3] ARM: add cpufreq transiton notifier to adjust loops_per_jiffy for smp Shawn Guo
2012-07-19 15:54 ` Shawn Guo
2012-07-20 6:36 ` Shilimkar, Santosh
2012-07-20 6:36 ` Shilimkar, Santosh
2012-07-20 7:56 ` Shawn Guo
2012-07-20 7:56 ` Shawn Guo
2012-07-20 8:27 ` Shilimkar, Santosh
2012-07-20 8:27 ` Shilimkar, Santosh
2012-07-19 15:54 ` [PATCH 2/3] PM / OPP: Initialize OPP table from device tree Shawn Guo
2012-07-19 15:54 ` Shawn Guo
2012-07-20 6:00 ` Menon, Nishanth
2012-07-20 6:00 ` Menon, Nishanth
2012-07-20 8:46 ` Shawn Guo
2012-07-20 8:46 ` Shawn Guo
2012-07-20 9:04 ` Menon, Nishanth
2012-07-20 9:04 ` Menon, Nishanth
2012-07-19 15:54 ` [PATCH 3/3] cpufreq: Add a generic cpufreq-cpu0 driver Shawn Guo
2012-07-19 15:54 ` Shawn Guo
2012-07-20 6:52 ` Shilimkar, Santosh
2012-07-20 6:52 ` Shilimkar, Santosh
[not found] ` <CAMQu2gw32LogXJJa+K5ZjmCZzBNK3FY2wYwZXU8fsftsVzEO2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-07-20 12:33 ` Shawn Guo
2012-07-20 12:33 ` Shawn Guo
2012-07-20 15:50 ` Turquette, Mike
2012-07-20 15:50 ` Turquette, Mike
2012-07-21 5:04 ` Shilimkar, Santosh
2012-07-21 5:04 ` Shilimkar, Santosh
2012-07-21 6:38 ` Shawn Guo
2012-07-21 6:38 ` Shawn Guo
2012-07-27 2:04 ` Richard Zhao
2012-07-27 2:04 ` Richard Zhao
2012-07-30 4:57 ` Shawn Guo
2012-07-30 4:57 ` Shawn Guo
2012-07-20 12:51 ` Richard Zhao
2012-07-20 12:51 ` Richard Zhao
2012-07-20 13:15 ` Shawn Guo
2012-07-20 13:15 ` Shawn Guo
[not found] ` <1342713281-31114-4-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-07-26 13:11 ` Mark Brown
2012-07-26 13:11 ` Mark Brown
[not found] ` <20120726131121.GB7306-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-07-27 2:13 ` Richard Zhao
2012-07-27 2:13 ` Richard Zhao
2012-07-27 10:08 ` Mark Brown
2012-07-27 10:08 ` Mark Brown
2012-07-30 6:52 ` Shawn Guo
2012-07-30 6:52 ` Shawn Guo
2012-07-30 8:20 ` Shawn Guo
2012-07-30 8:20 ` Shawn Guo
2012-07-30 18:55 ` Mark Brown
2012-07-30 18:55 ` Mark Brown
2012-07-30 18:53 ` Mark Brown
2012-07-30 18:53 ` Mark Brown
2012-07-31 4:20 ` Shawn Guo
2012-07-31 4:20 ` Shawn Guo
2012-07-31 13:40 ` Mark Brown
2012-07-31 13:40 ` Mark Brown
2012-07-27 6:33 ` Richard Zhao
2012-07-27 6:33 ` Richard Zhao
2012-07-30 8:17 ` Shawn Guo [this message]
2012-07-30 8:17 ` Shawn Guo
2012-07-30 8:50 ` Richard Zhao
2012-07-30 8:50 ` Richard Zhao
2012-07-30 9:24 ` Shawn Guo
2012-07-30 9:24 ` Shawn Guo
2012-07-19 18:39 ` [PATCH 0/3] " Rafael J. Wysocki
2012-07-19 18:39 ` Rafael J. Wysocki
2012-07-20 0:29 ` Shawn Guo
2012-07-20 0:29 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730081750.GC31509@S2101-09.ap.freescale.net \
--to=shawn.guo@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=nm@ti.com \
--cc=richard.zhao@freescale.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.