From: Mark Brown <broonie@opensource.wolfsonmicro.com> To: Lee Jones <lee.jones@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, Samuel Ortiz <sameo@linux.intel.com> Subject: Re: [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Date: Mon, 20 Aug 2012 18:51:55 +0100 [thread overview] Message-ID: <20120820175155.GH26991@opensource.wolfsonmicro.com> (raw) In-Reply-To: <20120820164949.GB22749@gmail.com> [-- Attachment #1: Type: text/plain, Size: 1812 bytes --] On Mon, Aug 20, 2012 at 05:49:50PM +0100, Lee Jones wrote: > On Mon, Aug 20, 2012 at 05:29:23PM +0100, Mark Brown wrote: > > All of the regmap devices could use this. > Only if they have linear domains and don't support DT. Neither of those restrictions really apply... > If they don't have linear domains there's no point, if they support DT > then they can use it as it is. All this stuff just works for any IRQ domain type, there's no requirement for a particular one. It's not urgently exciting for legacy domains but it's not harmful either and pushes all the handling of this stuff out of the MFD core and into the irqdomain code which is definitely an abstraction win. As far as DT goes supporting DT isn't enough, the current code will only work on systems that actively use DT and do so using a particular style of binding. Since the majority of Linux architectures don't support DT at all and it's not universally deployed on those that do this means that generic drivers can't rely on it, and even drivers that use DT might not be using the binding pattern which the framework code now uses. Indeed now that I think about the above isn't this going to be actively harmful for generic drivers if they use this pattern for their bindings? On DT systems the framework will unconditionally do the mapping but on others no mapping will be done. The function drivers don't know if the mapping has been performed or not. Unless I'm missing something here we need to fix this before the merge window... > To stop being DT dependent we'd need to remove all hand-rolled stuff > that these drivers are currently using, or else they will be attempting > to convert and already converted VIRQ value. Well, yes - using framework code would be the goal here... [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Date: Mon, 20 Aug 2012 18:51:55 +0100 [thread overview] Message-ID: <20120820175155.GH26991@opensource.wolfsonmicro.com> (raw) In-Reply-To: <20120820164949.GB22749@gmail.com> On Mon, Aug 20, 2012 at 05:49:50PM +0100, Lee Jones wrote: > On Mon, Aug 20, 2012 at 05:29:23PM +0100, Mark Brown wrote: > > All of the regmap devices could use this. > Only if they have linear domains and don't support DT. Neither of those restrictions really apply... > If they don't have linear domains there's no point, if they support DT > then they can use it as it is. All this stuff just works for any IRQ domain type, there's no requirement for a particular one. It's not urgently exciting for legacy domains but it's not harmful either and pushes all the handling of this stuff out of the MFD core and into the irqdomain code which is definitely an abstraction win. As far as DT goes supporting DT isn't enough, the current code will only work on systems that actively use DT and do so using a particular style of binding. Since the majority of Linux architectures don't support DT at all and it's not universally deployed on those that do this means that generic drivers can't rely on it, and even drivers that use DT might not be using the binding pattern which the framework code now uses. Indeed now that I think about the above isn't this going to be actively harmful for generic drivers if they use this pattern for their bindings? On DT systems the framework will unconditionally do the mapping but on others no mapping will be done. The function drivers don't know if the mapping has been performed or not. Unless I'm missing something here we need to fix this before the merge window... > To stop being DT dependent we'd need to remove all hand-rolled stuff > that these drivers are currently using, or else they will be attempting > to convert and already converted VIRQ value. Well, yes - using framework code would be the goal here... -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120820/febc6aa3/attachment.sig>
next prev parent reply other threads:[~2012-08-20 17:52 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-09 15:53 [PATCH 0/8] Changes surrounding IRQs and IRQ domains Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-09 15:53 ` [PATCH 1/8] of/irq: Create stub for of_irq_find_parent when !CONFIG_OF Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-09 16:20 ` Rob Herring 2012-08-09 16:20 ` Rob Herring 2012-08-09 19:44 ` Lee Jones 2012-08-09 19:44 ` Lee Jones 2012-08-09 19:53 ` Rob Herring 2012-08-09 19:53 ` Rob Herring 2012-08-14 8:17 ` Linus Walleij 2012-08-14 8:17 ` Linus Walleij 2012-08-09 15:53 ` [PATCH 2/8] irqdomain: Take interrupt-parent property into account if specified Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:19 ` Linus Walleij 2012-08-14 8:19 ` Linus Walleij 2012-08-31 9:44 ` Lee Jones 2012-08-31 9:44 ` Lee Jones 2012-08-31 13:58 ` Rob Herring 2012-08-31 13:58 ` Rob Herring 2012-08-09 15:53 ` [PATCH 3/8] ARM: ux500: Identify the PRCMU as an interrupt controller Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:19 ` Linus Walleij 2012-08-14 8:19 ` Linus Walleij 2012-08-09 15:53 ` [PATCH 4/8] ARM: ux500: Force AB8500 to use the GIC as its " Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:20 ` Linus Walleij 2012-08-14 8:20 ` Linus Walleij 2012-08-09 15:53 ` [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:29 ` Linus Walleij 2012-08-14 8:29 ` Linus Walleij 2012-08-14 9:42 ` Arnd Bergmann 2012-08-14 9:42 ` Arnd Bergmann 2012-08-14 10:44 ` Linus Walleij 2012-08-14 10:44 ` Linus Walleij 2012-08-20 8:36 ` Lee Jones 2012-08-20 8:36 ` Lee Jones 2012-08-20 12:10 ` Mark Brown 2012-08-20 12:10 ` Mark Brown 2012-08-20 12:55 ` Lee Jones 2012-08-20 12:55 ` Lee Jones 2012-08-20 16:29 ` Mark Brown 2012-08-20 16:29 ` Mark Brown 2012-08-20 16:49 ` Lee Jones 2012-08-20 16:49 ` Lee Jones 2012-08-20 17:51 ` Mark Brown [this message] 2012-08-20 17:51 ` Mark Brown 2012-08-21 8:56 ` Lee Jones 2012-08-21 8:56 ` Lee Jones 2012-08-21 9:50 ` Mark Brown 2012-08-21 9:50 ` Mark Brown 2012-08-21 10:54 ` Lee Jones 2012-08-21 10:54 ` Lee Jones 2012-08-21 11:03 ` Mark Brown 2012-08-21 11:03 ` Mark Brown 2012-08-21 12:02 ` Lee Jones 2012-08-21 12:02 ` Lee Jones 2012-08-21 16:52 ` Mark Brown 2012-08-21 16:52 ` Mark Brown 2012-08-22 8:17 ` Lee Jones 2012-08-22 8:17 ` Lee Jones 2012-08-22 11:19 ` Mark Brown 2012-08-22 11:19 ` Mark Brown 2012-08-22 11:55 ` Lee Jones 2012-08-22 11:55 ` Lee Jones 2012-08-22 15:48 ` Mark Brown 2012-08-22 15:48 ` Mark Brown 2012-08-20 9:36 ` Lee Jones 2012-08-20 9:36 ` Lee Jones 2012-08-20 10:49 ` Lee Jones 2012-08-20 10:49 ` Lee Jones 2012-08-09 15:53 ` [PATCH 6/8] mfd: Use interrupt-parent as IRQ controller if specified in DT Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:22 ` Linus Walleij 2012-08-14 8:22 ` Linus Walleij 2012-08-09 15:53 ` [PATCH 7/8] mfd: Use the AB8500's IRQ domain to convert hwirq to virq Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:25 ` Linus Walleij 2012-08-14 8:25 ` Linus Walleij 2012-09-19 0:00 ` Samuel Ortiz 2012-09-19 0:00 ` Samuel Ortiz 2012-08-09 15:53 ` [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:31 ` Linus Walleij 2012-08-14 8:31 ` Linus Walleij 2012-08-21 9:23 ` Lee Jones 2012-08-21 9:23 ` Lee Jones 2012-08-21 16:42 ` Dmitry Torokhov 2012-08-21 16:42 ` Dmitry Torokhov 2012-08-30 13:12 ` Lee Jones 2012-08-30 13:12 ` Lee Jones 2012-08-30 23:02 ` Dmitry Torokhov 2012-08-30 23:02 ` Dmitry Torokhov 2012-08-30 23:03 ` Dmitry Torokhov 2012-08-30 23:03 ` Dmitry Torokhov 2012-08-31 7:31 ` Lee Jones 2012-08-31 7:31 ` Lee Jones 2012-08-31 7:31 ` Lee Jones 2012-08-31 14:50 ` Dmitry Torokhov 2012-08-31 14:50 ` Dmitry Torokhov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120820175155.GH26991@opensource.wolfsonmicro.com \ --to=broonie@opensource.wolfsonmicro.com \ --cc=STEricsson_nomadik_linux@list.st.com \ --cc=arnd@arndb.de \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linus.walleij@stericsson.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.