From: Mark Brown <broonie@opensource.wolfsonmicro.com> To: Lee Jones <lee.jones@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org>, Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, Samuel Ortiz <sameo@linux.intel.com> Subject: Re: [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Date: Wed, 22 Aug 2012 16:48:12 +0100 [thread overview] Message-ID: <20120822154812.GK7995@opensource.wolfsonmicro.com> (raw) In-Reply-To: <20120822115524.GA18545@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2107 bytes --] On Wed, Aug 22, 2012 at 12:55:25PM +0100, Lee Jones wrote: > > I *have* asked you to communicate more clearly about what you're doing > > but that doesn't mean to stop sending code, it means to have clearer > > words around what you're sending. > That's not how I interpreted your words: > "What you can do here is to commmunicate about what you're doing more. > Don't just think about the code, think about the communication > surrounding the code - this is the core of the issue." Just to be clear I'd include things like commit messages, cover letters and so on in the general area of communication. > I think it's great that you like the idea and want to extend that > functionality to other MFDs which perhaps don't support DT, or the > ones that do but don't want to provide compatible strings or device > nodes for all the MFD's child devices. But that is all we're doing > here. There was no breakage. It served a purpose and it worked well. > So well in fact that you've now provided the intended functionality > to other devices. I'm looking at this from the point of view of adding the compatible strings and then finding that the core starts remapping things in the case where you're probing from DT - and this behaviour will vary depending on the device tree that the user is using so the driver can't even make a decision based on if device tree is being used by the system. > You only noticed it 2 days ago and I had a patch ready to go yesterday. > I'm confused because I don't understand why would you even complain about > it if you intended to work on it yourself? Surely, "Ah, I see an issue with > xyz, patch to follow." Would have been more appropriate, instead of > complaining about it, then I go and waste my time trying to fix something > you intend on fixing yourself. I didn't originally intend to do anything, if I had done I'd just have sent a patch as you say. Originally I'd just noticed it as being an awkwardly designed interface at the wrong abstraction layer, it was only later on that I realised how it could blow up. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Date: Wed, 22 Aug 2012 16:48:12 +0100 [thread overview] Message-ID: <20120822154812.GK7995@opensource.wolfsonmicro.com> (raw) In-Reply-To: <20120822115524.GA18545@gmail.com> On Wed, Aug 22, 2012 at 12:55:25PM +0100, Lee Jones wrote: > > I *have* asked you to communicate more clearly about what you're doing > > but that doesn't mean to stop sending code, it means to have clearer > > words around what you're sending. > That's not how I interpreted your words: > "What you can do here is to commmunicate about what you're doing more. > Don't just think about the code, think about the communication > surrounding the code - this is the core of the issue." Just to be clear I'd include things like commit messages, cover letters and so on in the general area of communication. > I think it's great that you like the idea and want to extend that > functionality to other MFDs which perhaps don't support DT, or the > ones that do but don't want to provide compatible strings or device > nodes for all the MFD's child devices. But that is all we're doing > here. There was no breakage. It served a purpose and it worked well. > So well in fact that you've now provided the intended functionality > to other devices. I'm looking at this from the point of view of adding the compatible strings and then finding that the core starts remapping things in the case where you're probing from DT - and this behaviour will vary depending on the device tree that the user is using so the driver can't even make a decision based on if device tree is being used by the system. > You only noticed it 2 days ago and I had a patch ready to go yesterday. > I'm confused because I don't understand why would you even complain about > it if you intended to work on it yourself? Surely, "Ah, I see an issue with > xyz, patch to follow." Would have been more appropriate, instead of > complaining about it, then I go and waste my time trying to fix something > you intend on fixing yourself. I didn't originally intend to do anything, if I had done I'd just have sent a patch as you say. Originally I'd just noticed it as being an awkwardly designed interface at the wrong abstraction layer, it was only later on that I realised how it could blow up. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120822/d3e74d63/attachment-0001.sig>
next prev parent reply other threads:[~2012-08-22 15:48 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-09 15:53 [PATCH 0/8] Changes surrounding IRQs and IRQ domains Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-09 15:53 ` [PATCH 1/8] of/irq: Create stub for of_irq_find_parent when !CONFIG_OF Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-09 16:20 ` Rob Herring 2012-08-09 16:20 ` Rob Herring 2012-08-09 19:44 ` Lee Jones 2012-08-09 19:44 ` Lee Jones 2012-08-09 19:53 ` Rob Herring 2012-08-09 19:53 ` Rob Herring 2012-08-14 8:17 ` Linus Walleij 2012-08-14 8:17 ` Linus Walleij 2012-08-09 15:53 ` [PATCH 2/8] irqdomain: Take interrupt-parent property into account if specified Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:19 ` Linus Walleij 2012-08-14 8:19 ` Linus Walleij 2012-08-31 9:44 ` Lee Jones 2012-08-31 9:44 ` Lee Jones 2012-08-31 13:58 ` Rob Herring 2012-08-31 13:58 ` Rob Herring 2012-08-09 15:53 ` [PATCH 3/8] ARM: ux500: Identify the PRCMU as an interrupt controller Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:19 ` Linus Walleij 2012-08-14 8:19 ` Linus Walleij 2012-08-09 15:53 ` [PATCH 4/8] ARM: ux500: Force AB8500 to use the GIC as its " Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:20 ` Linus Walleij 2012-08-14 8:20 ` Linus Walleij 2012-08-09 15:53 ` [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:29 ` Linus Walleij 2012-08-14 8:29 ` Linus Walleij 2012-08-14 9:42 ` Arnd Bergmann 2012-08-14 9:42 ` Arnd Bergmann 2012-08-14 10:44 ` Linus Walleij 2012-08-14 10:44 ` Linus Walleij 2012-08-20 8:36 ` Lee Jones 2012-08-20 8:36 ` Lee Jones 2012-08-20 12:10 ` Mark Brown 2012-08-20 12:10 ` Mark Brown 2012-08-20 12:55 ` Lee Jones 2012-08-20 12:55 ` Lee Jones 2012-08-20 16:29 ` Mark Brown 2012-08-20 16:29 ` Mark Brown 2012-08-20 16:49 ` Lee Jones 2012-08-20 16:49 ` Lee Jones 2012-08-20 17:51 ` Mark Brown 2012-08-20 17:51 ` Mark Brown 2012-08-21 8:56 ` Lee Jones 2012-08-21 8:56 ` Lee Jones 2012-08-21 9:50 ` Mark Brown 2012-08-21 9:50 ` Mark Brown 2012-08-21 10:54 ` Lee Jones 2012-08-21 10:54 ` Lee Jones 2012-08-21 11:03 ` Mark Brown 2012-08-21 11:03 ` Mark Brown 2012-08-21 12:02 ` Lee Jones 2012-08-21 12:02 ` Lee Jones 2012-08-21 16:52 ` Mark Brown 2012-08-21 16:52 ` Mark Brown 2012-08-22 8:17 ` Lee Jones 2012-08-22 8:17 ` Lee Jones 2012-08-22 11:19 ` Mark Brown 2012-08-22 11:19 ` Mark Brown 2012-08-22 11:55 ` Lee Jones 2012-08-22 11:55 ` Lee Jones 2012-08-22 15:48 ` Mark Brown [this message] 2012-08-22 15:48 ` Mark Brown 2012-08-20 9:36 ` Lee Jones 2012-08-20 9:36 ` Lee Jones 2012-08-20 10:49 ` Lee Jones 2012-08-20 10:49 ` Lee Jones 2012-08-09 15:53 ` [PATCH 6/8] mfd: Use interrupt-parent as IRQ controller if specified in DT Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:22 ` Linus Walleij 2012-08-14 8:22 ` Linus Walleij 2012-08-09 15:53 ` [PATCH 7/8] mfd: Use the AB8500's IRQ domain to convert hwirq to virq Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:25 ` Linus Walleij 2012-08-14 8:25 ` Linus Walleij 2012-09-19 0:00 ` Samuel Ortiz 2012-09-19 0:00 ` Samuel Ortiz 2012-08-09 15:53 ` [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual Lee Jones 2012-08-09 15:53 ` Lee Jones 2012-08-14 8:31 ` Linus Walleij 2012-08-14 8:31 ` Linus Walleij 2012-08-21 9:23 ` Lee Jones 2012-08-21 9:23 ` Lee Jones 2012-08-21 16:42 ` Dmitry Torokhov 2012-08-21 16:42 ` Dmitry Torokhov 2012-08-30 13:12 ` Lee Jones 2012-08-30 13:12 ` Lee Jones 2012-08-30 23:02 ` Dmitry Torokhov 2012-08-30 23:02 ` Dmitry Torokhov 2012-08-30 23:03 ` Dmitry Torokhov 2012-08-30 23:03 ` Dmitry Torokhov 2012-08-31 7:31 ` Lee Jones 2012-08-31 7:31 ` Lee Jones 2012-08-31 7:31 ` Lee Jones 2012-08-31 14:50 ` Dmitry Torokhov 2012-08-31 14:50 ` Dmitry Torokhov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20120822154812.GK7995@opensource.wolfsonmicro.com \ --to=broonie@opensource.wolfsonmicro.com \ --cc=STEricsson_nomadik_linux@list.st.com \ --cc=arnd@arndb.de \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linus.walleij@stericsson.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sameo@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.