From: Linus Walleij <linus.walleij@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com, arnd@arndb.de,
broonie@opensource.wolfsonmicro.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual
Date: Tue, 14 Aug 2012 10:31:08 +0200 [thread overview]
Message-ID: <CACRpkdZ-HOGy_sdsCQSNOdYTDzHFszk0OySM88TjO-neSJUz0A@mail.gmail.com> (raw)
In-Reply-To: <1344527635-6163-9-git-send-email-lee.jones@linaro.org>
On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones <lee.jones@linaro.org> wrote:
> There was a plan to place ab8500_irq_get_virq() calls in each AB8500
> child device prior to requesting an IRQ, but as we're no longer using
> Device Tree to collect our IRQ numbers, it's actually better to allow
> the core to do this during device registration time. So the IRQ number
> we pull from its resource has already been converted to a virtual IRQ.
>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> CC: linux-input@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
This is looking good, I guess you need all patches to go in at the
same time so Dmitry's ACK is required.
FWIW:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
BTW: this makes me suspect that the public ab8500_irq_get_virq()
interface can be *deleted* and the function made static in the
AB8500 driver, right?
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual
Date: Tue, 14 Aug 2012 10:31:08 +0200 [thread overview]
Message-ID: <CACRpkdZ-HOGy_sdsCQSNOdYTDzHFszk0OySM88TjO-neSJUz0A@mail.gmail.com> (raw)
In-Reply-To: <1344527635-6163-9-git-send-email-lee.jones@linaro.org>
On Thu, Aug 9, 2012 at 5:53 PM, Lee Jones <lee.jones@linaro.org> wrote:
> There was a plan to place ab8500_irq_get_virq() calls in each AB8500
> child device prior to requesting an IRQ, but as we're no longer using
> Device Tree to collect our IRQ numbers, it's actually better to allow
> the core to do this during device registration time. So the IRQ number
> we pull from its resource has already been converted to a virtual IRQ.
>
> CC: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> CC: linux-input at vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
This is looking good, I guess you need all patches to go in at the
same time so Dmitry's ACK is required.
FWIW:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
BTW: this makes me suspect that the public ab8500_irq_get_virq()
interface can be *deleted* and the function made static in the
AB8500 driver, right?
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-08-14 8:31 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 15:53 [PATCH 0/8] Changes surrounding IRQs and IRQ domains Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-09 15:53 ` [PATCH 1/8] of/irq: Create stub for of_irq_find_parent when !CONFIG_OF Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-09 16:20 ` Rob Herring
2012-08-09 16:20 ` Rob Herring
2012-08-09 19:44 ` Lee Jones
2012-08-09 19:44 ` Lee Jones
2012-08-09 19:53 ` Rob Herring
2012-08-09 19:53 ` Rob Herring
2012-08-14 8:17 ` Linus Walleij
2012-08-14 8:17 ` Linus Walleij
2012-08-09 15:53 ` [PATCH 2/8] irqdomain: Take interrupt-parent property into account if specified Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-14 8:19 ` Linus Walleij
2012-08-14 8:19 ` Linus Walleij
2012-08-31 9:44 ` Lee Jones
2012-08-31 9:44 ` Lee Jones
2012-08-31 13:58 ` Rob Herring
2012-08-31 13:58 ` Rob Herring
2012-08-09 15:53 ` [PATCH 3/8] ARM: ux500: Identify the PRCMU as an interrupt controller Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-14 8:19 ` Linus Walleij
2012-08-14 8:19 ` Linus Walleij
2012-08-09 15:53 ` [PATCH 4/8] ARM: ux500: Force AB8500 to use the GIC as its " Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-14 8:20 ` Linus Walleij
2012-08-14 8:20 ` Linus Walleij
2012-08-09 15:53 ` [PATCH 5/8] mfd: Provide the PRCMU with its own IRQ domain Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-14 8:29 ` Linus Walleij
2012-08-14 8:29 ` Linus Walleij
2012-08-14 9:42 ` Arnd Bergmann
2012-08-14 9:42 ` Arnd Bergmann
2012-08-14 10:44 ` Linus Walleij
2012-08-14 10:44 ` Linus Walleij
2012-08-20 8:36 ` Lee Jones
2012-08-20 8:36 ` Lee Jones
2012-08-20 12:10 ` Mark Brown
2012-08-20 12:10 ` Mark Brown
2012-08-20 12:55 ` Lee Jones
2012-08-20 12:55 ` Lee Jones
2012-08-20 16:29 ` Mark Brown
2012-08-20 16:29 ` Mark Brown
2012-08-20 16:49 ` Lee Jones
2012-08-20 16:49 ` Lee Jones
2012-08-20 17:51 ` Mark Brown
2012-08-20 17:51 ` Mark Brown
2012-08-21 8:56 ` Lee Jones
2012-08-21 8:56 ` Lee Jones
2012-08-21 9:50 ` Mark Brown
2012-08-21 9:50 ` Mark Brown
2012-08-21 10:54 ` Lee Jones
2012-08-21 10:54 ` Lee Jones
2012-08-21 11:03 ` Mark Brown
2012-08-21 11:03 ` Mark Brown
2012-08-21 12:02 ` Lee Jones
2012-08-21 12:02 ` Lee Jones
2012-08-21 16:52 ` Mark Brown
2012-08-21 16:52 ` Mark Brown
2012-08-22 8:17 ` Lee Jones
2012-08-22 8:17 ` Lee Jones
2012-08-22 11:19 ` Mark Brown
2012-08-22 11:19 ` Mark Brown
2012-08-22 11:55 ` Lee Jones
2012-08-22 11:55 ` Lee Jones
2012-08-22 15:48 ` Mark Brown
2012-08-22 15:48 ` Mark Brown
2012-08-20 9:36 ` Lee Jones
2012-08-20 9:36 ` Lee Jones
2012-08-20 10:49 ` Lee Jones
2012-08-20 10:49 ` Lee Jones
2012-08-09 15:53 ` [PATCH 6/8] mfd: Use interrupt-parent as IRQ controller if specified in DT Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-14 8:22 ` Linus Walleij
2012-08-14 8:22 ` Linus Walleij
2012-08-09 15:53 ` [PATCH 7/8] mfd: Use the AB8500's IRQ domain to convert hwirq to virq Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-14 8:25 ` Linus Walleij
2012-08-14 8:25 ` Linus Walleij
2012-09-19 0:00 ` Samuel Ortiz
2012-09-19 0:00 ` Samuel Ortiz
2012-08-09 15:53 ` [PATCH 8/8] input: ab8500-ponkey: Rely on MFD core to convert IRQs to virtual Lee Jones
2012-08-09 15:53 ` Lee Jones
2012-08-14 8:31 ` Linus Walleij [this message]
2012-08-14 8:31 ` Linus Walleij
2012-08-21 9:23 ` Lee Jones
2012-08-21 9:23 ` Lee Jones
2012-08-21 16:42 ` Dmitry Torokhov
2012-08-21 16:42 ` Dmitry Torokhov
2012-08-30 13:12 ` Lee Jones
2012-08-30 13:12 ` Lee Jones
2012-08-30 23:02 ` Dmitry Torokhov
2012-08-30 23:02 ` Dmitry Torokhov
2012-08-30 23:03 ` Dmitry Torokhov
2012-08-30 23:03 ` Dmitry Torokhov
2012-08-31 7:31 ` Lee Jones
2012-08-31 7:31 ` Lee Jones
2012-08-31 7:31 ` Lee Jones
2012-08-31 14:50 ` Dmitry Torokhov
2012-08-31 14:50 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ-HOGy_sdsCQSNOdYTDzHFszk0OySM88TjO-neSJUz0A@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.