From: Josh Boyer <jwboyer@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org,
kexec@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 10/12] acpi: Ignore acpi_rsdp kernel parameter in a secure boot environment
Date: Tue, 19 Mar 2013 07:19:17 -0400 [thread overview]
Message-ID: <20130319111916.GI11243@hansolo.jdub.homelinux.org> (raw)
In-Reply-To: <5148261F.3030806@redhat.com>
On Tue, Mar 19, 2013 at 04:47:27PM +0800, Dave Young wrote:
> On 03/19/2013 05:32 AM, Matthew Garrett wrote:
> > From: Josh Boyer <jwboyer@redhat.com>
> >
> > This option allows userspace to pass the RSDP address to the kernel. This
> > could potentially be used to circumvent the secure boot trust model.
> > We ignore the setting if we don't have the CAP_COMPROMISE_KERNEL capability.
> >
> > Signed-off-by: Josh Boyer <jwboyer@redhat.com>
> > ---
> > drivers/acpi/osl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> > index 586e7e9..0ef63f1 100644
> > --- a/drivers/acpi/osl.c
> > +++ b/drivers/acpi/osl.c
> > @@ -245,7 +245,7 @@ early_param("acpi_rsdp", setup_acpi_rsdp);
> > acpi_physical_address __init acpi_os_get_root_pointer(void)
> > {
> > #ifdef CONFIG_KEXEC
> > - if (acpi_rsdp)
> > + if (acpi_rsdp && capable(CAP_COMPROMISE_KERNEL))
> > return acpi_rsdp;
> > #endif
> >
> >
>
> This does not work because capable is not usable at this early point.
Right.
> Josh, could you update your fix here?
I have. Twice. Matthew sent out a stale patch.
josh
WARNING: multiple messages have this Message-ID (diff)
From: Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Matthew Garrett
<matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 10/12] acpi: Ignore acpi_rsdp kernel parameter in a secure boot environment
Date: Tue, 19 Mar 2013 07:19:17 -0400 [thread overview]
Message-ID: <20130319111916.GI11243@hansolo.jdub.homelinux.org> (raw)
In-Reply-To: <5148261F.3030806-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Tue, Mar 19, 2013 at 04:47:27PM +0800, Dave Young wrote:
> On 03/19/2013 05:32 AM, Matthew Garrett wrote:
> > From: Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> >
> > This option allows userspace to pass the RSDP address to the kernel. This
> > could potentially be used to circumvent the secure boot trust model.
> > We ignore the setting if we don't have the CAP_COMPROMISE_KERNEL capability.
> >
> > Signed-off-by: Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> > drivers/acpi/osl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> > index 586e7e9..0ef63f1 100644
> > --- a/drivers/acpi/osl.c
> > +++ b/drivers/acpi/osl.c
> > @@ -245,7 +245,7 @@ early_param("acpi_rsdp", setup_acpi_rsdp);
> > acpi_physical_address __init acpi_os_get_root_pointer(void)
> > {
> > #ifdef CONFIG_KEXEC
> > - if (acpi_rsdp)
> > + if (acpi_rsdp && capable(CAP_COMPROMISE_KERNEL))
> > return acpi_rsdp;
> > #endif
> >
> >
>
> This does not work because capable is not usable at this early point.
Right.
> Josh, could you update your fix here?
I have. Twice. Matthew sent out a stale patch.
josh
WARNING: multiple messages have this Message-ID (diff)
From: Josh Boyer <jwboyer@redhat.com>
To: Dave Young <dyoung@redhat.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
linux-efi@vger.kernel.org, linux-pci@vger.kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 10/12] acpi: Ignore acpi_rsdp kernel parameter in a secure boot environment
Date: Tue, 19 Mar 2013 07:19:17 -0400 [thread overview]
Message-ID: <20130319111916.GI11243@hansolo.jdub.homelinux.org> (raw)
In-Reply-To: <5148261F.3030806@redhat.com>
On Tue, Mar 19, 2013 at 04:47:27PM +0800, Dave Young wrote:
> On 03/19/2013 05:32 AM, Matthew Garrett wrote:
> > From: Josh Boyer <jwboyer@redhat.com>
> >
> > This option allows userspace to pass the RSDP address to the kernel. This
> > could potentially be used to circumvent the secure boot trust model.
> > We ignore the setting if we don't have the CAP_COMPROMISE_KERNEL capability.
> >
> > Signed-off-by: Josh Boyer <jwboyer@redhat.com>
> > ---
> > drivers/acpi/osl.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> > index 586e7e9..0ef63f1 100644
> > --- a/drivers/acpi/osl.c
> > +++ b/drivers/acpi/osl.c
> > @@ -245,7 +245,7 @@ early_param("acpi_rsdp", setup_acpi_rsdp);
> > acpi_physical_address __init acpi_os_get_root_pointer(void)
> > {
> > #ifdef CONFIG_KEXEC
> > - if (acpi_rsdp)
> > + if (acpi_rsdp && capable(CAP_COMPROMISE_KERNEL))
> > return acpi_rsdp;
> > #endif
> >
> >
>
> This does not work because capable is not usable at this early point.
Right.
> Josh, could you update your fix here?
I have. Twice. Matthew sent out a stale patch.
josh
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-03-19 11:19 UTC|newest]
Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 21:32 [PATCH 01/12] Security: Add CAP_COMPROMISE_KERNEL Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` [PATCH 02/12] SELinux: define mapping for CAP_COMPROMISE_KERNEL Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` [PATCH 03/12] Secure boot: Add a dummy kernel parameter that will switch on Secure Boot mode Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` [PATCH 04/12] efi: Enable secure boot lockdown automatically when enabled in firmware Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` [PATCH 05/12] PCI: Require CAP_COMPROMISE_KERNEL for PCI BAR access Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-27 15:03 ` Josh Boyer
2013-03-27 15:03 ` Josh Boyer
2013-03-27 15:08 ` Kyle McMartin
2013-03-27 15:08 ` Kyle McMartin
2013-03-28 12:46 ` Josh Boyer
2013-03-28 12:46 ` Josh Boyer
2013-03-18 21:32 ` [PATCH 06/12] x86: Require CAP_COMPROMISE_KERNEL for IO port access Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-20 1:00 ` H. Peter Anvin
2013-03-20 1:00 ` H. Peter Anvin
2013-03-18 21:32 ` [PATCH 07/12] ACPI: Limit access to custom_method Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` [PATCH 08/12] asus-wmi: Restrict debugfs interface Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` [PATCH 09/12] Require CAP_COMPROMISE_KERNEL for /dev/mem and /dev/kmem access Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` [PATCH 10/12] acpi: Ignore acpi_rsdp kernel parameter in a secure boot environment Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-19 8:47 ` Dave Young
2013-03-19 8:47 ` Dave Young
2013-03-19 8:47 ` Dave Young
2013-03-19 11:19 ` Josh Boyer [this message]
2013-03-19 11:19 ` Josh Boyer
2013-03-19 11:19 ` Josh Boyer
2013-03-19 17:07 ` [PATCH v2] " Josh Boyer
2013-03-19 17:07 ` Josh Boyer
2013-03-18 21:32 ` [PATCH 11/12] x86: Require CAP_COMPROMISE_KERNEL for MSR writing Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` [PATCH 12/12] kexec: Require CAP_SYS_COMPROMISE_KERNEL Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-18 21:32 ` Matthew Garrett
2013-03-19 4:47 ` [PATCH 01/12] Security: Add CAP_COMPROMISE_KERNEL James Morris
2013-03-19 4:47 ` James Morris
2013-03-19 4:47 ` James Morris
2013-03-20 1:03 ` H. Peter Anvin
2013-03-20 1:03 ` H. Peter Anvin
2013-03-20 16:41 ` Mimi Zohar
2013-03-20 16:41 ` Mimi Zohar
2013-03-20 16:49 ` Matthew Garrett
2013-03-20 16:49 ` Matthew Garrett
2013-03-20 16:49 ` Matthew Garrett
2013-03-20 16:49 ` Matthew Garrett
2013-03-20 18:01 ` Mimi Zohar
2013-03-20 18:01 ` Mimi Zohar
2013-03-20 18:01 ` Mimi Zohar
2013-03-20 18:12 ` Matthew Garrett
2013-03-20 18:12 ` Matthew Garrett
2013-03-20 18:12 ` Matthew Garrett
2013-03-20 18:12 ` Matthew Garrett
2013-03-20 19:16 ` Mimi Zohar
2013-03-20 19:16 ` Mimi Zohar
2013-03-20 19:16 ` Mimi Zohar
2013-03-20 19:16 ` Mimi Zohar
2013-03-20 20:37 ` Matthew Garrett
2013-03-20 20:37 ` Matthew Garrett
2013-03-20 20:37 ` Matthew Garrett
2013-03-20 20:37 ` Matthew Garrett
2013-03-20 21:11 ` Mimi Zohar
2013-03-20 21:11 ` Mimi Zohar
2013-03-20 21:11 ` Mimi Zohar
2013-03-20 21:18 ` Matthew Garrett
2013-03-20 21:18 ` Matthew Garrett
2013-03-20 21:18 ` Matthew Garrett
2013-03-20 21:18 ` Matthew Garrett
2013-03-21 13:43 ` Vivek Goyal
2013-03-21 13:43 ` Vivek Goyal
2013-03-21 13:43 ` Vivek Goyal
2013-03-21 13:43 ` Vivek Goyal
2013-03-21 15:37 ` Serge E. Hallyn
2013-03-21 15:37 ` Serge E. Hallyn
2013-03-21 15:37 ` Serge E. Hallyn
2013-03-21 15:37 ` Serge E. Hallyn
2013-03-21 15:52 ` Vivek Goyal
2013-03-21 15:52 ` Vivek Goyal
2013-03-21 15:52 ` Vivek Goyal
2013-03-21 15:52 ` Vivek Goyal
2013-03-21 15:58 ` Serge E. Hallyn
2013-03-21 15:58 ` Serge E. Hallyn
2013-03-21 15:58 ` Serge E. Hallyn
2013-03-21 15:58 ` Serge E. Hallyn
2013-03-21 16:04 ` Vivek Goyal
2013-03-21 16:04 ` Vivek Goyal
2013-03-21 16:04 ` Vivek Goyal
2013-03-21 16:19 ` Serge E. Hallyn
2013-03-21 16:19 ` Serge E. Hallyn
2013-03-21 16:19 ` Serge E. Hallyn
2013-03-21 16:19 ` Serge E. Hallyn
2013-03-21 17:15 ` Vivek Goyal
2013-03-21 17:15 ` Vivek Goyal
2013-03-21 17:15 ` Vivek Goyal
2013-03-21 17:15 ` Vivek Goyal
2013-03-21 1:58 ` James Morris
2013-03-21 1:58 ` James Morris
2013-03-19 7:18 ` Yves-Alexis Perez
2013-03-19 7:18 ` Yves-Alexis Perez
2013-03-20 1:02 ` H. Peter Anvin
2013-03-20 1:02 ` H. Peter Anvin
2013-03-20 1:05 ` H. Peter Anvin
2013-03-20 1:05 ` H. Peter Anvin
2013-03-20 13:15 ` Matthew Garrett
2013-03-20 13:15 ` Matthew Garrett
2013-03-20 13:15 ` Matthew Garrett
2013-03-20 13:15 ` Matthew Garrett
2013-03-20 15:03 ` H. Peter Anvin
2013-03-20 15:03 ` H. Peter Anvin
2013-03-20 15:03 ` H. Peter Anvin
2013-03-20 15:03 ` H. Peter Anvin
2013-03-20 15:14 ` Matthew Garrett
2013-03-20 15:14 ` Matthew Garrett
2013-03-20 15:14 ` Matthew Garrett
2013-03-20 15:14 ` Matthew Garrett
2013-03-20 16:45 ` H. Peter Anvin
2013-03-20 16:45 ` H. Peter Anvin
2013-03-20 16:45 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319111916.GI11243@hansolo.jdub.homelinux.org \
--to=jwboyer@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.