All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Thu, 04 Apr 2013 09:03:17 +0000	[thread overview]
Message-ID: <20130404090317.GB23848@verge.net.au> (raw)
In-Reply-To: <515C2E24.1080108@cogentembedded.com>

On Wed, Apr 03, 2013 at 05:27:00PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 03-04-2013 4:25, Kuninori Morimoto wrote:
> 
> >>>Current ARM SoC is trying to not use platform_device_register()
> >>>Please use platform_device_register_xxx()
> >>>Same comment for [2/2]
> 
> >>     Is there some rationale to it? I don't find platform_device_register_xxx()
> >>especially handy to use.
> 
> >http://www.spinics.net/lists/linux-sh/msg16871.html
> 
>    I don't see there actual Greg KH's rationale for not using
> platform_register_device().

I'm sure that you can find the rationale if you look.
If not you can ask him, if it is important to you.
Failing that, I can ask him, if its important to you.

However, the point is that Arnd, who is the upstream for shmobile, has
indicated that he would prefer
platform_device_register_{full,resndata,data,simple} used instead of
platform_register_device(). And furthermore Magnus appears to have started
following this advice in his series "[PATCH 01/04] ARM: shmobile: r8a7740
pinmux platform device cleanup".

I would like you to update this patch to follow that advice too.
Likewise for the similar R8A7778 patch.


WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Thu, 4 Apr 2013 18:03:17 +0900	[thread overview]
Message-ID: <20130404090317.GB23848@verge.net.au> (raw)
In-Reply-To: <515C2E24.1080108@cogentembedded.com>

On Wed, Apr 03, 2013 at 05:27:00PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 03-04-2013 4:25, Kuninori Morimoto wrote:
> 
> >>>Current ARM SoC is trying to not use platform_device_register()
> >>>Please use platform_device_register_xxx()
> >>>Same comment for [2/2]
> 
> >>     Is there some rationale to it? I don't find platform_device_register_xxx()
> >>especially handy to use.
> 
> >http://www.spinics.net/lists/linux-sh/msg16871.html
> 
>    I don't see there actual Greg KH's rationale for not using
> platform_register_device().

I'm sure that you can find the rationale if you look.
If not you can ask him, if it is important to you.
Failing that, I can ask him, if its important to you.

However, the point is that Arnd, who is the upstream for shmobile, has
indicated that he would prefer
platform_device_register_{full,resndata,data,simple} used instead of
platform_register_device(). And furthermore Magnus appears to have started
following this advice in his series "[PATCH 01/04] ARM: shmobile: r8a7740
pinmux platform device cleanup".

I would like you to update this patch to follow that advice too.
Likewise for the similar R8A7778 patch.

  reply	other threads:[~2013-04-04  9:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 22:04 [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support Sergei Shtylyov
2013-04-01 22:04 ` Sergei Shtylyov
2013-04-02  0:17 ` Kuninori Morimoto
2013-04-02  0:17   ` Kuninori Morimoto
2013-04-02 11:45   ` Sergei Shtylyov
2013-04-02 11:45     ` Sergei Shtylyov
2013-04-03  0:25     ` Kuninori Morimoto
2013-04-03  0:25       ` Kuninori Morimoto
2013-04-03 13:27       ` Sergei Shtylyov
2013-04-03 13:27         ` Sergei Shtylyov
2013-04-04  9:03         ` Simon Horman [this message]
2013-04-04  9:03           ` Simon Horman
2013-04-02  0:27 ` Kuninori Morimoto
2013-04-02  0:27   ` Kuninori Morimoto
2013-04-02 11:47   ` Sergei Shtylyov
2013-04-02 11:47     ` Sergei Shtylyov
2013-04-03  0:08     ` Kuninori Morimoto
2013-04-03  0:08       ` Kuninori Morimoto
2013-04-03 13:22       ` Sergei Shtylyov
2013-04-03 13:22         ` Sergei Shtylyov
2013-04-04  6:34         ` Simon Horman
2013-04-04  6:34           ` Simon Horman
2013-04-04  9:04           ` Simon Horman
2013-04-04  9:04             ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130404090317.GB23848@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.