From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Wed, 03 Apr 2013 13:22:22 +0000 [thread overview]
Message-ID: <515C2D0E.8010607@cogentembedded.com> (raw)
In-Reply-To: <87txnocw6n.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 03-04-2013 4:08, Kuninori Morimoto wrote:
>>> Then, this (void *pdata) should be
>>> (struct sh_eth_plat_data *pdata) IMO
>> ether_device.dev.platform_data is 'void *'. I didn't want to bring in
>> extra header for the little use.
> Not enough reason for me.
> "void *" means there is no pointer check,
> and extra header is just 1 line. No ?
There's no pointer check either if we just initialize the 'platform_data'
member as part of the platfrom device initializer, so we can actually stuff
pointer to any nonsense there. Why make this case different?
> If you want to use this style,
> then, additional extra header is fate, IMO
We can agree to disagree here. :-)
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Wed, 03 Apr 2013 17:22:22 +0400 [thread overview]
Message-ID: <515C2D0E.8010607@cogentembedded.com> (raw)
In-Reply-To: <87txnocw6n.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 03-04-2013 4:08, Kuninori Morimoto wrote:
>>> Then, this (void *pdata) should be
>>> (struct sh_eth_plat_data *pdata) IMO
>> ether_device.dev.platform_data is 'void *'. I didn't want to bring in
>> extra header for the little use.
> Not enough reason for me.
> "void *" means there is no pointer check,
> and extra header is just 1 line. No ?
There's no pointer check either if we just initialize the 'platform_data'
member as part of the platfrom device initializer, so we can actually stuff
pointer to any nonsense there. Why make this case different?
> If you want to use this style,
> then, additional extra header is fate, IMO
We can agree to disagree here. :-)
WBR, Sergei
next prev parent reply other threads:[~2013-04-03 13:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 22:04 [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support Sergei Shtylyov
2013-04-01 22:04 ` Sergei Shtylyov
2013-04-02 0:17 ` Kuninori Morimoto
2013-04-02 0:17 ` Kuninori Morimoto
2013-04-02 11:45 ` Sergei Shtylyov
2013-04-02 11:45 ` Sergei Shtylyov
2013-04-03 0:25 ` Kuninori Morimoto
2013-04-03 0:25 ` Kuninori Morimoto
2013-04-03 13:27 ` Sergei Shtylyov
2013-04-03 13:27 ` Sergei Shtylyov
2013-04-04 9:03 ` Simon Horman
2013-04-04 9:03 ` Simon Horman
2013-04-02 0:27 ` Kuninori Morimoto
2013-04-02 0:27 ` Kuninori Morimoto
2013-04-02 11:47 ` Sergei Shtylyov
2013-04-02 11:47 ` Sergei Shtylyov
2013-04-03 0:08 ` Kuninori Morimoto
2013-04-03 0:08 ` Kuninori Morimoto
2013-04-03 13:22 ` Sergei Shtylyov [this message]
2013-04-03 13:22 ` Sergei Shtylyov
2013-04-04 6:34 ` Simon Horman
2013-04-04 6:34 ` Simon Horman
2013-04-04 9:04 ` Simon Horman
2013-04-04 9:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515C2D0E.8010607@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.