All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Tue, 02 Apr 2013 00:27:13 +0000	[thread overview]
Message-ID: <87wqsl6ale.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <201304020204.54546.sergei.shtylyov@cogentembedded.com>


Hi Sergei again

> +void __init r8a7779_add_ether_device(void *pdata)
> +{
> +	ether_device.dev.platform_data = pdata;
> +
> +	platform_device_register(&ether_device);
> +}

We didn't use this style of registration before,
but, it is OK.
Then, this (void *pdata) should be
(struct sh_eth_plat_data *pdata) IMO

Best regards
---
Kuninori Morimoto

WARNING: multiple messages have this Message-ID (diff)
From: kuninori.morimoto.gx@renesas.com (Kuninori Morimoto)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Mon, 01 Apr 2013 17:27:13 -0700 (PDT)	[thread overview]
Message-ID: <87wqsl6ale.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <201304020204.54546.sergei.shtylyov@cogentembedded.com>


Hi Sergei again

> +void __init r8a7779_add_ether_device(void *pdata)
> +{
> +	ether_device.dev.platform_data = pdata;
> +
> +	platform_device_register(&ether_device);
> +}

We didn't use this style of registration before,
but, it is OK.
Then, this (void *pdata) should be
(struct sh_eth_plat_data *pdata) IMO

Best regards
---
Kuninori Morimoto

  parent reply	other threads:[~2013-04-02  0:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 22:04 [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support Sergei Shtylyov
2013-04-01 22:04 ` Sergei Shtylyov
2013-04-02  0:17 ` Kuninori Morimoto
2013-04-02  0:17   ` Kuninori Morimoto
2013-04-02 11:45   ` Sergei Shtylyov
2013-04-02 11:45     ` Sergei Shtylyov
2013-04-03  0:25     ` Kuninori Morimoto
2013-04-03  0:25       ` Kuninori Morimoto
2013-04-03 13:27       ` Sergei Shtylyov
2013-04-03 13:27         ` Sergei Shtylyov
2013-04-04  9:03         ` Simon Horman
2013-04-04  9:03           ` Simon Horman
2013-04-02  0:27 ` Kuninori Morimoto [this message]
2013-04-02  0:27   ` Kuninori Morimoto
2013-04-02 11:47   ` Sergei Shtylyov
2013-04-02 11:47     ` Sergei Shtylyov
2013-04-03  0:08     ` Kuninori Morimoto
2013-04-03  0:08       ` Kuninori Morimoto
2013-04-03 13:22       ` Sergei Shtylyov
2013-04-03 13:22         ` Sergei Shtylyov
2013-04-04  6:34         ` Simon Horman
2013-04-04  6:34           ` Simon Horman
2013-04-04  9:04           ` Simon Horman
2013-04-04  9:04             ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqsl6ale.wl%kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.