From: Borislav Petkov <bp@alien8.de> To: Sam Ravnborg <sam@ravnborg.org> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>, Andrew Morton <akpm@linux-foundation.org>, "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>, Kyungsik Lee <kyungsik.lee@lge.com>, Michal Marek <mmarek@suse.cz>, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, x86@kernel.org, celinux-dev@lists.celinuxforum.org, linux-arm-kernel@lists.infradead.org, hyojun.im@lge.com, chan.jeong@lge.com, raphael.andy.lee@gmail.com, Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>, Russell King <rmk@arm.linux.org.uk>, Florian Fainelli <florian@openwrt.org>, Yann Collet <yann.collet.73@gmail.com>, Chanho Min <chanho.min@lge.com> Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Date: Wed, 17 Jul 2013 23:44:42 +0200 [thread overview] Message-ID: <20130717214441.GB4454@pd.tnic> (raw) In-Reply-To: <20130717211649.GA5619@merkur.ravnborg.org> On Wed, Jul 17, 2013 at 11:16:49PM +0200, Sam Ravnborg wrote: > + > +static void exec_command(const char *command, struct symbol *sym) > +{ > + char buffer[2048]; > + FILE *stream; Just some indentation level saving: > + > + stream = popen(command, "r"); > + > + if (stream != NULL) { if (!stream) { menu_warn(current_entry, "command '%s' failed to execute", command); return; } and the rest starts one level less to the right: if (fgets(buffer, sizeof(buffer), stream) != NULL) { int i; buffer[sizeof(buffer) - 1] = '\0'; and so on... > + > + /* Drop any trialing newlines */ > + i = strlen(buffer); > + while (i > 0 && buffer[i - 1] == '\n') { > + buffer[i - 1] = '\0'; > + i--; > + } > + /* Validate the output of the command */ > + if (strlen(buffer) == 0) { > + menu_warn(current_entry, > + "command '%s' - invalid (empty?) return value: \"%s\"", > + command, buffer); > + return; > + } > + > + menu_warn(current_entry, "default: %s", buffer); > + sym_add_default(sym, buffer); > + } else { > + menu_warn(current_entry, "command '%s' - empty return value", command); > + } > + pclose(stream); > + } else { > + menu_warn(current_entry, "command '%s' failed to execute", command); > + } > +} -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --
WARNING: multiple messages have this Message-ID (diff)
From: bp@alien8.de (Borislav Petkov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Date: Wed, 17 Jul 2013 23:44:42 +0200 [thread overview] Message-ID: <20130717214441.GB4454@pd.tnic> (raw) In-Reply-To: <20130717211649.GA5619@merkur.ravnborg.org> On Wed, Jul 17, 2013 at 11:16:49PM +0200, Sam Ravnborg wrote: > + > +static void exec_command(const char *command, struct symbol *sym) > +{ > + char buffer[2048]; > + FILE *stream; Just some indentation level saving: > + > + stream = popen(command, "r"); > + > + if (stream != NULL) { if (!stream) { menu_warn(current_entry, "command '%s' failed to execute", command); return; } and the rest starts one level less to the right: if (fgets(buffer, sizeof(buffer), stream) != NULL) { int i; buffer[sizeof(buffer) - 1] = '\0'; and so on... > + > + /* Drop any trialing newlines */ > + i = strlen(buffer); > + while (i > 0 && buffer[i - 1] == '\n') { > + buffer[i - 1] = '\0'; > + i--; > + } > + /* Validate the output of the command */ > + if (strlen(buffer) == 0) { > + menu_warn(current_entry, > + "command '%s' - invalid (empty?) return value: \"%s\"", > + command, buffer); > + return; > + } > + > + menu_warn(current_entry, "default: %s", buffer); > + sym_add_default(sym, buffer); > + } else { > + menu_warn(current_entry, "command '%s' - empty return value", command); > + } > + pclose(stream); > + } else { > + menu_warn(current_entry, "command '%s' failed to execute", command); > + } > +} -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --
next prev parent reply other threads:[~2013-07-17 21:44 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-06 8:42 [PATCH -next 1/2] arm: Remove enforced Os flag for LZ4 decompressor Kyungsik Lee 2013-05-06 8:42 ` Kyungsik Lee 2013-05-06 8:42 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Kyungsik Lee 2013-05-06 8:42 ` Kyungsik Lee 2013-05-06 9:51 ` Borislav Petkov 2013-05-06 9:51 ` Borislav Petkov 2013-07-10 8:12 ` Geert Uytterhoeven 2013-07-10 8:12 ` Geert Uytterhoeven 2013-07-10 8:12 ` Geert Uytterhoeven 2013-07-10 9:36 ` Borislav Petkov 2013-07-10 9:36 ` Borislav Petkov 2013-07-10 9:36 ` Borislav Petkov 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 20:01 ` Borislav Petkov 2013-07-10 20:01 ` Borislav Petkov 2013-07-10 20:01 ` Borislav Petkov 2013-07-10 20:01 ` Borislav Petkov 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 9:46 ` [PATCH] .gitignore: ignore *.lz4 files Markus Trippelsdorf 2013-07-11 9:46 ` Markus Trippelsdorf 2013-07-11 9:46 ` Markus Trippelsdorf 2013-07-11 9:46 ` Markus Trippelsdorf 2013-07-12 7:56 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Ingo Molnar 2013-07-12 7:56 ` Ingo Molnar 2013-07-12 8:01 ` Borislav Petkov 2013-07-12 8:01 ` Borislav Petkov 2013-07-12 10:13 ` Ingo Molnar 2013-07-12 10:13 ` Ingo Molnar 2013-07-12 10:23 ` Borislav Petkov 2013-07-12 10:23 ` Borislav Petkov 2013-07-12 11:18 ` Andrew Morton 2013-07-12 11:18 ` Andrew Morton 2013-07-12 12:06 ` Ingo Molnar 2013-07-12 12:06 ` Ingo Molnar 2013-07-12 12:13 ` Borislav Petkov 2013-07-12 12:13 ` Borislav Petkov 2013-07-12 12:34 ` Florian Fainelli 2013-07-12 12:34 ` Florian Fainelli 2013-07-12 12:34 ` Florian Fainelli 2013-07-12 12:46 ` Borislav Petkov 2013-07-12 12:46 ` Borislav Petkov 2013-07-12 12:46 ` Borislav Petkov 2013-07-15 22:03 ` Andrew Morton 2013-07-15 22:03 ` Andrew Morton 2013-07-15 22:08 ` H. Peter Anvin 2013-07-15 22:08 ` H. Peter Anvin 2013-07-16 7:47 ` Andrew Morton 2013-07-16 7:47 ` Andrew Morton 2013-07-16 7:56 ` Andrew Morton 2013-07-16 7:56 ` Andrew Morton 2013-07-16 8:08 ` Yann E. MORIN 2013-07-16 8:08 ` Yann E. MORIN 2013-07-16 8:27 ` Andrew Morton 2013-07-16 8:27 ` Andrew Morton 2013-07-16 9:05 ` Borislav Petkov 2013-07-16 9:05 ` Borislav Petkov 2013-07-16 9:12 ` Yann E. MORIN 2013-07-16 9:12 ` Yann E. MORIN 2013-07-16 9:22 ` Borislav Petkov 2013-07-16 9:22 ` Borislav Petkov 2013-07-16 9:32 ` Yann E. MORIN 2013-07-16 9:32 ` Yann E. MORIN 2013-07-16 9:38 ` Borislav Petkov 2013-07-16 9:38 ` Borislav Petkov 2013-07-16 9:45 ` Yann E. MORIN 2013-07-16 9:45 ` Yann E. MORIN 2013-07-16 9:59 ` Borislav Petkov 2013-07-16 9:59 ` Borislav Petkov 2013-07-16 10:04 ` Florian Fainelli 2013-07-16 10:04 ` Florian Fainelli 2013-07-16 10:04 ` Florian Fainelli 2013-07-16 18:04 ` Sam Ravnborg 2013-07-16 18:04 ` Sam Ravnborg 2013-07-17 21:16 ` Sam Ravnborg 2013-07-17 21:16 ` Sam Ravnborg 2013-07-17 21:44 ` Borislav Petkov [this message] 2013-07-17 21:44 ` Borislav Petkov 2013-07-17 22:30 ` Yann E. MORIN 2013-07-17 22:30 ` Yann E. MORIN 2013-07-17 23:22 ` H. Peter Anvin 2013-07-17 23:22 ` H. Peter Anvin 2013-07-18 8:02 ` Geert Uytterhoeven 2013-07-18 8:02 ` Geert Uytterhoeven 2013-07-18 8:02 ` Geert Uytterhoeven 2013-07-18 7:22 ` Geert Uytterhoeven 2013-07-18 7:22 ` Geert Uytterhoeven 2013-07-18 7:22 ` Geert Uytterhoeven 2013-07-18 7:34 ` Andrew Morton 2013-07-18 7:34 ` Andrew Morton 2013-07-18 7:34 ` Andrew Morton 2013-07-18 7:47 ` Yann E. MORIN 2013-07-18 7:47 ` Yann E. MORIN 2013-07-18 7:47 ` Yann E. MORIN 2013-07-18 7:52 ` Andrew Morton 2013-07-18 7:52 ` Andrew Morton 2013-07-18 7:52 ` Andrew Morton 2013-07-18 20:47 ` Sam Ravnborg 2013-07-18 20:47 ` Sam Ravnborg 2013-07-16 9:13 ` Florian Fainelli 2013-07-16 9:13 ` Florian Fainelli 2013-07-16 9:13 ` Florian Fainelli 2013-07-16 9:25 ` Yann E. MORIN 2013-07-16 9:25 ` Yann E. MORIN 2013-07-16 9:25 ` Yann E. MORIN
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20130717214441.GB4454@pd.tnic \ --to=bp@alien8.de \ --cc=akpm@linux-foundation.org \ --cc=celinux-dev@lists.celinuxforum.org \ --cc=chan.jeong@lge.com \ --cc=chanho.min@lge.com \ --cc=florian@openwrt.org \ --cc=hpa@zytor.com \ --cc=hyojun.im@lge.com \ --cc=kyungsik.lee@lge.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=mingo@kernel.org \ --cc=mmarek@suse.cz \ --cc=raphael.andy.lee@gmail.com \ --cc=rmk@arm.linux.org.uk \ --cc=sam@ravnborg.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ --cc=yann.collet.73@gmail.com \ --cc=yann.morin.1998@free.fr \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.