From: "Yann E. MORIN" <yann.morin.1998@free.fr> To: Andrew Morton <akpm@linux-foundation.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Sam Ravnborg <sam@ravnborg.org>, "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>, Kyungsik Lee <kyungsik.lee@lge.com>, Michal Marek <mmarek@suse.cz>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-kbuild" <linux-kbuild@vger.kernel.org>, "the arch/x86 maintainers" <x86@kernel.org>, CE Linux Developers List <celinux-dev@lists.celinuxforum.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, hyojun.im@lge.com, chan.jeong@lge.com, Andy Lee <raphael.andy.lee@gmail.com>, Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>, Russell King <rmk@arm.linux.org.uk>, Borislav Petkov <bp@alien8.de>, Florian Fainelli <florian@openwrt.org>, Yann Collet <yann.collet.73@gmail.com>, Chanho Min <chanho.min@lge.com> Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Date: Thu, 18 Jul 2013 09:47:02 +0200 [thread overview] Message-ID: <201307180947.02456.yann.morin.1998@free.fr> (raw) In-Reply-To: <20130718003408.bb9d5b51.akpm@linux-foundation.org> Andrew, All, On Thursday 18 July 2013 09:34:08 Andrew Morton wrote: > On Thu, 18 Jul 2013 09:22:58 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Thu, Jul 18, 2013 at 12:30 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: > > >> > We could extend the symbol option part to retreive values from a binary. > > >> > Something like this: > > >> > > > >> > config FOOBAR > > >> > bool > > >> > option exec="true" > > >> > > > >> > FOOBAR would assume the value "y" if the command true has exit code == 0, otherwise "n". > > >> > And similar conversions for other types. > > >> > > > >> > This only extendt Kconfig slightly - using an already present method to import > > >> > external values. > > >> Following is a quick patch implmenting this idea. > > >> You need to run gperf manually to enable this. > > >> > > >> "gperf -C scripts/kconfig/zconf.gperf > scripts/kconfig/zconf.hash.c" > > >> > > >> I did not figure out how to use the built-in rules to generate this file :-( > > > > > > make REGENERATE_PARSERS=y menuconfig > > > > > >> I have tested this lightly - as we should discuss if this is a viable way forward. > > > > > > Instead of extending the Kconfig language, I was thinking (as initially > > > suggested by Andrew) of generating a Kconfig file before all config > > > targets, and source that Kconfig file from $(TOPDIR)/Kconfig. > > > > I also prefer the generated Kconfig file. > > It keeps all these checks in a single place, instead of spreading it over all > > Kconfig files. This allows to keep better control over the list of checks, and > > notice when it gets out-of-hand. > > I prefer the "option exec" approach, actually. That way the shell-outs > are colocated with the code which uses Indeed, but in this case, all the checks will be spread-out in the Kconfig files, and not easily locatable. Having all in a single script will also more easily raise eyebrows when that script appears in a diffstat. Noticing the 'exec' option risks being a bit less easy. But, that's not my call to decide. ;-) > them and they will only be executed > if you've actually selected that subsystem for building (I think?). If I understand the code correctly (which is still to be proven), the exec option is run at parse-time, once. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ | | --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no | | http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. | '------------------------------'-------'------------------'--------------------'
WARNING: multiple messages have this Message-ID (diff)
From: yann.morin.1998@free.fr (Yann E. MORIN) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Date: Thu, 18 Jul 2013 09:47:02 +0200 [thread overview] Message-ID: <201307180947.02456.yann.morin.1998@free.fr> (raw) In-Reply-To: <20130718003408.bb9d5b51.akpm@linux-foundation.org> Andrew, All, On Thursday 18 July 2013 09:34:08 Andrew Morton wrote: > On Thu, 18 Jul 2013 09:22:58 +0200 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Thu, Jul 18, 2013 at 12:30 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > On 2013-07-17 23:16 +0200, Sam Ravnborg spake thusly: > > >> > We could extend the symbol option part to retreive values from a binary. > > >> > Something like this: > > >> > > > >> > config FOOBAR > > >> > bool > > >> > option exec="true" > > >> > > > >> > FOOBAR would assume the value "y" if the command true has exit code == 0, otherwise "n". > > >> > And similar conversions for other types. > > >> > > > >> > This only extendt Kconfig slightly - using an already present method to import > > >> > external values. > > >> Following is a quick patch implmenting this idea. > > >> You need to run gperf manually to enable this. > > >> > > >> "gperf -C scripts/kconfig/zconf.gperf > scripts/kconfig/zconf.hash.c" > > >> > > >> I did not figure out how to use the built-in rules to generate this file :-( > > > > > > make REGENERATE_PARSERS=y menuconfig > > > > > >> I have tested this lightly - as we should discuss if this is a viable way forward. > > > > > > Instead of extending the Kconfig language, I was thinking (as initially > > > suggested by Andrew) of generating a Kconfig file before all config > > > targets, and source that Kconfig file from $(TOPDIR)/Kconfig. > > > > I also prefer the generated Kconfig file. > > It keeps all these checks in a single place, instead of spreading it over all > > Kconfig files. This allows to keep better control over the list of checks, and > > notice when it gets out-of-hand. > > I prefer the "option exec" approach, actually. That way the shell-outs > are colocated with the code which uses Indeed, but in this case, all the checks will be spread-out in the Kconfig files, and not easily locatable. Having all in a single script will also more easily raise eyebrows when that script appears in a diffstat. Noticing the 'exec' option risks being a bit less easy. But, that's not my call to decide. ;-) > them and they will only be executed > if you've actually selected that subsystem for building (I think?). If I understand the code correctly (which is still to be proven), the exec option is run at parse-time, once. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ | | --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no | | http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. | '------------------------------'-------'------------------'--------------------'
next prev parent reply other threads:[~2013-07-18 7:47 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-06 8:42 [PATCH -next 1/2] arm: Remove enforced Os flag for LZ4 decompressor Kyungsik Lee 2013-05-06 8:42 ` Kyungsik Lee 2013-05-06 8:42 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Kyungsik Lee 2013-05-06 8:42 ` Kyungsik Lee 2013-05-06 9:51 ` Borislav Petkov 2013-05-06 9:51 ` Borislav Petkov 2013-07-10 8:12 ` Geert Uytterhoeven 2013-07-10 8:12 ` Geert Uytterhoeven 2013-07-10 8:12 ` Geert Uytterhoeven 2013-07-10 9:36 ` Borislav Petkov 2013-07-10 9:36 ` Borislav Petkov 2013-07-10 9:36 ` Borislav Petkov 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 18:28 ` Markus Trippelsdorf 2013-07-10 20:01 ` Borislav Petkov 2013-07-10 20:01 ` Borislav Petkov 2013-07-10 20:01 ` Borislav Petkov 2013-07-10 20:01 ` Borislav Petkov 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 4:34 ` Kyungsik Lee 2013-07-11 9:46 ` [PATCH] .gitignore: ignore *.lz4 files Markus Trippelsdorf 2013-07-11 9:46 ` Markus Trippelsdorf 2013-07-11 9:46 ` Markus Trippelsdorf 2013-07-11 9:46 ` Markus Trippelsdorf 2013-07-12 7:56 ` [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Ingo Molnar 2013-07-12 7:56 ` Ingo Molnar 2013-07-12 8:01 ` Borislav Petkov 2013-07-12 8:01 ` Borislav Petkov 2013-07-12 10:13 ` Ingo Molnar 2013-07-12 10:13 ` Ingo Molnar 2013-07-12 10:23 ` Borislav Petkov 2013-07-12 10:23 ` Borislav Petkov 2013-07-12 11:18 ` Andrew Morton 2013-07-12 11:18 ` Andrew Morton 2013-07-12 12:06 ` Ingo Molnar 2013-07-12 12:06 ` Ingo Molnar 2013-07-12 12:13 ` Borislav Petkov 2013-07-12 12:13 ` Borislav Petkov 2013-07-12 12:34 ` Florian Fainelli 2013-07-12 12:34 ` Florian Fainelli 2013-07-12 12:34 ` Florian Fainelli 2013-07-12 12:46 ` Borislav Petkov 2013-07-12 12:46 ` Borislav Petkov 2013-07-12 12:46 ` Borislav Petkov 2013-07-15 22:03 ` Andrew Morton 2013-07-15 22:03 ` Andrew Morton 2013-07-15 22:08 ` H. Peter Anvin 2013-07-15 22:08 ` H. Peter Anvin 2013-07-16 7:47 ` Andrew Morton 2013-07-16 7:47 ` Andrew Morton 2013-07-16 7:56 ` Andrew Morton 2013-07-16 7:56 ` Andrew Morton 2013-07-16 8:08 ` Yann E. MORIN 2013-07-16 8:08 ` Yann E. MORIN 2013-07-16 8:27 ` Andrew Morton 2013-07-16 8:27 ` Andrew Morton 2013-07-16 9:05 ` Borislav Petkov 2013-07-16 9:05 ` Borislav Petkov 2013-07-16 9:12 ` Yann E. MORIN 2013-07-16 9:12 ` Yann E. MORIN 2013-07-16 9:22 ` Borislav Petkov 2013-07-16 9:22 ` Borislav Petkov 2013-07-16 9:32 ` Yann E. MORIN 2013-07-16 9:32 ` Yann E. MORIN 2013-07-16 9:38 ` Borislav Petkov 2013-07-16 9:38 ` Borislav Petkov 2013-07-16 9:45 ` Yann E. MORIN 2013-07-16 9:45 ` Yann E. MORIN 2013-07-16 9:59 ` Borislav Petkov 2013-07-16 9:59 ` Borislav Petkov 2013-07-16 10:04 ` Florian Fainelli 2013-07-16 10:04 ` Florian Fainelli 2013-07-16 10:04 ` Florian Fainelli 2013-07-16 18:04 ` Sam Ravnborg 2013-07-16 18:04 ` Sam Ravnborg 2013-07-17 21:16 ` Sam Ravnborg 2013-07-17 21:16 ` Sam Ravnborg 2013-07-17 21:44 ` Borislav Petkov 2013-07-17 21:44 ` Borislav Petkov 2013-07-17 22:30 ` Yann E. MORIN 2013-07-17 22:30 ` Yann E. MORIN 2013-07-17 23:22 ` H. Peter Anvin 2013-07-17 23:22 ` H. Peter Anvin 2013-07-18 8:02 ` Geert Uytterhoeven 2013-07-18 8:02 ` Geert Uytterhoeven 2013-07-18 8:02 ` Geert Uytterhoeven 2013-07-18 7:22 ` Geert Uytterhoeven 2013-07-18 7:22 ` Geert Uytterhoeven 2013-07-18 7:22 ` Geert Uytterhoeven 2013-07-18 7:34 ` Andrew Morton 2013-07-18 7:34 ` Andrew Morton 2013-07-18 7:34 ` Andrew Morton 2013-07-18 7:47 ` Yann E. MORIN [this message] 2013-07-18 7:47 ` Yann E. MORIN 2013-07-18 7:47 ` Yann E. MORIN 2013-07-18 7:52 ` Andrew Morton 2013-07-18 7:52 ` Andrew Morton 2013-07-18 7:52 ` Andrew Morton 2013-07-18 20:47 ` Sam Ravnborg 2013-07-18 20:47 ` Sam Ravnborg 2013-07-16 9:13 ` Florian Fainelli 2013-07-16 9:13 ` Florian Fainelli 2013-07-16 9:13 ` Florian Fainelli 2013-07-16 9:25 ` Yann E. MORIN 2013-07-16 9:25 ` Yann E. MORIN 2013-07-16 9:25 ` Yann E. MORIN
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201307180947.02456.yann.morin.1998@free.fr \ --to=yann.morin.1998@free.fr \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=celinux-dev@lists.celinuxforum.org \ --cc=chan.jeong@lge.com \ --cc=chanho.min@lge.com \ --cc=florian@openwrt.org \ --cc=geert@linux-m68k.org \ --cc=hpa@zytor.com \ --cc=hyojun.im@lge.com \ --cc=kyungsik.lee@lge.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=mingo@kernel.org \ --cc=mmarek@suse.cz \ --cc=raphael.andy.lee@gmail.com \ --cc=rmk@arm.linux.org.uk \ --cc=sam@ravnborg.org \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ --cc=yann.collet.73@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.