From: Thierry Reding <thierry.reding@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 4/9] PCI: mvebu: add support for reset on GPIO
Date: Tue, 13 Aug 2013 10:09:56 +0200 [thread overview]
Message-ID: <20130813080956.GE9316@ulmo> (raw)
In-Reply-To: <1376333215-12885-5-git-send-email-sebastian.hesselbarth@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]
On Mon, Aug 12, 2013 at 08:46:50PM +0200, Sebastian Hesselbarth wrote:
> This patch adds a check for DT passed reset-gpios property and deasserts/
> asserts reset pin on probe/remove with configurable delay. Corresponding
> binding documentation is also updated.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-doc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-pci@vger.kernel.org
> ---
> .../devicetree/bindings/pci/mvebu-pci.txt | 2 ++
> drivers/pci/host/pci-mvebu.c | 33 +++++++++++++++++++-
> 2 files changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mvebu-pci.txt b/Documentation/devicetree/bindings/pci/mvebu-pci.txt
> index 638673a..f2fa261 100644
> --- a/Documentation/devicetree/bindings/pci/mvebu-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/mvebu-pci.txt
> @@ -76,6 +76,8 @@ and the following optional properties:
> - marvell,pcie-lane: the physical PCIe lane number, for ports having
> multiple lanes. If this property is not found, we assume that the
> value is 0.
> +- reset-gpios: optional gpio to PERST#
> +- reset-delay-ms: delay in ms to wait after reset de-assertion
I remember some recent discussion about this, and we now have this reset
framework, so perhaps it makes more sense to use the reset binding for
this? Cc'ing Stephen (as part of the device tree bindings maintainers
team) who was involved in that recent reset bindings discussion.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] PCI: mvebu: add support for reset on GPIO
Date: Tue, 13 Aug 2013 10:09:56 +0200 [thread overview]
Message-ID: <20130813080956.GE9316@ulmo> (raw)
In-Reply-To: <1376333215-12885-5-git-send-email-sebastian.hesselbarth@gmail.com>
On Mon, Aug 12, 2013 at 08:46:50PM +0200, Sebastian Hesselbarth wrote:
> This patch adds a check for DT passed reset-gpios property and deasserts/
> asserts reset pin on probe/remove with configurable delay. Corresponding
> binding documentation is also updated.
>
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-doc at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-pci at vger.kernel.org
> ---
> .../devicetree/bindings/pci/mvebu-pci.txt | 2 ++
> drivers/pci/host/pci-mvebu.c | 33 +++++++++++++++++++-
> 2 files changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mvebu-pci.txt b/Documentation/devicetree/bindings/pci/mvebu-pci.txt
> index 638673a..f2fa261 100644
> --- a/Documentation/devicetree/bindings/pci/mvebu-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/mvebu-pci.txt
> @@ -76,6 +76,8 @@ and the following optional properties:
> - marvell,pcie-lane: the physical PCIe lane number, for ports having
> multiple lanes. If this property is not found, we assume that the
> value is 0.
> +- reset-gpios: optional gpio to PERST#
> +- reset-delay-ms: delay in ms to wait after reset de-assertion
I remember some recent discussion about this, and we now have this reset
framework, so perhaps it makes more sense to use the reset binding for
this? Cc'ing Stephen (as part of the device tree bindings maintainers
team) who was involved in that recent reset bindings discussion.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130813/1383a882/attachment.sig>
next prev parent reply other threads:[~2013-08-13 8:10 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-12 18:46 [PATCH 0/9] ARM: dove: DT PCIe support Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-12 18:46 ` [PATCH 1/9] PCI: mvebu: move clock enable before register access Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-13 7:11 ` Thomas Petazzoni
2013-08-13 7:11 ` Thomas Petazzoni
2013-08-13 9:22 ` Sebastian Hesselbarth
2013-08-13 9:22 ` Sebastian Hesselbarth
2013-08-13 7:58 ` Thierry Reding
2013-08-13 7:58 ` Thierry Reding
2013-08-12 18:46 ` [PATCH 2/9] PCI: mvebu: increment nports only for registered ports Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-13 7:15 ` Thomas Petazzoni
2013-08-13 7:15 ` Thomas Petazzoni
2013-08-13 9:23 ` Sebastian Hesselbarth
2013-08-13 9:23 ` Sebastian Hesselbarth
2013-08-12 18:46 ` [PATCH 3/9] PCI: mvebu: remove subsys_initcall Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-13 7:19 ` Thomas Petazzoni
2013-08-13 7:19 ` Thomas Petazzoni
2013-08-13 8:06 ` Thierry Reding
2013-08-13 8:06 ` Thierry Reding
2013-08-13 9:25 ` Sebastian Hesselbarth
2013-08-13 9:25 ` Sebastian Hesselbarth
2013-08-12 18:46 ` [PATCH 4/9] PCI: mvebu: add support for reset on GPIO Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-13 0:56 ` Kumar Gala
2013-08-13 0:56 ` Kumar Gala
2013-08-13 9:19 ` Sebastian Hesselbarth
2013-08-13 9:19 ` Sebastian Hesselbarth
2013-08-13 8:09 ` Thierry Reding [this message]
2013-08-13 8:09 ` Thierry Reding
2013-08-13 8:30 ` Thomas Petazzoni
2013-08-13 8:30 ` Thomas Petazzoni
2013-08-13 9:59 ` Sascha Hauer
2013-08-13 9:59 ` Sascha Hauer
2013-08-13 10:03 ` Thierry Reding
2013-08-13 10:03 ` Thierry Reding
2013-08-13 10:40 ` Sebastian Hesselbarth
2013-08-13 10:40 ` Sebastian Hesselbarth
2013-08-13 10:59 ` Philipp Zabel
2013-08-13 10:59 ` Philipp Zabel
2013-08-12 18:46 ` [PATCH 5/9] PCI: mvebu: add support for Marvell Dove SoCs Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-12 18:46 ` [PATCH 6/9] ARM: dove: update dove_defconfig with SI5351, PCI, and xHCI Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-12 20:00 ` Jason Cooper
2013-08-12 20:00 ` Jason Cooper
2013-08-12 18:46 ` [PATCH 7/9] ARM: dove: add PCIe controllers to SoC DT Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-12 20:04 ` Jason Cooper
2013-08-12 20:04 ` Jason Cooper
2013-08-13 11:28 ` Sebastian Hesselbarth
2013-08-13 11:28 ` Sebastian Hesselbarth
2013-08-13 13:21 ` Jason Cooper
2013-08-13 13:21 ` Jason Cooper
2013-08-13 13:48 ` Jason Cooper
2013-08-13 13:48 ` Jason Cooper
2013-08-12 18:46 ` [PATCH 8/9] ARM: dove: add initial DT file for Globalscale D3Plug Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-12 18:46 ` [PATCH 9/9] ARM: dove: remove legacy pcie and clock init Sebastian Hesselbarth
2013-08-12 18:46 ` Sebastian Hesselbarth
2013-08-12 20:54 ` [PATCH 0/9] ARM: dove: DT PCIe support Bjorn Helgaas
2013-08-12 20:54 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813080956.GE9316@ulmo \
--to=thierry.reding@gmail.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.