* [meta-oe][PATCH 0/1] Remove busybox bbappend @ 2013-08-23 11:33 Paul Eggleton 2013-08-23 11:33 ` [meta-oe][PATCH 1/1] busybox: remove bbappend Paul Eggleton 0 siblings, 1 reply; 9+ messages in thread From: Paul Eggleton @ 2013-08-23 11:33 UTC (permalink / raw) To: openembedded-devel Note: this patch needs to be applied right after the patch that does the merge of the bbappend in OE-Core (just sent to the OE-Core list). The following changes since commit d4571b3d94d999ad54d8965f0d049dcfd34da504: quagga: two fixes (2013-08-16 11:00:19 -0400) are available in the git repository at: git://git.openembedded.org/meta-openembedded-contrib paule/busybox http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=paule/busybox Paul Eggleton (1): busybox: remove bbappend meta-oe/recipes-core/busybox/busybox/busybox-syslog.default | 1 - meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend | 11 ----------- 2 files changed, 12 deletions(-) delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend -- 1.8.1.2 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [meta-oe][PATCH 1/1] busybox: remove bbappend 2013-08-23 11:33 [meta-oe][PATCH 0/1] Remove busybox bbappend Paul Eggleton @ 2013-08-23 11:33 ` Paul Eggleton 2013-08-23 17:36 ` Khem Raj 2013-09-03 17:59 ` Martin Jansa 0 siblings, 2 replies; 9+ messages in thread From: Paul Eggleton @ 2013-08-23 11:33 UTC (permalink / raw) To: openembedded-devel This bbappend has effectively been merged into OE-Core, although the log buffer size is the busybox default rather than 64K - layers may change this either by providing their own /etc/default/busybox-syslog file (when using systemd) or modifying the CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time config. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> --- meta-oe/recipes-core/busybox/busybox/busybox-syslog.default | 1 - meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend | 11 ----------- 2 files changed, 12 deletions(-) delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend diff --git a/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default b/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default deleted file mode 100644 index 8a21e6d..0000000 --- a/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default +++ /dev/null @@ -1 +0,0 @@ -OPTIONS="-C64" diff --git a/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend deleted file mode 100644 index 7a2f0c3..0000000 --- a/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend +++ /dev/null @@ -1,11 +0,0 @@ -# look for files in the layer first -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" - -SRC_URI += "file://busybox-syslog.default" - -do_install_append() { - install -d ${D}${sysconfdir}/default - install -m 0644 ${WORKDIR}/busybox-syslog.default ${D}${sysconfdir}/default/busybox-syslog -} - -FILES_${PN}-syslog += "${sysconfdir}/default/busybox-syslog" -- 1.8.1.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/1] busybox: remove bbappend 2013-08-23 11:33 ` [meta-oe][PATCH 1/1] busybox: remove bbappend Paul Eggleton @ 2013-08-23 17:36 ` Khem Raj 2013-08-24 9:47 ` Paul Eggleton 2013-09-03 17:59 ` Martin Jansa 1 sibling, 1 reply; 9+ messages in thread From: Khem Raj @ 2013-08-23 17:36 UTC (permalink / raw) To: openembedded-devel On Aug 23, 2013, at 4:33 AM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote: > This bbappend has effectively been merged into OE-Core, although the > log buffer size is the busybox default rather than 64K - layers may > change this either by providing their own /etc/default/busybox-syslog > file (when using systemd) or modifying the > CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time > config I think it would be better if we added this option via a kconfig fragment in OE-Core if DISTRO_FEATURES contained systemd and then remove this from here. I say this because otherwise size of circular buffer goes back to 16k from 64k and may not be enough to hold valuable info. On modern systems I think we can afford 64k. I would even argue to make it default in busybox. having said that, busybox-syslogd may be redundant when using systemd since we have journald with systemd but there might still be lot of use cases of busybox-syslogd. Either of these above approaches are fine with me. > > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> > --- > meta-oe/recipes-core/busybox/busybox/busybox-syslog.default | 1 - > meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend | 11 ----------- > 2 files changed, 12 deletions(-) > delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default > delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend > > diff --git a/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default b/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default > deleted file mode 100644 > index 8a21e6d..0000000 > --- a/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default > +++ /dev/null > @@ -1 +0,0 @@ > -OPTIONS="-C64" > diff --git a/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend > deleted file mode 100644 > index 7a2f0c3..0000000 > --- a/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend > +++ /dev/null > @@ -1,11 +0,0 @@ > -# look for files in the layer first > -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > - > -SRC_URI += "file://busybox-syslog.default" > - > -do_install_append() { > - install -d ${D}${sysconfdir}/default > - install -m 0644 ${WORKDIR}/busybox-syslog.default ${D}${sysconfdir}/default/busybox-syslog > -} > - > -FILES_${PN}-syslog += "${sysconfdir}/default/busybox-syslog" > -- > 1.8.1.2 > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/1] busybox: remove bbappend 2013-08-23 17:36 ` Khem Raj @ 2013-08-24 9:47 ` Paul Eggleton 2013-08-26 21:39 ` Khem Raj 0 siblings, 1 reply; 9+ messages in thread From: Paul Eggleton @ 2013-08-24 9:47 UTC (permalink / raw) To: Khem Raj; +Cc: openembedded-devel On Friday 23 August 2013 10:36:15 Khem Raj wrote: > On Aug 23, 2013, at 4:33 AM, Paul Eggleton <paul.eggleton@linux.intel.com> > wrote: > > This bbappend has effectively been merged into OE-Core, although the > > log buffer size is the busybox default rather than 64K - layers may > > change this either by providing their own /etc/default/busybox-syslog > > file (when using systemd) or modifying the > > CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time > > config > > I think it would be better if we added this option via a kconfig fragment > in OE-Core if DISTRO_FEATURES contained systemd and then remove this from > here. I say this because otherwise size of circular buffer goes back to 16k > from 64k and may not be enough to hold valuable info. Why is this specific to systemd? Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/1] busybox: remove bbappend 2013-08-24 9:47 ` Paul Eggleton @ 2013-08-26 21:39 ` Khem Raj 2013-08-26 21:53 ` Paul Eggleton 0 siblings, 1 reply; 9+ messages in thread From: Khem Raj @ 2013-08-26 21:39 UTC (permalink / raw) To: Paul Eggleton, Otavio Salvador; +Cc: openembedded-devel On Aug 24, 2013, at 2:47 AM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote: > On Friday 23 August 2013 10:36:15 Khem Raj wrote: >> On Aug 23, 2013, at 4:33 AM, Paul Eggleton <paul.eggleton@linux.intel.com> >> wrote: >>> This bbappend has effectively been merged into OE-Core, although the >>> log buffer size is the busybox default rather than 64K - layers may >>> change this either by providing their own /etc/default/busybox-syslog >>> file (when using systemd) or modifying the >>> CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time >>> config >> >> I think it would be better if we added this option via a kconfig fragment >> in OE-Core if DISTRO_FEATURES contained systemd and then remove this from >> here. I say this because otherwise size of circular buffer goes back to 16k >> from 64k and may not be enough to hold valuable info. > > Why is this specific to systemd? It probably is not. Otavio added it, so I am CCing him however this is default used in many distros, just to keep enough messages around while you can affort 64K buffer which is not a huge ask these days. > > Cheers, > Paul > > -- > > Paul Eggleton > Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/1] busybox: remove bbappend 2013-08-26 21:39 ` Khem Raj @ 2013-08-26 21:53 ` Paul Eggleton 2013-08-27 5:03 ` Khem Raj 2013-08-29 22:04 ` Otavio Salvador 0 siblings, 2 replies; 9+ messages in thread From: Paul Eggleton @ 2013-08-26 21:53 UTC (permalink / raw) To: Khem Raj; +Cc: openembedded-devel, Otavio Salvador On Monday 26 August 2013 14:39:10 Khem Raj wrote: > On Aug 24, 2013, at 2:47 AM, Paul Eggleton <paul.eggleton@linux.intel.com> > wrote: > > On Friday 23 August 2013 10:36:15 Khem Raj wrote: > >> On Aug 23, 2013, at 4:33 AM, Paul Eggleton > >> <paul.eggleton@linux.intel.com> wrote: > >>> This bbappend has effectively been merged into OE-Core, although the > >>> log buffer size is the busybox default rather than 64K - layers may > >>> change this either by providing their own /etc/default/busybox-syslog > >>> file (when using systemd) or modifying the > >>> CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time > >>> config > >> > >> I think it would be better if we added this option via a kconfig fragment > >> in OE-Core if DISTRO_FEATURES contained systemd and then remove this from > >> here. I say this because otherwise size of circular buffer goes back to > >> 16k from 64k and may not be enough to hold valuable info. > > > > Why is this specific to systemd? > > It probably is not. Otavio added it, so I am CCing him > however this is default used in many distros, just to keep enough > messages around while you can affort 64K buffer which is not a huge ask > these days. If it's generally useful and not specific to systemd (and it seems it isn't the latter) I'd have to say I agree, let's set the default in our busybox defconfig. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/1] busybox: remove bbappend 2013-08-26 21:53 ` Paul Eggleton @ 2013-08-27 5:03 ` Khem Raj 2013-08-29 22:04 ` Otavio Salvador 1 sibling, 0 replies; 9+ messages in thread From: Khem Raj @ 2013-08-27 5:03 UTC (permalink / raw) To: Paul Eggleton; +Cc: openembedded-devel, Otavio Salvador On Aug 26, 2013, at 2:53 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote: > On Monday 26 August 2013 14:39:10 Khem Raj wrote: >> On Aug 24, 2013, at 2:47 AM, Paul Eggleton <paul.eggleton@linux.intel.com> >> wrote: >>> On Friday 23 August 2013 10:36:15 Khem Raj wrote: >>>> On Aug 23, 2013, at 4:33 AM, Paul Eggleton >>>> <paul.eggleton@linux.intel.com> wrote: >>>>> This bbappend has effectively been merged into OE-Core, although the >>>>> log buffer size is the busybox default rather than 64K - layers may >>>>> change this either by providing their own /etc/default/busybox-syslog >>>>> file (when using systemd) or modifying the >>>>> CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time >>>>> config >>>> >>>> I think it would be better if we added this option via a kconfig fragment >>>> in OE-Core if DISTRO_FEATURES contained systemd and then remove this from >>>> here. I say this because otherwise size of circular buffer goes back to >>>> 16k from 64k and may not be enough to hold valuable info. >>> >>> Why is this specific to systemd? >> >> It probably is not. Otavio added it, so I am CCing him >> however this is default used in many distros, just to keep enough >> messages around while you can affort 64K buffer which is not a huge ask >> these days. > > If it's generally useful and not specific to systemd (and it seems it isn't the > latter) I'd have to say I agree, let's set the default in our busybox > defconfig. > I have no issues with changed the defconfig. > Cheers, > Paul > > -- > > Paul Eggleton > Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/1] busybox: remove bbappend 2013-08-26 21:53 ` Paul Eggleton 2013-08-27 5:03 ` Khem Raj @ 2013-08-29 22:04 ` Otavio Salvador 1 sibling, 0 replies; 9+ messages in thread From: Otavio Salvador @ 2013-08-29 22:04 UTC (permalink / raw) To: OpenEmbedded Devel List On Mon, Aug 26, 2013 at 6:53 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote: > On Monday 26 August 2013 14:39:10 Khem Raj wrote: >> On Aug 24, 2013, at 2:47 AM, Paul Eggleton <paul.eggleton@linux.intel.com> >> wrote: >> > On Friday 23 August 2013 10:36:15 Khem Raj wrote: >> >> On Aug 23, 2013, at 4:33 AM, Paul Eggleton >> >> <paul.eggleton@linux.intel.com> wrote: >> >>> This bbappend has effectively been merged into OE-Core, although the >> >>> log buffer size is the busybox default rather than 64K - layers may >> >>> change this either by providing their own /etc/default/busybox-syslog >> >>> file (when using systemd) or modifying the >> >>> CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time >> >>> config >> >> >> >> I think it would be better if we added this option via a kconfig fragment >> >> in OE-Core if DISTRO_FEATURES contained systemd and then remove this from >> >> here. I say this because otherwise size of circular buffer goes back to >> >> 16k from 64k and may not be enough to hold valuable info. >> > >> > Why is this specific to systemd? >> >> It probably is not. Otavio added it, so I am CCing him >> however this is default used in many distros, just to keep enough >> messages around while you can affort 64K buffer which is not a huge ask >> these days. > > If it's generally useful and not specific to systemd (and it seems it isn't the > latter) I'd have to say I agree, let's set the default in our busybox > defconfig. +1 -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-oe][PATCH 1/1] busybox: remove bbappend 2013-08-23 11:33 ` [meta-oe][PATCH 1/1] busybox: remove bbappend Paul Eggleton 2013-08-23 17:36 ` Khem Raj @ 2013-09-03 17:59 ` Martin Jansa 1 sibling, 0 replies; 9+ messages in thread From: Martin Jansa @ 2013-09-03 17:59 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2128 bytes --] On Fri, Aug 23, 2013 at 12:33:37PM +0100, Paul Eggleton wrote: > This bbappend has effectively been merged into OE-Core, although the > log buffer size is the busybox default rather than 64K - layers may > change this either by providing their own /etc/default/busybox-syslog > file (when using systemd) or modifying the > CONFIG_FEATURE_IPC_SYSLOG_BUFFER_SIZE option in busybox's build time > config. Applied, thanks! > > Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> > --- > meta-oe/recipes-core/busybox/busybox/busybox-syslog.default | 1 - > meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend | 11 ----------- > 2 files changed, 12 deletions(-) > delete mode 100644 meta-oe/recipes-core/busybox/busybox/busybox-syslog.default > delete mode 100644 meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend > > diff --git a/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default b/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default > deleted file mode 100644 > index 8a21e6d..0000000 > --- a/meta-oe/recipes-core/busybox/busybox/busybox-syslog.default > +++ /dev/null > @@ -1 +0,0 @@ > -OPTIONS="-C64" > diff --git a/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend b/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend > deleted file mode 100644 > index 7a2f0c3..0000000 > --- a/meta-oe/recipes-core/busybox/busybox_1.21.1.bbappend > +++ /dev/null > @@ -1,11 +0,0 @@ > -# look for files in the layer first > -FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > - > -SRC_URI += "file://busybox-syslog.default" > - > -do_install_append() { > - install -d ${D}${sysconfdir}/default > - install -m 0644 ${WORKDIR}/busybox-syslog.default ${D}${sysconfdir}/default/busybox-syslog > -} > - > -FILES_${PN}-syslog += "${sysconfdir}/default/busybox-syslog" > -- > 1.8.1.2 > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 205 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-09-03 17:58 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-08-23 11:33 [meta-oe][PATCH 0/1] Remove busybox bbappend Paul Eggleton 2013-08-23 11:33 ` [meta-oe][PATCH 1/1] busybox: remove bbappend Paul Eggleton 2013-08-23 17:36 ` Khem Raj 2013-08-24 9:47 ` Paul Eggleton 2013-08-26 21:39 ` Khem Raj 2013-08-26 21:53 ` Paul Eggleton 2013-08-27 5:03 ` Khem Raj 2013-08-29 22:04 ` Otavio Salvador 2013-09-03 17:59 ` Martin Jansa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.