From: Marek Vasut <marex@denx.de> To: "Lothar Waßmann" <LW@karo-electronics.de> Cc: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>, linux-arm-kernel@lists.infradead.org, "David S. Miller" <davem@davemloft.net> Subject: Re: [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver Date: Thu, 26 Sep 2013 16:04:36 +0200 [thread overview] Message-ID: <201309261604.37168.marex@denx.de> (raw) In-Reply-To: <21060.9453.908125.71858@ipc1.ka-ro> Dear Lothar Waßmann, > Hi Marek, > > some small comments below. > > Marek Vasut writes: > > diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c > > new file mode 100644 > > index 0000000..c2b35c7 > > --- /dev/null > > +++ b/drivers/crypto/mxs-dcp.c > > [...] > > > +/* AES 128 ECB and AES 128 CBC */ > > +static struct crypto_alg dcp_aes_algs[] = { > > + [0] = { > > + .cra_name = "ecb(aes)", > > + .cra_driver_name = "ecb-aes-dcp", > > + .cra_priority = 400, > > + .cra_alignmask = 15, > > + .cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | > > + CRYPTO_ALG_ASYNC | > > + CRYPTO_ALG_NEED_FALLBACK, > > + .cra_init = mxs_dcp_aes_fallback_init, > > + .cra_exit = mxs_dcp_aes_fallback_exit, > > + .cra_blocksize = AES_BLOCK_SIZE, > > + .cra_ctxsize = sizeof(struct dcp_async_ctx), > > + .cra_type = &crypto_ablkcipher_type, > > + .cra_module = THIS_MODULE, > > + .cra_u = { > > + .ablkcipher = { > > + .min_keysize = AES_MIN_KEY_SIZE, > > + .max_keysize = AES_MAX_KEY_SIZE, > > + .setkey = mxs_dcp_aes_setkey, > > + .encrypt = mxs_dcp_aes_ecb_encrypt, > > + .decrypt = mxs_dcp_aes_ecb_decrypt > > + } > > missing ',' after '}' Is this a problem? The last ',' is not needed by the C standard. [...] > > > +static const struct of_device_id mxs_dcp_dt_ids[] = { > > + {.compatible = "fsl,mxs-dcp", .data = NULL,}, > > missing spaces after '{' and before '}' Thanks! Best regards, Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver Date: Thu, 26 Sep 2013 16:04:36 +0200 [thread overview] Message-ID: <201309261604.37168.marex@denx.de> (raw) In-Reply-To: <21060.9453.908125.71858@ipc1.ka-ro> Dear Lothar Wa?mann, > Hi Marek, > > some small comments below. > > Marek Vasut writes: > > diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c > > new file mode 100644 > > index 0000000..c2b35c7 > > --- /dev/null > > +++ b/drivers/crypto/mxs-dcp.c > > [...] > > > +/* AES 128 ECB and AES 128 CBC */ > > +static struct crypto_alg dcp_aes_algs[] = { > > + [0] = { > > + .cra_name = "ecb(aes)", > > + .cra_driver_name = "ecb-aes-dcp", > > + .cra_priority = 400, > > + .cra_alignmask = 15, > > + .cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | > > + CRYPTO_ALG_ASYNC | > > + CRYPTO_ALG_NEED_FALLBACK, > > + .cra_init = mxs_dcp_aes_fallback_init, > > + .cra_exit = mxs_dcp_aes_fallback_exit, > > + .cra_blocksize = AES_BLOCK_SIZE, > > + .cra_ctxsize = sizeof(struct dcp_async_ctx), > > + .cra_type = &crypto_ablkcipher_type, > > + .cra_module = THIS_MODULE, > > + .cra_u = { > > + .ablkcipher = { > > + .min_keysize = AES_MIN_KEY_SIZE, > > + .max_keysize = AES_MAX_KEY_SIZE, > > + .setkey = mxs_dcp_aes_setkey, > > + .encrypt = mxs_dcp_aes_ecb_encrypt, > > + .decrypt = mxs_dcp_aes_ecb_decrypt > > + } > > missing ',' after '}' Is this a problem? The last ',' is not needed by the C standard. [...] > > > +static const struct of_device_id mxs_dcp_dt_ids[] = { > > + {.compatible = "fsl,mxs-dcp", .data = NULL,}, > > missing spaces after '{' and before '}' Thanks! Best regards, Marek Vasut
next prev parent reply other threads:[~2013-09-26 14:04 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-09-26 11:18 [PATCH 1/3] crypto: Fully restore ahash request before completing Marek Vasut 2013-09-26 11:18 ` Marek Vasut 2013-09-26 11:18 ` [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver Marek Vasut 2013-09-26 11:18 ` Marek Vasut 2013-09-26 11:27 ` Fabio Estevam 2013-09-26 11:27 ` Fabio Estevam 2013-09-26 12:07 ` Marek Vasut 2013-09-26 12:07 ` Marek Vasut 2013-09-27 16:03 ` Tobias Rauter 2013-09-27 16:03 ` Tobias Rauter 2013-09-28 3:35 ` Marek Vasut 2013-09-28 3:35 ` Marek Vasut 2013-10-07 9:50 ` Christoph G. Baumann 2013-10-07 9:50 ` Christoph G. Baumann 2013-10-07 15:48 ` Marek Vasut 2013-10-07 15:48 ` Marek Vasut 2013-10-08 4:36 ` Herbert Xu 2013-10-08 4:36 ` Herbert Xu 2013-10-08 10:33 ` Marek Vasut 2013-10-08 10:33 ` Marek Vasut 2013-11-10 17:48 ` Marek Vasut 2013-11-10 17:48 ` Marek Vasut 2013-11-20 11:20 ` Herbert Xu 2013-11-20 11:20 ` Herbert Xu 2013-12-01 22:20 ` Marek Vasut 2013-12-01 22:20 ` Marek Vasut 2013-09-26 12:13 ` Lothar Waßmann 2013-09-26 12:13 ` Lothar Waßmann 2013-09-26 14:04 ` Marek Vasut [this message] 2013-09-26 14:04 ` Marek Vasut 2013-09-26 14:09 ` Lothar Waßmann 2013-09-26 14:09 ` Lothar Waßmann 2013-09-29 22:05 ` Marek Vasut 2013-09-29 22:05 ` Marek Vasut 2013-09-26 12:37 ` Veli-Pekka Peltola 2013-09-26 12:37 ` Veli-Pekka Peltola 2013-09-26 14:02 ` Marek Vasut 2013-09-26 14:02 ` Marek Vasut 2013-09-26 12:48 ` Fabio Estevam 2013-09-26 12:48 ` Fabio Estevam 2013-09-29 22:09 ` Marek Vasut 2013-09-29 22:09 ` Marek Vasut 2013-09-26 11:18 ` [PATCH 3/3] ARM: mxs: dts: Enable DCP for MXS Marek Vasut 2013-09-26 11:18 ` Marek Vasut 2013-09-26 11:36 ` Lothar Waßmann 2013-09-26 11:36 ` Lothar Waßmann 2013-09-26 12:08 ` Marek Vasut 2013-09-26 12:08 ` Marek Vasut 2013-09-29 22:11 ` Marek Vasut 2013-09-29 22:11 ` Marek Vasut
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201309261604.37168.marex@denx.de \ --to=marex@denx.de \ --cc=LW@karo-electronics.de \ --cc=davem@davemloft.net \ --cc=herbert@gondor.apana.org.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.