All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Marek Vasut <marex@denx.de>
Cc: linux-crypto@vger.kernel.org,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Shawn Guo <shawn.guo@linaro.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: mxs: dts: Enable DCP for MXS
Date: Thu, 26 Sep 2013 13:36:10 +0200	[thread overview]
Message-ID: <21060.7210.127710.800708@ipc1.ka-ro> (raw)
In-Reply-To: <1380194306-5243-3-git-send-email-marex@denx.de>

Hi,

Marek Vasut writes:
> Enable the DCP by default on both i.MX23 and i.MX28.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> To: linux-crypto@vger.kernel.org
> ---
>  arch/arm/boot/dts/imx23.dtsi | 4 +++-
>  arch/arm/boot/dts/imx28.dtsi | 5 +++--
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
> index 87faa6e..0630a9a 100644
> --- a/arch/arm/boot/dts/imx23.dtsi
> +++ b/arch/arm/boot/dts/imx23.dtsi
> @@ -337,8 +337,10 @@
>  			};
>  
>  			dcp@80028000 {
> +				compatible = "fsl,mxs-dcp";
>  				reg = <0x80028000 0x2000>;
> -				status = "disabled";
> +				interrupts = <53 54>;
> +				status = "okay";
>  			};
AFAICT the policy seems to be that nodes, that are always enabled
don't get a 'status' property at all.

>  			pxp@8002a000 {
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 918d419..8b5ad60 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -782,9 +782,10 @@
>  			};
>  
>  			dcp: dcp@80028000 {
> +				compatible = "fsl,mxs-dcp";
>  				reg = <0x80028000 0x2000>;
> -				interrupts = <52 53 54>;
> -				compatible = "fsl-dcp";
>
What about drivers/crypto/dcp.c that is currently using this property?


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________

WARNING: multiple messages have this Message-ID (diff)
From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: mxs: dts: Enable DCP for MXS
Date: Thu, 26 Sep 2013 13:36:10 +0200	[thread overview]
Message-ID: <21060.7210.127710.800708@ipc1.ka-ro> (raw)
In-Reply-To: <1380194306-5243-3-git-send-email-marex@denx.de>

Hi,

Marek Vasut writes:
> Enable the DCP by default on both i.MX23 and i.MX28.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> To: linux-crypto at vger.kernel.org
> ---
>  arch/arm/boot/dts/imx23.dtsi | 4 +++-
>  arch/arm/boot/dts/imx28.dtsi | 5 +++--
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx23.dtsi b/arch/arm/boot/dts/imx23.dtsi
> index 87faa6e..0630a9a 100644
> --- a/arch/arm/boot/dts/imx23.dtsi
> +++ b/arch/arm/boot/dts/imx23.dtsi
> @@ -337,8 +337,10 @@
>  			};
>  
>  			dcp at 80028000 {
> +				compatible = "fsl,mxs-dcp";
>  				reg = <0x80028000 0x2000>;
> -				status = "disabled";
> +				interrupts = <53 54>;
> +				status = "okay";
>  			};
AFAICT the policy seems to be that nodes, that are always enabled
don't get a 'status' property at all.

>  			pxp at 8002a000 {
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 918d419..8b5ad60 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -782,9 +782,10 @@
>  			};
>  
>  			dcp: dcp at 80028000 {
> +				compatible = "fsl,mxs-dcp";
>  				reg = <0x80028000 0x2000>;
> -				interrupts = <52 53 54>;
> -				compatible = "fsl-dcp";
>
What about drivers/crypto/dcp.c that is currently using this property?


Lothar Wa?mann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________

  reply	other threads:[~2013-09-26 11:36 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 11:18 [PATCH 1/3] crypto: Fully restore ahash request before completing Marek Vasut
2013-09-26 11:18 ` Marek Vasut
2013-09-26 11:18 ` [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver Marek Vasut
2013-09-26 11:18   ` Marek Vasut
2013-09-26 11:27   ` Fabio Estevam
2013-09-26 11:27     ` Fabio Estevam
2013-09-26 12:07     ` Marek Vasut
2013-09-26 12:07       ` Marek Vasut
2013-09-27 16:03       ` Tobias Rauter
2013-09-27 16:03         ` Tobias Rauter
2013-09-28  3:35         ` Marek Vasut
2013-09-28  3:35           ` Marek Vasut
2013-10-07  9:50           ` Christoph G. Baumann
2013-10-07  9:50             ` Christoph G. Baumann
2013-10-07 15:48             ` Marek Vasut
2013-10-07 15:48               ` Marek Vasut
2013-10-08  4:36               ` Herbert Xu
2013-10-08  4:36                 ` Herbert Xu
2013-10-08 10:33                 ` Marek Vasut
2013-10-08 10:33                   ` Marek Vasut
2013-11-10 17:48                   ` Marek Vasut
2013-11-10 17:48                     ` Marek Vasut
2013-11-20 11:20                     ` Herbert Xu
2013-11-20 11:20                       ` Herbert Xu
2013-12-01 22:20                       ` Marek Vasut
2013-12-01 22:20                         ` Marek Vasut
2013-09-26 12:13   ` Lothar Waßmann
2013-09-26 12:13     ` Lothar Waßmann
2013-09-26 14:04     ` Marek Vasut
2013-09-26 14:04       ` Marek Vasut
2013-09-26 14:09       ` Lothar Waßmann
2013-09-26 14:09         ` Lothar Waßmann
2013-09-29 22:05         ` Marek Vasut
2013-09-29 22:05           ` Marek Vasut
2013-09-26 12:37   ` Veli-Pekka Peltola
2013-09-26 12:37     ` Veli-Pekka Peltola
2013-09-26 14:02     ` Marek Vasut
2013-09-26 14:02       ` Marek Vasut
2013-09-26 12:48   ` Fabio Estevam
2013-09-26 12:48     ` Fabio Estevam
2013-09-29 22:09     ` Marek Vasut
2013-09-29 22:09       ` Marek Vasut
2013-09-26 11:18 ` [PATCH 3/3] ARM: mxs: dts: Enable DCP for MXS Marek Vasut
2013-09-26 11:18   ` Marek Vasut
2013-09-26 11:36   ` Lothar Waßmann [this message]
2013-09-26 11:36     ` Lothar Waßmann
2013-09-26 12:08     ` Marek Vasut
2013-09-26 12:08       ` Marek Vasut
2013-09-29 22:11     ` Marek Vasut
2013-09-29 22:11       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21060.7210.127710.800708@ipc1.ka-ro \
    --to=lw@karo-electronics.de \
    --cc=davem@davemloft.net \
    --cc=fabio.estevam@freescale.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.