All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"David S. Miller" <davem@davemloft.net>,
	Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver
Date: Thu, 26 Sep 2013 08:27:15 -0300	[thread overview]
Message-ID: <CAOMZO5AU_R5aeHKbkGRGuyXsVOVdUwdF5oZXdEZZYs442nFnEA@mail.gmail.com> (raw)
In-Reply-To: <1380194306-5243-2-git-send-email-marex@denx.de>

Hi Marek,

On Thu, Sep 26, 2013 at 8:18 AM, Marek Vasut <marex@denx.de> wrote:
> Add support for the MXS DCP block. The driver currently supports
> SHA-1/SHA-256 hashing and AES-128 CBC/ECB modes. The non-standard
> CRC32 is not yet supported.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> ---
>  drivers/crypto/Kconfig   |   17 +
>  drivers/crypto/Makefile  |    1 +
>  drivers/crypto/mxs-dcp.c | 1082 ++++++++++++++++++++++++++++++++++++++++++++++

What about the existing DCP driver at drivers/crypto/dcp.c ?

Why do we need to have two drivers for the same IP block? It looks
confusing to have both.

Regards,

Fabio Estevam

WARNING: multiple messages have this Message-ID (diff)
From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver
Date: Thu, 26 Sep 2013 08:27:15 -0300	[thread overview]
Message-ID: <CAOMZO5AU_R5aeHKbkGRGuyXsVOVdUwdF5oZXdEZZYs442nFnEA@mail.gmail.com> (raw)
In-Reply-To: <1380194306-5243-2-git-send-email-marex@denx.de>

Hi Marek,

On Thu, Sep 26, 2013 at 8:18 AM, Marek Vasut <marex@denx.de> wrote:
> Add support for the MXS DCP block. The driver currently supports
> SHA-1/SHA-256 hashing and AES-128 CBC/ECB modes. The non-standard
> CRC32 is not yet supported.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> ---
>  drivers/crypto/Kconfig   |   17 +
>  drivers/crypto/Makefile  |    1 +
>  drivers/crypto/mxs-dcp.c | 1082 ++++++++++++++++++++++++++++++++++++++++++++++

What about the existing DCP driver at drivers/crypto/dcp.c ?

Why do we need to have two drivers for the same IP block? It looks
confusing to have both.

Regards,

Fabio Estevam

  reply	other threads:[~2013-09-26 11:27 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 11:18 [PATCH 1/3] crypto: Fully restore ahash request before completing Marek Vasut
2013-09-26 11:18 ` Marek Vasut
2013-09-26 11:18 ` [PATCH 2/3] ARM: mxs: crypto: Add Freescale MXS DCP driver Marek Vasut
2013-09-26 11:18   ` Marek Vasut
2013-09-26 11:27   ` Fabio Estevam [this message]
2013-09-26 11:27     ` Fabio Estevam
2013-09-26 12:07     ` Marek Vasut
2013-09-26 12:07       ` Marek Vasut
2013-09-27 16:03       ` Tobias Rauter
2013-09-27 16:03         ` Tobias Rauter
2013-09-28  3:35         ` Marek Vasut
2013-09-28  3:35           ` Marek Vasut
2013-10-07  9:50           ` Christoph G. Baumann
2013-10-07  9:50             ` Christoph G. Baumann
2013-10-07 15:48             ` Marek Vasut
2013-10-07 15:48               ` Marek Vasut
2013-10-08  4:36               ` Herbert Xu
2013-10-08  4:36                 ` Herbert Xu
2013-10-08 10:33                 ` Marek Vasut
2013-10-08 10:33                   ` Marek Vasut
2013-11-10 17:48                   ` Marek Vasut
2013-11-10 17:48                     ` Marek Vasut
2013-11-20 11:20                     ` Herbert Xu
2013-11-20 11:20                       ` Herbert Xu
2013-12-01 22:20                       ` Marek Vasut
2013-12-01 22:20                         ` Marek Vasut
2013-09-26 12:13   ` Lothar Waßmann
2013-09-26 12:13     ` Lothar Waßmann
2013-09-26 14:04     ` Marek Vasut
2013-09-26 14:04       ` Marek Vasut
2013-09-26 14:09       ` Lothar Waßmann
2013-09-26 14:09         ` Lothar Waßmann
2013-09-29 22:05         ` Marek Vasut
2013-09-29 22:05           ` Marek Vasut
2013-09-26 12:37   ` Veli-Pekka Peltola
2013-09-26 12:37     ` Veli-Pekka Peltola
2013-09-26 14:02     ` Marek Vasut
2013-09-26 14:02       ` Marek Vasut
2013-09-26 12:48   ` Fabio Estevam
2013-09-26 12:48     ` Fabio Estevam
2013-09-29 22:09     ` Marek Vasut
2013-09-29 22:09       ` Marek Vasut
2013-09-26 11:18 ` [PATCH 3/3] ARM: mxs: dts: Enable DCP for MXS Marek Vasut
2013-09-26 11:18   ` Marek Vasut
2013-09-26 11:36   ` Lothar Waßmann
2013-09-26 11:36     ` Lothar Waßmann
2013-09-26 12:08     ` Marek Vasut
2013-09-26 12:08       ` Marek Vasut
2013-09-29 22:11     ` Marek Vasut
2013-09-29 22:11       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AU_R5aeHKbkGRGuyXsVOVdUwdF5oZXdEZZYs442nFnEA@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.