From: Dave Young <dyoung@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
ebiederm@xmission.com, horms@verge.net.au,
kexec@lists.infradead.org, bp@alien8.de
Subject: Re: [patch 4/7 v2] export more efi table variable to sysfs
Date: Tue, 12 Nov 2013 16:24:01 +0800 [thread overview]
Message-ID: <20131112082401.GA13899@dhcp-16-126.nay.redhat.com> (raw)
In-Reply-To: <20131112081937.GE6999@dhcp-16-126.nay.redhat.com>
On 11/12/13 at 04:19pm, Dave Young wrote:
> On 11/11/13 at 04:40pm, Greg KH wrote:
> > On Tue, Nov 05, 2013 at 04:20:11PM +0800, dyoung@redhat.com wrote:
> > > Export fw_vendor, runtime and config tables physical
> > > addresses to /sys/firmware/efi/systab becaue kexec
> > > kernel will need them.
> >
> > sysfs files are one-value-per-file.
> >
> > Please don't abuse this and add more values to this single file, in
> > fact, it should be broken up into individual sysfs files as it is,
> > because this isn't ok now.
> >
> > Sorry, you don't get to abuse this anymore :(
>
> Ok, I know this, just creating this without thinking about carefully.
> Will redo the patch, thanks for catching.
I would like to add new files for the values used in this patchset.
And will split the original systab later in another patchset.
>
> Thanks
> Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [patch 4/7 v2] export more efi table variable to sysfs
Date: Tue, 12 Nov 2013 16:24:01 +0800 [thread overview]
Message-ID: <20131112082401.GA13899@dhcp-16-126.nay.redhat.com> (raw)
In-Reply-To: <20131112081937.GE6999-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On 11/12/13 at 04:19pm, Dave Young wrote:
> On 11/11/13 at 04:40pm, Greg KH wrote:
> > On Tue, Nov 05, 2013 at 04:20:11PM +0800, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org wrote:
> > > Export fw_vendor, runtime and config tables physical
> > > addresses to /sys/firmware/efi/systab becaue kexec
> > > kernel will need them.
> >
> > sysfs files are one-value-per-file.
> >
> > Please don't abuse this and add more values to this single file, in
> > fact, it should be broken up into individual sysfs files as it is,
> > because this isn't ok now.
> >
> > Sorry, you don't get to abuse this anymore :(
>
> Ok, I know this, just creating this without thinking about carefully.
> Will redo the patch, thanks for catching.
I would like to add new files for the values used in this patchset.
And will split the original systab later in another patchset.
>
> Thanks
> Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Young <dyoung@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com, horms@verge.net.au,
bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com,
vgoyal@redhat.com
Subject: Re: [patch 4/7 v2] export more efi table variable to sysfs
Date: Tue, 12 Nov 2013 16:24:01 +0800 [thread overview]
Message-ID: <20131112082401.GA13899@dhcp-16-126.nay.redhat.com> (raw)
In-Reply-To: <20131112081937.GE6999@dhcp-16-126.nay.redhat.com>
On 11/12/13 at 04:19pm, Dave Young wrote:
> On 11/11/13 at 04:40pm, Greg KH wrote:
> > On Tue, Nov 05, 2013 at 04:20:11PM +0800, dyoung@redhat.com wrote:
> > > Export fw_vendor, runtime and config tables physical
> > > addresses to /sys/firmware/efi/systab becaue kexec
> > > kernel will need them.
> >
> > sysfs files are one-value-per-file.
> >
> > Please don't abuse this and add more values to this single file, in
> > fact, it should be broken up into individual sysfs files as it is,
> > because this isn't ok now.
> >
> > Sorry, you don't get to abuse this anymore :(
>
> Ok, I know this, just creating this without thinking about carefully.
> Will redo the patch, thanks for catching.
I would like to add new files for the values used in this patchset.
And will split the original systab later in another patchset.
>
> Thanks
> Dave
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-11-12 8:24 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 8:20 [patch 0/7 v2] kexec kernel efi runtime support dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-05 8:20 ` [patch 1/7 v2] Add function efi_remap_region for remapping to saved virt address dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:38 ` Dave Young
2013-11-14 1:38 ` Dave Young
2013-11-14 1:38 ` Dave Young
2013-11-15 23:02 ` Toshi Kani
2013-11-15 23:02 ` Toshi Kani
2013-11-15 23:02 ` Toshi Kani
2013-11-18 2:09 ` Dave Young
2013-11-18 2:09 ` Dave Young
2013-11-18 2:09 ` Dave Young
2013-11-18 9:37 ` Dave Young
2013-11-18 9:37 ` Dave Young
2013-11-18 9:37 ` Dave Young
2013-11-05 8:20 ` [patch 2/7 v2] x86 efi: reserve boot service fix dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-15 23:10 ` Toshi Kani
2013-11-15 23:10 ` Toshi Kani
2013-11-15 23:10 ` Toshi Kani
2013-11-05 8:20 ` [patch 3/7 v2] Cleanup efi_enter_virtual_mode function dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:39 ` Dave Young
2013-11-14 1:39 ` Dave Young
2013-11-14 1:39 ` Dave Young
2013-11-15 23:21 ` Toshi Kani
2013-11-15 23:21 ` Toshi Kani
2013-11-15 23:21 ` Toshi Kani
2013-11-18 2:08 ` Dave Young
2013-11-18 2:08 ` Dave Young
2013-11-18 2:08 ` Dave Young
2013-11-05 8:20 ` [patch 4/7 v2] export more efi table variable to sysfs dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-12 0:40 ` Greg KH
2013-11-12 0:40 ` Greg KH
2013-11-12 0:40 ` Greg KH
2013-11-12 8:19 ` Dave Young
2013-11-12 8:19 ` Dave Young
2013-11-12 8:19 ` Dave Young
2013-11-12 8:24 ` Dave Young [this message]
2013-11-12 8:24 ` Dave Young
2013-11-12 8:24 ` Dave Young
2013-11-12 8:31 ` Greg KH
2013-11-12 8:31 ` Greg KH
2013-11-12 8:31 ` Greg KH
2013-11-05 8:20 ` [patch 5/7 v2] export efi runtime memory mapping " dyoung
2013-11-05 8:20 ` dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:50 ` Dave Young
2013-11-14 1:50 ` Dave Young
2013-11-14 1:50 ` Dave Young
2013-11-18 2:16 ` Dave Young
2013-11-18 2:16 ` Dave Young
2013-11-18 2:16 ` Dave Young
2013-11-19 12:18 ` Matt Fleming
2013-11-19 12:18 ` Matt Fleming
2013-11-19 12:18 ` Matt Fleming
2013-11-05 8:20 ` [patch 6/7 v2] passing kexec necessary efi data via setup_data dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:52 ` Dave Young
2013-11-14 1:52 ` Dave Young
2013-11-14 1:52 ` Dave Young
2013-11-05 8:20 ` [patch 7/7 v2] x86: add xloadflags bit for efi runtime support on kexec dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:53 ` Dave Young
2013-11-14 1:53 ` Dave Young
2013-11-14 1:53 ` Dave Young
2013-11-13 16:20 ` H. Peter Anvin
2013-11-13 16:20 ` H. Peter Anvin
2013-11-13 16:20 ` H. Peter Anvin
2013-11-14 1:36 ` Dave Young
2013-11-14 1:36 ` Dave Young
2013-11-14 1:36 ` Dave Young
2013-11-05 14:40 ` [patch 0/7 v2] kexec kernel efi runtime support Borislav Petkov
2013-11-05 14:40 ` Borislav Petkov
2013-11-05 14:40 ` Borislav Petkov
2013-11-08 14:31 ` Matt Fleming
2013-11-08 14:31 ` Matt Fleming
2013-11-08 14:31 ` Matt Fleming
2013-11-09 3:57 ` Dave Young
2013-11-09 3:57 ` Dave Young
2013-11-09 3:57 ` Dave Young
2013-11-09 5:01 ` H. Peter Anvin
2013-11-09 5:01 ` H. Peter Anvin
2013-11-09 5:01 ` H. Peter Anvin
2013-11-11 2:13 ` Dave Young
2013-11-11 2:13 ` Dave Young
2013-11-11 2:13 ` Dave Young
2013-11-11 2:21 ` H. Peter Anvin
2013-11-11 2:21 ` H. Peter Anvin
2013-11-11 2:21 ` H. Peter Anvin
2013-11-11 2:47 ` Dave Young
2013-11-11 2:47 ` Dave Young
2013-11-11 2:47 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112082401.GA13899@dhcp-16-126.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.