From: Matt Fleming <matt@console-pimps.org>
To: Dave Young <dyoung@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
x86@kernel.org, mjg59@srcf.ucam.org, hpa@zytor.com,
James.Bottomley@HansenPartnership.com, vgoyal@redhat.com,
ebiederm@xmission.com, horms@verge.net.au,
kexec@lists.infradead.org, bp@alien8.de
Subject: Re: [patch 5/7 v2] export efi runtime memory mapping to sysfs
Date: Tue, 19 Nov 2013 12:18:14 +0000 [thread overview]
Message-ID: <20131119121814.GB11521@console-pimps.org> (raw)
In-Reply-To: <20131118021641.GC4025@dhcp-16-126.nay.redhat.com>
On Mon, 18 Nov, at 10:16:41AM, Dave Young wrote:
> Matt, desc_version is already in boot_params.efi_info, so kexec-tools
> can get the version from there. I do not need to export it as another
> file.
OK, cool.
> I think for now we do not need worry much about the compatibility
> issue, do you think I need add version checking in kexec-tools
> currently? like below?
>
> if (desc_version != 1) /* current version is 1? */
> error out it is not supported
Yes, something like that. If you already have kexec-specific ways of
checking a version number then that's fine. Just make sure that, if the
EFI memory descriptor structure is extended in the future and more files
are exported for each descriptor, kexec-tools say "I don't know how to
build a data structure for from these files".
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org
Subject: Re: [patch 5/7 v2] export efi runtime memory mapping to sysfs
Date: Tue, 19 Nov 2013 12:18:14 +0000 [thread overview]
Message-ID: <20131119121814.GB11521@console-pimps.org> (raw)
In-Reply-To: <20131118021641.GC4025-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On Mon, 18 Nov, at 10:16:41AM, Dave Young wrote:
> Matt, desc_version is already in boot_params.efi_info, so kexec-tools
> can get the version from there. I do not need to export it as another
> file.
OK, cool.
> I think for now we do not need worry much about the compatibility
> issue, do you think I need add version checking in kexec-tools
> currently? like below?
>
> if (desc_version != 1) /* current version is 1? */
> error out it is not supported
Yes, something like that. If you already have kexec-specific ways of
checking a version number then that's fine. Just make sure that, if the
EFI memory descriptor structure is extended in the future and more files
are exported for each descriptor, kexec-tools say "I don't know how to
build a data structure for from these files".
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: Dave Young <dyoung@redhat.com>
Cc: mjg59@srcf.ucam.org, linux-efi@vger.kernel.org, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com, horms@verge.net.au,
bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com,
vgoyal@redhat.com
Subject: Re: [patch 5/7 v2] export efi runtime memory mapping to sysfs
Date: Tue, 19 Nov 2013 12:18:14 +0000 [thread overview]
Message-ID: <20131119121814.GB11521@console-pimps.org> (raw)
In-Reply-To: <20131118021641.GC4025@dhcp-16-126.nay.redhat.com>
On Mon, 18 Nov, at 10:16:41AM, Dave Young wrote:
> Matt, desc_version is already in boot_params.efi_info, so kexec-tools
> can get the version from there. I do not need to export it as another
> file.
OK, cool.
> I think for now we do not need worry much about the compatibility
> issue, do you think I need add version checking in kexec-tools
> currently? like below?
>
> if (desc_version != 1) /* current version is 1? */
> error out it is not supported
Yes, something like that. If you already have kexec-specific ways of
checking a version number then that's fine. Just make sure that, if the
EFI memory descriptor structure is extended in the future and more files
are exported for each descriptor, kexec-tools say "I don't know how to
build a data structure for from these files".
--
Matt Fleming, Intel Open Source Technology Center
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2013-11-19 12:18 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 8:20 [patch 0/7 v2] kexec kernel efi runtime support dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-05 8:20 ` [patch 1/7 v2] Add function efi_remap_region for remapping to saved virt address dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:38 ` Dave Young
2013-11-14 1:38 ` Dave Young
2013-11-14 1:38 ` Dave Young
2013-11-15 23:02 ` Toshi Kani
2013-11-15 23:02 ` Toshi Kani
2013-11-15 23:02 ` Toshi Kani
2013-11-18 2:09 ` Dave Young
2013-11-18 2:09 ` Dave Young
2013-11-18 2:09 ` Dave Young
2013-11-18 9:37 ` Dave Young
2013-11-18 9:37 ` Dave Young
2013-11-18 9:37 ` Dave Young
2013-11-05 8:20 ` [patch 2/7 v2] x86 efi: reserve boot service fix dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-15 23:10 ` Toshi Kani
2013-11-15 23:10 ` Toshi Kani
2013-11-15 23:10 ` Toshi Kani
2013-11-05 8:20 ` [patch 3/7 v2] Cleanup efi_enter_virtual_mode function dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:39 ` Dave Young
2013-11-14 1:39 ` Dave Young
2013-11-14 1:39 ` Dave Young
2013-11-15 23:21 ` Toshi Kani
2013-11-15 23:21 ` Toshi Kani
2013-11-15 23:21 ` Toshi Kani
2013-11-18 2:08 ` Dave Young
2013-11-18 2:08 ` Dave Young
2013-11-18 2:08 ` Dave Young
2013-11-05 8:20 ` [patch 4/7 v2] export more efi table variable to sysfs dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-12 0:40 ` Greg KH
2013-11-12 0:40 ` Greg KH
2013-11-12 0:40 ` Greg KH
2013-11-12 8:19 ` Dave Young
2013-11-12 8:19 ` Dave Young
2013-11-12 8:19 ` Dave Young
2013-11-12 8:24 ` Dave Young
2013-11-12 8:24 ` Dave Young
2013-11-12 8:24 ` Dave Young
2013-11-12 8:31 ` Greg KH
2013-11-12 8:31 ` Greg KH
2013-11-12 8:31 ` Greg KH
2013-11-05 8:20 ` [patch 5/7 v2] export efi runtime memory mapping " dyoung
2013-11-05 8:20 ` dyoung
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:50 ` Dave Young
2013-11-14 1:50 ` Dave Young
2013-11-14 1:50 ` Dave Young
2013-11-18 2:16 ` Dave Young
2013-11-18 2:16 ` Dave Young
2013-11-18 2:16 ` Dave Young
2013-11-19 12:18 ` Matt Fleming [this message]
2013-11-19 12:18 ` Matt Fleming
2013-11-19 12:18 ` Matt Fleming
2013-11-05 8:20 ` [patch 6/7 v2] passing kexec necessary efi data via setup_data dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:52 ` Dave Young
2013-11-14 1:52 ` Dave Young
2013-11-14 1:52 ` Dave Young
2013-11-05 8:20 ` [patch 7/7 v2] x86: add xloadflags bit for efi runtime support on kexec dyoung
2013-11-05 8:20 ` dyoung
2013-11-05 8:20 ` dyoung-H+wXaHxf7aLQT0dZR+AlfA
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-13 15:50 ` Matt Fleming
2013-11-14 1:53 ` Dave Young
2013-11-14 1:53 ` Dave Young
2013-11-14 1:53 ` Dave Young
2013-11-13 16:20 ` H. Peter Anvin
2013-11-13 16:20 ` H. Peter Anvin
2013-11-13 16:20 ` H. Peter Anvin
2013-11-14 1:36 ` Dave Young
2013-11-14 1:36 ` Dave Young
2013-11-14 1:36 ` Dave Young
2013-11-05 14:40 ` [patch 0/7 v2] kexec kernel efi runtime support Borislav Petkov
2013-11-05 14:40 ` Borislav Petkov
2013-11-05 14:40 ` Borislav Petkov
2013-11-08 14:31 ` Matt Fleming
2013-11-08 14:31 ` Matt Fleming
2013-11-08 14:31 ` Matt Fleming
2013-11-09 3:57 ` Dave Young
2013-11-09 3:57 ` Dave Young
2013-11-09 3:57 ` Dave Young
2013-11-09 5:01 ` H. Peter Anvin
2013-11-09 5:01 ` H. Peter Anvin
2013-11-09 5:01 ` H. Peter Anvin
2013-11-11 2:13 ` Dave Young
2013-11-11 2:13 ` Dave Young
2013-11-11 2:13 ` Dave Young
2013-11-11 2:21 ` H. Peter Anvin
2013-11-11 2:21 ` H. Peter Anvin
2013-11-11 2:21 ` H. Peter Anvin
2013-11-11 2:47 ` Dave Young
2013-11-11 2:47 ` Dave Young
2013-11-11 2:47 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119121814.GB11521@console-pimps.org \
--to=matt@console-pimps.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.