From: dcb <1279257@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false.
Date: Wed, 12 Feb 2014 09:13:07 -0000 [thread overview]
Message-ID: <20140212091307.1972.7704.malonedeb@soybean.canonical.com> (raw)
In-Reply-To: 20140212091307.1972.7704.malonedeb@soybean.canonical.com
Public bug reported:
Source code is
} else if ((buf[1] & 4) == 1) {
Suggest code rework. I found this bug by running
static analyser cppcheck over the source code.
I also checked the latest code on the web and the
bug exists there also.
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1279257
Title:
[hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is
always false.
Status in QEMU:
New
Bug description:
Source code is
} else if ((buf[1] & 4) == 1) {
Suggest code rework. I found this bug by running
static analyser cppcheck over the source code.
I also checked the latest code on the web and the
bug exists there also.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1279257/+subscriptions
next parent reply other threads:[~2014-02-12 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 9:13 dcb [this message]
2014-02-12 11:01 ` [Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false Markus Armbruster
2016-06-17 8:23 ` [Qemu-devel] [Bug 1279257] " T. Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212091307.1972.7704.malonedeb@soybean.canonical.com \
--to=1279257@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.