All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false.
@ 2014-02-12  9:13 dcb
  2014-02-12 11:01 ` Markus Armbruster
  2016-06-17  8:23 ` [Qemu-devel] [Bug 1279257] " T. Huth
  0 siblings, 2 replies; 3+ messages in thread
From: dcb @ 2014-02-12  9:13 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

Source code is

       } else if ((buf[1] & 4) == 1) {

Suggest code rework. I found this bug by running
static analyser cppcheck over the source code.

I also checked the latest code on the web and the
bug exists there also.

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1279257

Title:
  [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is
  always false.

Status in QEMU:
  New

Bug description:
  Source code is

         } else if ((buf[1] & 4) == 1) {

  Suggest code rework. I found this bug by running
  static analyser cppcheck over the source code.

  I also checked the latest code on the web and the
  bug exists there also.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1279257/+subscriptions

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-17  8:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-12  9:13 [Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false dcb
2014-02-12 11:01 ` Markus Armbruster
2016-06-17  8:23 ` [Qemu-devel] [Bug 1279257] " T. Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.