* missing dependency on libxlu_disk_l.h
@ 2014-02-15 22:17 Olaf Hering
2014-02-18 10:18 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2014-02-15 22:17 UTC (permalink / raw)
To: xen-devel
I'm not sure if libxlu_disk_l.h is a generated file. But just once I saw
this failure below with automated build and make -j 16. This source tree
has the discard-enable patch, which changes tools/libxl/libxlu_disk_l.l.
As a result libxlu_disk_l.c is regenerated, see the flex call below.
How should make become aware of the libxlu_disk_l.h dependency?
Olaf
....
[ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_helper.h >_libxl_save_msgs_helper.h.new
[ 126s] python gentypes.py libxl_types.idl __libxl_types.h __libxl_types_json.h __libxl_types.c
[ 126s] python gentypes.py libxl_types_internal.idl __libxl_types_internal.h __libxl_types_internal_json.h __libxl_types_internal.c
[ 126s] if ! cmp -s _libxl_list.h.new _libxl_list.h; then mv -f _libxl_list.h.new _libxl_list.h; else rm -f _libxl_list.h.new; fi
[ 126s] /usr/bin/flex --header-file=libxlu_disk_l.h --outfile=libxlu_disk_l.c libxlu_disk_l.l
[ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_callout.c >_libxl_save_msgs_callout.c.new
[ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_helper.c >_libxl_save_msgs_helper.c.new
[ 126s] sed -e "s/\([^=]*\)=\(.*\)/#define \1 \2/g" _paths.h.tmp >_paths.h.2.tmp
[ 126s] rm -f _paths.h.tmp
--
[ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .flexarray.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/lib
xc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-te
sting/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o flexarray.o flexarray.c
[ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -
I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl.o libxl.c
[ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl_create.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/
libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl_create.o libxl_create.c
[ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl_dm.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libx
c -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl_dm.o libxl_dm.c
[ 126s] libxlu_pci.c:3:27: fatal error: libxlu_disk_l.h: No such file or directory
[ 126s] #include "libxlu_disk_l.h"
[ 126s] ^
[ 126s] compilation terminated.
[ 126s] /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/Rules.mk:89: recipe for target 'libxlu_pci.o' failed
[ 126s] make[3]: *** [libxlu_pci.o] Error 1
[ 126s] make[3]: *** Waiting for unfinished jobs....
[ 126s] libxlu_disk.c:3:27: fatal error: libxlu_disk_l.h: No such file or directory
[ 126s] #include "libxlu_disk_l.h"
[ 126s] ^
[ 126s] compilation terminated.
[ 126s] /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/Rules.mk:89: recipe for target 'libxlu_disk.o' failed
[ 126s] make[3]: *** [libxlu_disk.o] Error 1
....
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: missing dependency on libxlu_disk_l.h
2014-02-15 22:17 missing dependency on libxlu_disk_l.h Olaf Hering
@ 2014-02-18 10:18 ` Ian Campbell
2014-02-18 11:35 ` Ian Jackson
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2014-02-18 10:18 UTC (permalink / raw)
To: Olaf Hering; +Cc: Ian Jackson, xen-devel
On Sat, 2014-02-15 at 23:17 +0100, Olaf Hering wrote:
Please remember to CC the maintainers of the code you are discussing.
Ian J added.
> I'm not sure if libxlu_disk_l.h is a generated file.
It is, but we also check in the generated version, IIRC due to a bug in
some versions of flex, but also partially for convenience to avoid the
need for flex on all development systems.
> But just once I saw
> this failure below with automated build and make -j 16. This source tree
> has the discard-enable patch, which changes tools/libxl/libxlu_disk_l.l.
> As a result libxlu_disk_l.c is regenerated, see the flex call below.
It might be a good idea to either also patch the generated files or to
have the patch remove them, to avoid any possible confusion due to skew.
> How should make become aware of the libxlu_disk_l.h dependency?
I think it would probably need explicitly specifying like we do for the
IDL generated files.
What deleted that file though?
> Olaf
>
> ....
> [ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_helper.h >_libxl_save_msgs_helper.h.new
> [ 126s] python gentypes.py libxl_types.idl __libxl_types.h __libxl_types_json.h __libxl_types.c
> [ 126s] python gentypes.py libxl_types_internal.idl __libxl_types_internal.h __libxl_types_internal_json.h __libxl_types_internal.c
> [ 126s] if ! cmp -s _libxl_list.h.new _libxl_list.h; then mv -f _libxl_list.h.new _libxl_list.h; else rm -f _libxl_list.h.new; fi
> [ 126s] /usr/bin/flex --header-file=libxlu_disk_l.h --outfile=libxlu_disk_l.c libxlu_disk_l.l
> [ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_callout.c >_libxl_save_msgs_callout.c.new
> [ 126s] /usr/bin/perl -w libxl_save_msgs_gen.pl _libxl_save_msgs_helper.c >_libxl_save_msgs_helper.c.new
> [ 126s] sed -e "s/\([^=]*\)=\(.*\)/#define \1 \2/g" _paths.h.tmp >_paths.h.2.tmp
> [ 126s] rm -f _paths.h.tmp
> --
> [ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .flexarray.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/l
ibxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-
testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o flexarray.o flexarray.c
> [ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc
-I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl.o libxl.c
> [ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl_create.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tool
s/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl_create.o libxl_create.c
> [ 126s] gcc -O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .libxl_dm.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -Werror -Wno-format-zero-length -Wmissing-declarations -Wno-declaration-after-statement -Wformat-nonliteral -I. -fPIC -pthread -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/libxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/li
bxc -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/xenstore -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/control -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/blktap2/include -I/home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/include -Wshadow -include /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/config.h -c -o libxl_dm.o libxl_dm.c
> [ 126s] libxlu_pci.c:3:27: fatal error: libxlu_disk_l.h: No such file or directory
> [ 126s] #include "libxlu_disk_l.h"
> [ 126s] ^
> [ 126s] compilation terminated.
> [ 126s] /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/Rules.mk:89: recipe for target 'libxlu_pci.o' failed
> [ 126s] make[3]: *** [libxlu_pci.o] Error 1
> [ 126s] make[3]: *** Waiting for unfinished jobs....
> [ 126s] libxlu_disk.c:3:27: fatal error: libxlu_disk_l.h: No such file or directory
> [ 126s] #include "libxlu_disk_l.h"
> [ 126s] ^
> [ 126s] compilation terminated.
> [ 126s] /home/abuild/rpmbuild/BUILD/xen-4.4.0-testing/tools/libxl/../../tools/Rules.mk:89: recipe for target 'libxlu_disk.o' failed
> [ 126s] make[3]: *** [libxlu_disk.o] Error 1
> ....
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: missing dependency on libxlu_disk_l.h
2014-02-18 10:18 ` Ian Campbell
@ 2014-02-18 11:35 ` Ian Jackson
2014-02-18 13:56 ` Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2014-02-18 11:35 UTC (permalink / raw)
To: Ian Campbell; +Cc: Olaf Hering, Ian Jackson, xen-devel
Ian Campbell writes ("Re: [Xen-devel] missing dependency on libxlu_disk_l.h"):
> On Sat, 2014-02-15 at 23:17 +0100, Olaf Hering wrote:
> > I'm not sure if libxlu_disk_l.h is a generated file.
>
> It is, but we also check in the generated version, IIRC due to a bug in
> some versions of flex, but also partially for convenience to avoid the
> need for flex on all development systems.
Right.
> > But just once I saw
> > this failure below with automated build and make -j 16. This source tree
> > has the discard-enable patch, which changes tools/libxl/libxlu_disk_l.l.
> > As a result libxlu_disk_l.c is regenerated, see the flex call below.
>
> It might be a good idea to either also patch the generated files or to
> have the patch remove them, to avoid any possible confusion due to skew.
This ought to be taken care of by the build system, provided you don't
actually git commit only the change to .l and not the change to .[ch].
In the final patch.
> > How should make become aware of the libxlu_disk_l.h dependency?
>
> I think it would probably need explicitly specifying like we do for the
> IDL generated files.
There is already a place to put this. See diff below. Sorry for not
doing this at the time.
> What deleted that file though?
make might have done.
Olaf, can you test whether this diff makes the problem go away for you ?
Thanks,
Ian.
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index dab2929..755b666 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
$(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
- _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
+ libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: missing dependency on libxlu_disk_l.h
2014-02-18 11:35 ` Ian Jackson
@ 2014-02-18 13:56 ` Olaf Hering
2014-02-18 14:21 ` Olaf Hering
2014-02-18 14:53 ` Ian Jackson
0 siblings, 2 replies; 6+ messages in thread
From: Olaf Hering @ 2014-02-18 13:56 UTC (permalink / raw)
To: Ian Jackson; +Cc: Ian Campbell, xen-devel
On Tue, Feb 18, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] missing dependency on libxlu_disk_l.h"):
> > It might be a good idea to either also patch the generated files or to
> > have the patch remove them, to avoid any possible confusion due to skew.
> This ought to be taken care of by the build system, provided you don't
> actually git commit only the change to .l and not the change to .[ch].
> In the final patch.
In my case the patch changes only the .l file. I expect that all
dependencies are written into the Makefile.
> Olaf, can you test whether this diff makes the problem go away for you ?
Ian, xen.rpm is rebuilt often, but the failure happend exactly once.
I will see if I can force it to fail without the change below.
Olaf
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index dab2929..755b666 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -98,7 +98,7 @@ TEST_PROGS += $(foreach t, $(LIBXL_TESTS),test_$t)
> $(LIBXL_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h
>
> AUTOINCS= libxlu_cfg_y.h libxlu_cfg_l.h _libxl_list.h _paths.h \
> - _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> + libxlu_disk_l.h _libxl_save_msgs_callout.h _libxl_save_msgs_helper.h
> AUTOSRCS= libxlu_cfg_y.c libxlu_cfg_l.c
> AUTOSRCS += _libxl_save_msgs_callout.c _libxl_save_msgs_helper.c
> LIBXLU_OBJS = libxlu_cfg_y.o libxlu_cfg_l.o libxlu_cfg.o \
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: missing dependency on libxlu_disk_l.h
2014-02-18 13:56 ` Olaf Hering
@ 2014-02-18 14:21 ` Olaf Hering
2014-02-18 14:53 ` Ian Jackson
1 sibling, 0 replies; 6+ messages in thread
From: Olaf Hering @ 2014-02-18 14:21 UTC (permalink / raw)
To: Ian Jackson; +Cc: Ian Campbell, xen-devel
On Tue, Feb 18, Olaf Hering wrote:
> I will see if I can force it to fail without the change below.
With "env FLEX=$PWD/my_flex.sh ./configure ..." the build fails.
#!/bin/bash
set -ex
rm -fv /src/dir/tools/*/libxlu_disk_l.h
sleep 12
exec /usr/bin/flex "$@"
And with the patch applied the build works fine. Thanks!
Olaf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: missing dependency on libxlu_disk_l.h
2014-02-18 13:56 ` Olaf Hering
2014-02-18 14:21 ` Olaf Hering
@ 2014-02-18 14:53 ` Ian Jackson
1 sibling, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2014-02-18 14:53 UTC (permalink / raw)
To: Olaf Hering; +Cc: Ian Jackson, Ian Campbell, xen-devel
Olaf Hering writes ("Re: [Xen-devel] missing dependency on libxlu_disk_l.h"):
> On Tue, Feb 18, Ian Jackson wrote:
> > This ought to be taken care of by the build system, provided you don't
> > actually git commit only the change to .l and not the change to .[ch].
> > In the final patch.
>
> In my case the patch changes only the .l file. I expect that all
> dependencies are written into the Makefile.
Yes, and they are. But if you edit the .l file, commit it, and then
do various gitish things, you might end up with the .l and the
generated .[ch] having "wrong" timestamps which persuade make not to
rebuild it.
> > Olaf, can you test whether this diff makes the problem go away for you ?
>
> Ian, xen.rpm is rebuilt often, but the failure happend exactly once.
> I will see if I can force it to fail without the change below.
Thanks,
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-18 14:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-15 22:17 missing dependency on libxlu_disk_l.h Olaf Hering
2014-02-18 10:18 ` Ian Campbell
2014-02-18 11:35 ` Ian Jackson
2014-02-18 13:56 ` Olaf Hering
2014-02-18 14:21 ` Olaf Hering
2014-02-18 14:53 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.