From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6: add support for Ka-Ro TX6 modules
Date: Mon, 24 Mar 2014 13:01:29 +0100 [thread overview]
Message-ID: <20140324130129.1c2ec444@ipc1.ka-ro> (raw)
In-Reply-To: <20140322082352.GF5938@dragon>
Hi Shawn,
it would help readability a lot if you would trim down the quoted parts
of the original mail (like I did with [...] in this reply).
Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:29:44PM +0100, Lothar Waßmann wrote:
> > This patch adds support for the Ka-Ro electronics GmbH TX6 modules.
> > There are five distinct module types with either i.MX6Q or i.MX6DL and
> > LVDS or LCD display interface and one DTS file for a complete system
> > with an i.MX6DL based TX6 module and a baseboard mounted on the back
> > of a display (imx6dl-tx6dl-comtft.dts).
> >
> > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> > ---
> > arch/arm/boot/dts/Makefile | 6 +
> > arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts | 114 +++++
> > arch/arm/boot/dts/imx6dl-tx6u-801x.dts | 188 ++++++++
> > arch/arm/boot/dts/imx6dl-tx6u-811x.dts | 166 +++++++
> > arch/arm/boot/dts/imx6q-tx6q-1010.dts | 192 +++++++++
> > arch/arm/boot/dts/imx6q-tx6q-1020.dts | 192 +++++++++
> > arch/arm/boot/dts/imx6q-tx6q-1110.dts | 174 ++++++++
> > arch/arm/boot/dts/imx6qdl-tx6.dtsi | 672 +++++++++++++++++++++++++++++
> > 8 files changed, 1704 insertions(+)
> > create mode 100644 arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts
> > create mode 100644 arch/arm/boot/dts/imx6dl-tx6u-801x.dts
> > create mode 100644 arch/arm/boot/dts/imx6dl-tx6u-811x.dts
> > create mode 100644 arch/arm/boot/dts/imx6q-tx6q-1010.dts
> > create mode 100644 arch/arm/boot/dts/imx6q-tx6q-1020.dts
> > create mode 100644 arch/arm/boot/dts/imx6q-tx6q-1110.dts
> > create mode 100644 arch/arm/boot/dts/imx6qdl-tx6.dtsi
> >
[...]
> > diff --git a/arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts b/arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts
> > new file mode 100644
> > index 0000000..6df5a25
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts
> > @@ -0,0 +1,114 @@
> > +/*
> > + * Copyright 2014 Lothar Waßmann <LW@KARO-electronics.de>
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx6dl.dtsi"
> > +#include "imx6qdl-tx6.dtsi"
> > +
> > +/ {
> > + model = "Ka-Ro electronics TX6DL Module on CoMpact TFT";
> > + compatible = "fsl,imx6dl-tx6dl", "fsl,imx6dl";
>
> Shouldn't it be "karo,imx6dl-tx6dl" instead?
>
Of course. :(
> > +
> > + aliases {
> > + display = &display;
> > + };
> > +
> > + backlight: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm2 0 500000 0>;
> > + power-supply = <®_3v3>;
> > + /*
> > + * a poor man's way to create a 1:1 relationship between
> > + * the PWM value and the actual duty cycle
> > + */
> > + brightness-levels = < 0 1 2 3 4 5 6 7 8 9
> > + 10 11 12 13 14 15 16 17 18 19
> > + 20 21 22 23 24 25 26 27 28 29
> > + 30 31 32 33 34 35 36 37 38 39
> > + 40 41 42 43 44 45 46 47 48 49
> > + 50 51 52 53 54 55 56 57 58 59
> > + 60 61 62 63 64 65 66 67 68 69
> > + 70 71 72 73 74 75 76 77 78 79
> > + 80 81 82 83 84 85 86 87 88 89
> > + 90 91 92 93 94 95 96 97 98 99
> > + 100>;
> > + default-brightness-level = <50>;
> > + };
> > +
> > + display: display@di0 {
> > + compatible = "fsl,imx-parallel-display";
> > + interface-pix-fmt = "rgb24";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_disp0_1>;
> > + status = "okay";
> > +
> > + port {
> > + display0_in: endpoint {
> > + remote-endpoint = <&ipu1_di0_disp0>;
> > + };
> > + };
>
> I do not have OF graph stuff in my tree yet.
>
You can apply the patch, once it arrives in your tree.
[...]
> > diff --git a/arch/arm/boot/dts/imx6dl-tx6u-811x.dts b/arch/arm/boot/dts/imx6dl-tx6u-811x.dts
> > new file mode 100644
> > index 0000000..c97fb42
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6dl-tx6u-811x.dts
> > @@ -0,0 +1,166 @@
> > +/*
> > + * Copyright 2014 Lothar Waßmann <LW@KARO-electronics.de>
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx6dl.dtsi"
> > +#include "imx6qdl-tx6.dtsi"
> > +
> > +/ {
> > + model = "Ka-Ro electronics TX6U-811x Module";
> > + compatible = "fsl,imx6dl-tx6dl", "fsl,imx6dl";
> > +
> > + aliases {
> > + display = &lvds0;
> > + lvds0 = &lvds0;
> > + lvds1 = &lvds1;
> > + };
> > +
> > + backlight0: backlight0 {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm2 0 500000 0>;
> > + power-supply = <®_lcd0_pwr>;
> > + /*
> > + * a poor man's way to create a 1:1 relationship between
> > + * the PWM value and the actual duty cycle
> > + */
> > + brightness-levels = < 0 1 2 3 4 5 6 7 8 9
> > + 10 11 12 13 14 15 16 17 18 19
> > + 20 21 22 23 24 25 26 27 28 29
> > + 30 31 32 33 34 35 36 37 38 39
> > + 40 41 42 43 44 45 46 47 48 49
> > + 50 51 52 53 54 55 56 57 58 59
> > + 60 61 62 63 64 65 66 67 68 69
> > + 70 71 72 73 74 75 76 77 78 79
> > + 80 81 82 83 84 85 86 87 88 89
> > + 90 91 92 93 94 95 96 97 98 99
> > + 100>;
> > + default-brightness-level = <50>;
> > + };
> > +
> > + backlight1: backlight1 {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm1 0 500000 0>;
> > + power-supply = <®_lcd1_pwr>;
> > + /*
> > + * a poor man's way to create a 1:1 relationship between
> > + * the PWM value and the actual duty cycle
> > + */
> > + brightness-levels = < 0 1 2 3 4 5 6 7 8 9
> > + 10 11 12 13 14 15 16 17 18 19
> > + 20 21 22 23 24 25 26 27 28 29
> > + 30 31 32 33 34 35 36 37 38 39
> > + 40 41 42 43 44 45 46 47 48 49
> > + 50 51 52 53 54 55 56 57 58 59
> > + 60 61 62 63 64 65 66 67 68 69
> > + 70 71 72 73 74 75 76 77 78 79
> > + 80 81 82 83 84 85 86 87 88 89
> > + 90 91 92 93 94 95 96 97 98 99
> > + 100>;
> > + default-brightness-level = <50>;
> > + };
> > +
> > + panel0 {
>
> The convention of device tree node is node-name@unit-address, so in this
> case it should probably be panel@0.
>
AFAIK that's only true for nodes that require a 'reg' property.
Thus if it were:
panels {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <0>;
panel@0 {
compatible = "simple-panel";
reg = <0>;
power-supply = <®_3v3>;
backlight = <&backlight0>;
};
[...]
> > diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> > new file mode 100644
> > index 0000000..828e7f3
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> > @@ -0,0 +1,672 @@
> > +/*
> > + * Copyright 2014 Lothar Waßmann <LW@KARO-electronics.de>
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/pwm/pwm.h>
> > +
> > +/ {
> > + aliases {
> > + can0 = &can2;
> > + can1 = &can1;
> > + ethernet0 = &fec;
> > + lcdif_23bit_pins_a = &pinctrl_disp0_1;
> > + lcdif_24bit_pins_a = &pinctrl_disp0_2;
> > + pwm0 = &pwm1;
> > + pwm1 = &pwm2;
> > + reg_can_xcvr = ®_can_xcvr;
> > + stk5led = &user_led;
> > + usbotg = &usbotg;
> > + sdhc0 = &usdhc1;
> > + sdhc1 = &usdhc2;
> > + };
> > +
> > + memory {
> > + reg = <0 0>; /* will be filled by U-Boot */
> > + };
> > +
> > + clocks {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + mclk: codec_clock {
>
> clock@0
>
OK.
> > +&can1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_flexcan1>;
> > + xceiver-supply = <®_can_xcvr>;
> > +
>
> Drop the new line.
>
OK.
[...]
> > +&i2c3 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_i2c3>;
> > + clock-frequency = <400000>;
> > + status = "okay";
> > +
> > + sgtl5000: sgtl5000@0a {
> > + compatible = "fsl,sgtl5000";
> > + reg = <0x0a>;
> > + VDDA-supply = <®_2v5>;
> > + VDDIO-supply = <®_3v3>;
> > + clocks = <&mclk>;
> > + };
> > +
> > + polytouch: edt-ft5x06@38 {
> > + compatible = "edt,edt-ft5x06";
> > + reg = <0x38>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_edt_ft5x06>;
> > + interrupt-parent = <&gpio6>;
> > + interrupts = <15 0>;
> > + reset-gpios = <&gpio2 22 GPIO_ACTIVE_LOW>;
> > + wake-gpios = <&gpio2 21 GPIO_ACTIVE_HIGH>;
>
> Where are all these bindings documented?
>
That's one in a separate patch adding DT support to the edt_ft5x06
driver.
> > + linux,wakeup;
> > + };
> > +
> > + touchscreen: tsc2007@48 {
> > + compatible = "ti,tsc2007";
> > + reg = <0x48>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_tsc2007>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <26 0>;
> > + gpios = <&gpio3 26 GPIO_ACTIVE_LOW>;
> > + ti,x-plate-ohms = <660>;
> > + linux,wakeup;
> > + };
> > +};
> > +
> > +&iomuxc {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_hog>;
> > +
> > + imx6qdl-tx6 {
> > + pinctrl_hog: hoggrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_EIM_A18__GPIO2_IO20 0x1b0b1 /* LED */
> > + MX6QDL_PAD_SD3_DAT2__GPIO7_IO06 0x1b0b1 /* ETN PHY RESET */
> > + MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x1b0b1 /* ETN PHY INT
>
> Broken comment?
>
Yeah, right. Bad, that the compiler doesn't complain here. :(
[...]
> > + pinctrl_flexcan_xcvr: flexcan-xcvrgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_DISP0_DAT0__GPIO4_IO21 0x1b0b0 /* Flexcan XCVR enable */
> > + >;
> > + };
> > +
> > + pinctrl_gpmi_nand: gpmi-nand {
>
> gpminandgrp
>
OK.
> > + pinctrl_kpp: kppgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_GPIO_9__KEY_COL6 0x1b0b1
> > + MX6QDL_PAD_GPIO_4__KEY_COL7 0x1b0b1
> > + MX6QDL_PAD_KEY_COL2__KEY_COL2 0x1b0b1
> > + MX6QDL_PAD_KEY_COL3__KEY_COL3 0x1b0b1
> > +
>
> Drop it.
>
I guess you mean the empty line.
OK.
[...]
> > +&uart2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_uart2 &pinctrl_uart2_rtscts>;
>
> These two entries can be merged into one.
>
I prefer to have the handshake pinctrls separate from the data lines so
that the uart can be used with or without RTS/CTS, without having to
mess around with the pinctrl defs.
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________
WARNING: multiple messages have this Message-ID (diff)
From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6: add support for Ka-Ro TX6 modules
Date: Mon, 24 Mar 2014 13:01:29 +0100 [thread overview]
Message-ID: <20140324130129.1c2ec444@ipc1.ka-ro> (raw)
In-Reply-To: <20140322082352.GF5938@dragon>
Hi Shawn,
it would help readability a lot if you would trim down the quoted parts
of the original mail (like I did with [...] in this reply).
Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:29:44PM +0100, Lothar Wa?mann wrote:
> > This patch adds support for the Ka-Ro electronics GmbH TX6 modules.
> > There are five distinct module types with either i.MX6Q or i.MX6DL and
> > LVDS or LCD display interface and one DTS file for a complete system
> > with an i.MX6DL based TX6 module and a baseboard mounted on the back
> > of a display (imx6dl-tx6dl-comtft.dts).
> >
> > Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> > ---
> > arch/arm/boot/dts/Makefile | 6 +
> > arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts | 114 +++++
> > arch/arm/boot/dts/imx6dl-tx6u-801x.dts | 188 ++++++++
> > arch/arm/boot/dts/imx6dl-tx6u-811x.dts | 166 +++++++
> > arch/arm/boot/dts/imx6q-tx6q-1010.dts | 192 +++++++++
> > arch/arm/boot/dts/imx6q-tx6q-1020.dts | 192 +++++++++
> > arch/arm/boot/dts/imx6q-tx6q-1110.dts | 174 ++++++++
> > arch/arm/boot/dts/imx6qdl-tx6.dtsi | 672 +++++++++++++++++++++++++++++
> > 8 files changed, 1704 insertions(+)
> > create mode 100644 arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts
> > create mode 100644 arch/arm/boot/dts/imx6dl-tx6u-801x.dts
> > create mode 100644 arch/arm/boot/dts/imx6dl-tx6u-811x.dts
> > create mode 100644 arch/arm/boot/dts/imx6q-tx6q-1010.dts
> > create mode 100644 arch/arm/boot/dts/imx6q-tx6q-1020.dts
> > create mode 100644 arch/arm/boot/dts/imx6q-tx6q-1110.dts
> > create mode 100644 arch/arm/boot/dts/imx6qdl-tx6.dtsi
> >
[...]
> > diff --git a/arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts b/arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts
> > new file mode 100644
> > index 0000000..6df5a25
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts
> > @@ -0,0 +1,114 @@
> > +/*
> > + * Copyright 2014 Lothar Wa?mann <LW@KARO-electronics.de>
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx6dl.dtsi"
> > +#include "imx6qdl-tx6.dtsi"
> > +
> > +/ {
> > + model = "Ka-Ro electronics TX6DL Module on CoMpact TFT";
> > + compatible = "fsl,imx6dl-tx6dl", "fsl,imx6dl";
>
> Shouldn't it be "karo,imx6dl-tx6dl" instead?
>
Of course. :(
> > +
> > + aliases {
> > + display = &display;
> > + };
> > +
> > + backlight: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm2 0 500000 0>;
> > + power-supply = <®_3v3>;
> > + /*
> > + * a poor man's way to create a 1:1 relationship between
> > + * the PWM value and the actual duty cycle
> > + */
> > + brightness-levels = < 0 1 2 3 4 5 6 7 8 9
> > + 10 11 12 13 14 15 16 17 18 19
> > + 20 21 22 23 24 25 26 27 28 29
> > + 30 31 32 33 34 35 36 37 38 39
> > + 40 41 42 43 44 45 46 47 48 49
> > + 50 51 52 53 54 55 56 57 58 59
> > + 60 61 62 63 64 65 66 67 68 69
> > + 70 71 72 73 74 75 76 77 78 79
> > + 80 81 82 83 84 85 86 87 88 89
> > + 90 91 92 93 94 95 96 97 98 99
> > + 100>;
> > + default-brightness-level = <50>;
> > + };
> > +
> > + display: display at di0 {
> > + compatible = "fsl,imx-parallel-display";
> > + interface-pix-fmt = "rgb24";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_disp0_1>;
> > + status = "okay";
> > +
> > + port {
> > + display0_in: endpoint {
> > + remote-endpoint = <&ipu1_di0_disp0>;
> > + };
> > + };
>
> I do not have OF graph stuff in my tree yet.
>
You can apply the patch, once it arrives in your tree.
[...]
> > diff --git a/arch/arm/boot/dts/imx6dl-tx6u-811x.dts b/arch/arm/boot/dts/imx6dl-tx6u-811x.dts
> > new file mode 100644
> > index 0000000..c97fb42
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6dl-tx6u-811x.dts
> > @@ -0,0 +1,166 @@
> > +/*
> > + * Copyright 2014 Lothar Wa?mann <LW@KARO-electronics.de>
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx6dl.dtsi"
> > +#include "imx6qdl-tx6.dtsi"
> > +
> > +/ {
> > + model = "Ka-Ro electronics TX6U-811x Module";
> > + compatible = "fsl,imx6dl-tx6dl", "fsl,imx6dl";
> > +
> > + aliases {
> > + display = &lvds0;
> > + lvds0 = &lvds0;
> > + lvds1 = &lvds1;
> > + };
> > +
> > + backlight0: backlight0 {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm2 0 500000 0>;
> > + power-supply = <®_lcd0_pwr>;
> > + /*
> > + * a poor man's way to create a 1:1 relationship between
> > + * the PWM value and the actual duty cycle
> > + */
> > + brightness-levels = < 0 1 2 3 4 5 6 7 8 9
> > + 10 11 12 13 14 15 16 17 18 19
> > + 20 21 22 23 24 25 26 27 28 29
> > + 30 31 32 33 34 35 36 37 38 39
> > + 40 41 42 43 44 45 46 47 48 49
> > + 50 51 52 53 54 55 56 57 58 59
> > + 60 61 62 63 64 65 66 67 68 69
> > + 70 71 72 73 74 75 76 77 78 79
> > + 80 81 82 83 84 85 86 87 88 89
> > + 90 91 92 93 94 95 96 97 98 99
> > + 100>;
> > + default-brightness-level = <50>;
> > + };
> > +
> > + backlight1: backlight1 {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm1 0 500000 0>;
> > + power-supply = <®_lcd1_pwr>;
> > + /*
> > + * a poor man's way to create a 1:1 relationship between
> > + * the PWM value and the actual duty cycle
> > + */
> > + brightness-levels = < 0 1 2 3 4 5 6 7 8 9
> > + 10 11 12 13 14 15 16 17 18 19
> > + 20 21 22 23 24 25 26 27 28 29
> > + 30 31 32 33 34 35 36 37 38 39
> > + 40 41 42 43 44 45 46 47 48 49
> > + 50 51 52 53 54 55 56 57 58 59
> > + 60 61 62 63 64 65 66 67 68 69
> > + 70 71 72 73 74 75 76 77 78 79
> > + 80 81 82 83 84 85 86 87 88 89
> > + 90 91 92 93 94 95 96 97 98 99
> > + 100>;
> > + default-brightness-level = <50>;
> > + };
> > +
> > + panel0 {
>
> The convention of device tree node is node-name at unit-address, so in this
> case it should probably be panel at 0.
>
AFAIK that's only true for nodes that require a 'reg' property.
Thus if it were:
panels {
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <0>;
panel at 0 {
compatible = "simple-panel";
reg = <0>;
power-supply = <®_3v3>;
backlight = <&backlight0>;
};
[...]
> > diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> > new file mode 100644
> > index 0000000..828e7f3
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> > @@ -0,0 +1,672 @@
> > +/*
> > + * Copyright 2014 Lothar Wa?mann <LW@KARO-electronics.de>
> > + *
> > + * The code contained herein is licensed under the GNU General Public
> > + * License. You may obtain a copy of the GNU General Public License
> > + * Version 2 at the following locations:
> > + *
> > + * http://www.opensource.org/licenses/gpl-license.html
> > + * http://www.gnu.org/copyleft/gpl.html
> > + */
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/pwm/pwm.h>
> > +
> > +/ {
> > + aliases {
> > + can0 = &can2;
> > + can1 = &can1;
> > + ethernet0 = &fec;
> > + lcdif_23bit_pins_a = &pinctrl_disp0_1;
> > + lcdif_24bit_pins_a = &pinctrl_disp0_2;
> > + pwm0 = &pwm1;
> > + pwm1 = &pwm2;
> > + reg_can_xcvr = ®_can_xcvr;
> > + stk5led = &user_led;
> > + usbotg = &usbotg;
> > + sdhc0 = &usdhc1;
> > + sdhc1 = &usdhc2;
> > + };
> > +
> > + memory {
> > + reg = <0 0>; /* will be filled by U-Boot */
> > + };
> > +
> > + clocks {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + mclk: codec_clock {
>
> clock at 0
>
OK.
> > +&can1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_flexcan1>;
> > + xceiver-supply = <®_can_xcvr>;
> > +
>
> Drop the new line.
>
OK.
[...]
> > +&i2c3 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_i2c3>;
> > + clock-frequency = <400000>;
> > + status = "okay";
> > +
> > + sgtl5000: sgtl5000 at 0a {
> > + compatible = "fsl,sgtl5000";
> > + reg = <0x0a>;
> > + VDDA-supply = <®_2v5>;
> > + VDDIO-supply = <®_3v3>;
> > + clocks = <&mclk>;
> > + };
> > +
> > + polytouch: edt-ft5x06 at 38 {
> > + compatible = "edt,edt-ft5x06";
> > + reg = <0x38>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_edt_ft5x06>;
> > + interrupt-parent = <&gpio6>;
> > + interrupts = <15 0>;
> > + reset-gpios = <&gpio2 22 GPIO_ACTIVE_LOW>;
> > + wake-gpios = <&gpio2 21 GPIO_ACTIVE_HIGH>;
>
> Where are all these bindings documented?
>
That's one in a separate patch adding DT support to the edt_ft5x06
driver.
> > + linux,wakeup;
> > + };
> > +
> > + touchscreen: tsc2007 at 48 {
> > + compatible = "ti,tsc2007";
> > + reg = <0x48>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_tsc2007>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <26 0>;
> > + gpios = <&gpio3 26 GPIO_ACTIVE_LOW>;
> > + ti,x-plate-ohms = <660>;
> > + linux,wakeup;
> > + };
> > +};
> > +
> > +&iomuxc {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_hog>;
> > +
> > + imx6qdl-tx6 {
> > + pinctrl_hog: hoggrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_EIM_A18__GPIO2_IO20 0x1b0b1 /* LED */
> > + MX6QDL_PAD_SD3_DAT2__GPIO7_IO06 0x1b0b1 /* ETN PHY RESET */
> > + MX6QDL_PAD_SD3_DAT4__GPIO7_IO01 0x1b0b1 /* ETN PHY INT
>
> Broken comment?
>
Yeah, right. Bad, that the compiler doesn't complain here. :(
[...]
> > + pinctrl_flexcan_xcvr: flexcan-xcvrgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_DISP0_DAT0__GPIO4_IO21 0x1b0b0 /* Flexcan XCVR enable */
> > + >;
> > + };
> > +
> > + pinctrl_gpmi_nand: gpmi-nand {
>
> gpminandgrp
>
OK.
> > + pinctrl_kpp: kppgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_GPIO_9__KEY_COL6 0x1b0b1
> > + MX6QDL_PAD_GPIO_4__KEY_COL7 0x1b0b1
> > + MX6QDL_PAD_KEY_COL2__KEY_COL2 0x1b0b1
> > + MX6QDL_PAD_KEY_COL3__KEY_COL3 0x1b0b1
> > +
>
> Drop it.
>
I guess you mean the empty line.
OK.
[...]
> > +&uart2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_uart2 &pinctrl_uart2_rtscts>;
>
> These two entries can be merged into one.
>
I prefer to have the handshake pinctrls separate from the data lines so
that the uart can be used with or without RTS/CTS, without having to
mess around with the pinctrl defs.
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2014-03-24 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 13:29 [PATCH] ARM: dts: imx6: add support for Ka-Ro TX6 modules Lothar Waßmann
2014-03-19 13:29 ` Lothar Waßmann
2014-03-22 8:23 ` Shawn Guo
2014-03-22 8:23 ` Shawn Guo
2014-03-22 8:23 ` Shawn Guo
2014-03-24 12:01 ` Lothar Waßmann [this message]
2014-03-24 12:01 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324130129.1c2ec444@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.