From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <dave.kleikamp@oracle.com>,
Zach Brown <zab@zabbo.net>, Benjamin LaHaise <bcrl@kvack.org>,
Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kmo@daterainc.com>,
"open list:AIO" <linux-aio@kvack.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v1 0/9] block & aio: kernel aio and loop mq conversion
Date: Fri, 15 Aug 2014 06:11:37 -0700 [thread overview]
Message-ID: <20140815131137.GA31079@infradead.org> (raw)
In-Reply-To: <CACVXFVNGaZ0C1cA5fq0UnEBDPPMpBDqF2PxNk4TAOOCGL3jh5g@mail.gmail.com>
On Fri, Aug 15, 2014 at 08:59:56PM +0800, Ming Lei wrote:
> Your concern is right, previous I thought that mq conversion wouldn't improve
> throughput, but I did ignore workqueue's concurrency management, it
> turns out blk-mq conversion can improvment throughput close to 10 times in
> my test(loop over virtio-blk which is backed by one image on SSD). It is like
> POSIX style AIO after mq conversion thanks to workqueue, and I need to
> update the performance data in V2.
>
> Actually kernel AIO needn't such high concurrency.
Can you juse send a loop blk-mq conversion for now? I think that's
a bit less controversial than the new kernel aio APIs, and keeping the
two separate is a good idea in general.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <dave.kleikamp@oracle.com>,
Zach Brown <zab@zabbo.net>, Benjamin LaHaise <bcrl@kvack.org>,
Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kmo@daterainc.com>,
"open list:AIO" <linux-aio@kvack.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v1 0/9] block & aio: kernel aio and loop mq conversion
Date: Fri, 15 Aug 2014 06:11:37 -0700 [thread overview]
Message-ID: <20140815131137.GA31079@infradead.org> (raw)
In-Reply-To: <CACVXFVNGaZ0C1cA5fq0UnEBDPPMpBDqF2PxNk4TAOOCGL3jh5g@mail.gmail.com>
On Fri, Aug 15, 2014 at 08:59:56PM +0800, Ming Lei wrote:
> Your concern is right, previous I thought that mq conversion wouldn't improve
> throughput, but I did ignore workqueue's concurrency management, it
> turns out blk-mq conversion can improvment throughput close to 10 times in
> my test(loop over virtio-blk which is backed by one image on SSD). It is like
> POSIX style AIO after mq conversion thanks to workqueue, and I need to
> update the performance data in V2.
>
> Actually kernel AIO needn't such high concurrency.
Can you juse send a loop blk-mq conversion for now? I think that's
a bit less controversial than the new kernel aio APIs, and keeping the
two separate is a good idea in general.
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2014-08-15 13:11 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 15:50 [PATCH v1 0/9] block & aio: kernel aio and loop mq conversion Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-14 15:50 ` [PATCH v1 1/9] aio: add aio_kernel_() interface Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-14 18:07 ` Zach Brown
2014-08-14 18:07 ` Zach Brown
2014-08-15 13:20 ` Ming Lei
2014-08-15 13:20 ` Ming Lei
2014-08-14 15:50 ` [PATCH v1 2/9] fd/direct-io: introduce should_dirty for kernel aio Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-14 15:50 ` [PATCH v1 3/9] blk-mq: export blk_mq_freeze_queue and blk_mq_unfreeze_queue Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-14 15:50 ` [PATCH v1 4/9] blk-mq: introduce init_flush_rq_fn callback in 'blk_mq_ops' Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-15 16:19 ` Jens Axboe
2014-08-15 16:19 ` Jens Axboe
2014-08-16 7:49 ` Ming Lei
2014-08-16 7:49 ` Ming Lei
2014-08-17 18:39 ` Jens Axboe
2014-08-17 18:39 ` Jens Axboe
2014-08-14 15:50 ` [PATCH v1 5/9] block: loop: convert to blk-mq Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-15 16:31 ` Christoph Hellwig
2014-08-15 16:31 ` Christoph Hellwig
2014-08-15 16:36 ` Jens Axboe
2014-08-15 16:46 ` Jens Axboe
2014-08-16 8:06 ` Ming Lei
2014-08-16 8:06 ` Ming Lei
2014-08-17 17:48 ` Jens Axboe
2014-08-17 17:48 ` Jens Axboe
2014-08-18 1:22 ` Ming Lei
2014-08-18 1:22 ` Ming Lei
2014-08-18 11:53 ` Ming Lei
2014-08-18 11:53 ` Ming Lei
2014-08-19 20:50 ` Jens Axboe
2014-08-20 1:23 ` Ming Lei
2014-08-20 16:09 ` Jens Axboe
2014-08-21 2:54 ` Ming Lei
2014-08-21 2:58 ` Jens Axboe
2014-08-21 3:13 ` Ming Lei
2014-08-21 3:15 ` Ming Lei
2014-08-21 3:16 ` Jens Axboe
2014-08-21 3:34 ` Ming Lei
2014-08-21 5:44 ` Ming Lei
2014-08-27 16:08 ` Maxim Patlasov
2014-08-27 16:08 ` Maxim Patlasov
2014-08-27 16:29 ` Benjamin LaHaise
2014-08-27 16:29 ` Benjamin LaHaise
2014-08-27 17:19 ` Maxim Patlasov
2014-08-27 17:19 ` Maxim Patlasov
2014-08-27 17:56 ` Zach Brown
2014-08-27 17:56 ` Zach Brown
2014-08-28 2:10 ` Ming Lei
2014-08-28 2:10 ` Ming Lei
2014-08-28 2:06 ` Ming Lei
2014-08-28 2:06 ` Ming Lei
2014-08-29 11:14 ` Maxim Patlasov
2014-08-29 11:14 ` Maxim Patlasov
2014-08-14 15:50 ` [PATCH v1 6/9] block: loop: say goodby to bio Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-14 15:50 ` [PATCH v1 7/9] block: loop: introduce lo_discard() and lo_req_flush() Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-14 15:50 ` [PATCH v1 8/9] block: loop: don't handle REQ_FUA explicitly Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-14 15:50 ` [PATCH v1 9/9] block: loop: support to submit I/O via kernel aio based Ming Lei
2014-08-14 15:50 ` Ming Lei
2014-08-14 16:53 ` [PATCH v1 0/9] block & aio: kernel aio and loop mq conversion Jens Axboe
2014-08-14 16:53 ` Jens Axboe
2014-08-15 12:59 ` Ming Lei
2014-08-15 12:59 ` Ming Lei
2014-08-15 13:11 ` Christoph Hellwig [this message]
2014-08-15 13:11 ` Christoph Hellwig
2014-08-15 14:32 ` Ming Lei
2014-08-15 14:32 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815131137.GA31079@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=dave.kleikamp@oracle.com \
--cc=david@fromorbit.com \
--cc=kmo@daterainc.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.