From: Simon Horman <horms@verge.net.au> To: Olof Johansson <olof@lixom.net> Cc: Rob Herring <robh@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Marc Zyngier <marc.zyngier@arm.com>, Naveen Krishna Chatradhi <ch.naveen@samsung.com>, Catalin Marinas <Catalin.Marinas@arm.com>, "naveenkrishna.ch@gmail.com" <naveenkrishna.ch@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "cpgs@samsung.com" <cpgs@samsung.com>, Thomas Abraham <thomas.ab@samsung.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org> Subject: Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7 Date: Fri, 29 Aug 2014 08:30:06 +0900 [thread overview] Message-ID: <20140828233006.GC16165@verge.net.au> (raw) In-Reply-To: <CAOesGMhsayvhBK_gVgzB3+69YC1Ca6hsBHsONJm_QEcSKpVZOw@mail.gmail.com> On Thu, Aug 28, 2014 at 03:23:49PM -0700, Olof Johansson wrote: > On Thu, Aug 28, 2014 at 10:54 AM, Rob Herring <robh@kernel.org> wrote: > > On Thu, Aug 28, 2014 at 12:19 PM, Olof Johansson <olof@lixom.net> wrote: > >> On Thu, Aug 28, 2014 at 10:03 AM, Mark Rutland <mark.rutland@arm.com> wrote: > >>> On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: > >>>> On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland <mark.rutland@arm.com> wrote: > >>>> > Hi, > >>>> > > >>>> >> > + cpus { > >>>> >> > + #address-cells = <2>; > >>>> >> > + #size-cells = <0>; > >>>> >> > >>>> >> Why size-cells=2? Can you not fit a cpuid in 32 bits? > >>>> > > >>>> > As of commit 72aea393a2e7 (arm64: smp: honour #address-size when parsing > >>>> > CPU reg property) Linux can handle single-cell cpu node reg entries > >>>> > where /cpus/#address-cells = <1>. > >>>> > > >>>> > I can't make any guarantees about other code (e.g. bootloaders) which > >>>> > might try to do things with cpu nodes, YMMV. > >>>> > >>>> Ok. If address-cells is kept at 2 the unit address needs to be changed > >>>> to "0,0". So one or the other has to be changed. > >>> > >>> I'm happy either way. > >>> > >>> I'm not sure the rest of the tree had "0," prefixes on all of the > >>> unit-addresses for 64-bit addresses that were under 4GB, and I'm not > >>> sure that existing dts consistently do that either. > >>> > >>> Do we want to enforce that for all 64-bit unit-addresses? > >> > >> Yeah, I believe that's the only valid format for a 2-address-cell unit address. > > > > But we don't do leading 0's anywhere else like single cell unit > > addresses. Buses expressed with ranges and offsets are one example. > > Also, I2C addresses have a 32-bit size in DT yet are only 8-bit and we > > don't do leading zero's there. > > Ok, I'm happily proven wrong here, also by confirming how this is done > on "real" OF. > > According to benh: > > 15:20 <benh> ojn: 0,0 is not quite right, it's supposed to be used > when the two numbers are different things, like device,fn on PCI > > The same is true for >2^32 unit addresses, they just use the one > integer instead of x,y. > > So, I take back all I've said on this in the last 72 hours. :) It > looks like we might need to revisit some of the 32-bit DTs. Simon, > drop the series you had. :) Thanks will do. Is the way forward for me to apply my original patch to change memory@180000000 to memory@140000000? And abandon all the ',' only changes?This one: This is the original patch: From: Simon Horman <horms+renesas@verge.net.au> [PATCH] ARM: shmobile: lager: correct memory map The base address of the second memory region on the lager board is 0x140000000. Update the tag used in the dts file accordingly. This is a documentation fix and should have no run-time affect. This problem was introduced when the second memory region was added to the lager dts file by 62bc32a2573c4219 ("ARM: shmobile: Include all 4 GiB of memory on Lager)" in v3.14. Reported-by: NAOYA SHIIBA <naoya.shiiba.nx@renesas.com> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index 0118cbf..84dcafa 100644 --- a/arch/arm/boot/dts/r8a7790-lager.dts +++ b/arch/arm/boot/dts/r8a7790-lager.dts @@ -32,7 +32,7 @@ reg = <0 0x40000000 0 0x40000000>; }; - memory@180000000 { + memory@140000000 { device_type = "memory"; reg = <1 0x40000000 0 0xc0000000>; }; -- 2.0.1
WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7 Date: Fri, 29 Aug 2014 08:30:06 +0900 [thread overview] Message-ID: <20140828233006.GC16165@verge.net.au> (raw) In-Reply-To: <CAOesGMhsayvhBK_gVgzB3+69YC1Ca6hsBHsONJm_QEcSKpVZOw@mail.gmail.com> On Thu, Aug 28, 2014 at 03:23:49PM -0700, Olof Johansson wrote: > On Thu, Aug 28, 2014 at 10:54 AM, Rob Herring <robh@kernel.org> wrote: > > On Thu, Aug 28, 2014 at 12:19 PM, Olof Johansson <olof@lixom.net> wrote: > >> On Thu, Aug 28, 2014 at 10:03 AM, Mark Rutland <mark.rutland@arm.com> wrote: > >>> On Thu, Aug 28, 2014 at 05:28:22PM +0100, Olof Johansson wrote: > >>>> On Thu, Aug 28, 2014 at 2:48 AM, Mark Rutland <mark.rutland@arm.com> wrote: > >>>> > Hi, > >>>> > > >>>> >> > + cpus { > >>>> >> > + #address-cells = <2>; > >>>> >> > + #size-cells = <0>; > >>>> >> > >>>> >> Why size-cells=2? Can you not fit a cpuid in 32 bits? > >>>> > > >>>> > As of commit 72aea393a2e7 (arm64: smp: honour #address-size when parsing > >>>> > CPU reg property) Linux can handle single-cell cpu node reg entries > >>>> > where /cpus/#address-cells = <1>. > >>>> > > >>>> > I can't make any guarantees about other code (e.g. bootloaders) which > >>>> > might try to do things with cpu nodes, YMMV. > >>>> > >>>> Ok. If address-cells is kept at 2 the unit address needs to be changed > >>>> to "0,0". So one or the other has to be changed. > >>> > >>> I'm happy either way. > >>> > >>> I'm not sure the rest of the tree had "0," prefixes on all of the > >>> unit-addresses for 64-bit addresses that were under 4GB, and I'm not > >>> sure that existing dts consistently do that either. > >>> > >>> Do we want to enforce that for all 64-bit unit-addresses? > >> > >> Yeah, I believe that's the only valid format for a 2-address-cell unit address. > > > > But we don't do leading 0's anywhere else like single cell unit > > addresses. Buses expressed with ranges and offsets are one example. > > Also, I2C addresses have a 32-bit size in DT yet are only 8-bit and we > > don't do leading zero's there. > > Ok, I'm happily proven wrong here, also by confirming how this is done > on "real" OF. > > According to benh: > > 15:20 <benh> ojn: 0,0 is not quite right, it's supposed to be used > when the two numbers are different things, like device,fn on PCI > > The same is true for >2^32 unit addresses, they just use the one > integer instead of x,y. > > So, I take back all I've said on this in the last 72 hours. :) It > looks like we might need to revisit some of the 32-bit DTs. Simon, > drop the series you had. :) Thanks will do. Is the way forward for me to apply my original patch to change memory at 180000000 to memory at 140000000? And abandon all the ',' only changes?This one: This is the original patch: From: Simon Horman <horms+renesas@verge.net.au> [PATCH] ARM: shmobile: lager: correct memory map The base address of the second memory region on the lager board is 0x140000000. Update the tag used in the dts file accordingly. This is a documentation fix and should have no run-time affect. This problem was introduced when the second memory region was added to the lager dts file by 62bc32a2573c4219 ("ARM: shmobile: Include all 4 GiB of memory on Lager)" in v3.14. Reported-by: NAOYA SHIIBA <naoya.shiiba.nx@renesas.com> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- arch/arm/boot/dts/r8a7790-lager.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index 0118cbf..84dcafa 100644 --- a/arch/arm/boot/dts/r8a7790-lager.dts +++ b/arch/arm/boot/dts/r8a7790-lager.dts @@ -32,7 +32,7 @@ reg = <0 0x40000000 0 0x40000000>; }; - memory at 180000000 { + memory at 140000000 { device_type = "memory"; reg = <1 0x40000000 0 0xc0000000>; }; -- 2.0.1
next prev parent reply other threads:[~2014-08-28 23:30 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-27 9:44 [PATCH 00/14] Support 64bit Cortex A57 based Exynos7 SoC Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 9:44 ` [PATCH 10/14] arm64: dts: add pinctrl support to EXYNOS7 Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 11:14 ` Tomasz Figa 2014-08-27 11:14 ` Tomasz Figa 2014-08-29 5:46 ` Naveen Krishna Ch 2014-08-29 5:46 ` Naveen Krishna Ch 2014-08-27 9:44 ` [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7 Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 10:42 ` Mark Rutland 2014-08-27 10:42 ` Mark Rutland 2014-08-27 14:54 ` Catalin Marinas 2014-08-27 14:54 ` Catalin Marinas 2014-09-03 7:48 ` Naveen Krishna Ch 2014-09-03 7:48 ` Naveen Krishna Ch 2014-08-27 11:30 ` Tomasz Figa 2014-08-27 11:30 ` Tomasz Figa 2014-09-03 7:55 ` Naveen Krishna Ch 2014-09-03 7:55 ` Naveen Krishna Ch 2014-08-28 3:56 ` Olof Johansson 2014-08-28 3:56 ` Olof Johansson 2014-08-28 8:35 ` Marc Zyngier 2014-08-28 8:35 ` Marc Zyngier 2014-08-28 9:48 ` Mark Rutland 2014-08-28 9:48 ` Mark Rutland 2014-08-28 16:28 ` Olof Johansson 2014-08-28 16:28 ` Olof Johansson 2014-08-28 17:03 ` Mark Rutland 2014-08-28 17:03 ` Mark Rutland 2014-08-28 17:19 ` Olof Johansson 2014-08-28 17:19 ` Olof Johansson 2014-08-28 17:39 ` Mark Rutland 2014-08-28 17:39 ` Mark Rutland 2014-08-28 17:47 ` Geert Uytterhoeven 2014-08-28 17:47 ` Geert Uytterhoeven 2014-08-28 18:17 ` Mark Rutland 2014-08-28 18:17 ` Mark Rutland 2014-08-28 17:54 ` Rob Herring 2014-08-28 17:54 ` Rob Herring 2014-08-28 22:23 ` Olof Johansson 2014-08-28 22:23 ` Olof Johansson 2014-08-28 23:30 ` Simon Horman [this message] 2014-08-28 23:30 ` Simon Horman 2014-08-28 17:27 ` Marc Zyngier 2014-08-28 17:27 ` Marc Zyngier 2014-08-28 17:30 ` Mark Rutland 2014-08-28 17:30 ` Mark Rutland 2014-08-28 17:37 ` Marc Zyngier 2014-08-28 17:37 ` Marc Zyngier 2014-08-28 17:45 ` Mark Rutland 2014-08-28 17:45 ` Mark Rutland [not found] ` <53FF6668.4080502-5wv7dgnIgG8@public.gmane.org> 2014-08-28 17:33 ` Rob Herring 2014-08-28 17:33 ` Rob Herring 2014-08-28 17:43 ` Mark Rutland 2014-08-28 17:43 ` Mark Rutland 2014-09-03 8:05 ` Naveen Krishna Ch 2014-09-03 8:05 ` Naveen Krishna Ch 2014-08-27 9:44 ` [PATCH 12/14] arm64: dts: add Exynos7 based Espresso board dts file Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 11:32 ` Tomasz Figa 2014-08-27 11:32 ` Tomasz Figa 2014-08-28 4:00 ` Olof Johansson 2014-08-28 4:00 ` Olof Johansson 2014-08-29 5:51 ` Naveen Krishna Ch 2014-08-29 5:51 ` Naveen Krishna Ch 2014-08-27 9:44 ` [PATCH 13/14] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 11:09 ` Mark Rutland 2014-08-27 11:09 ` Mark Rutland 2014-08-27 14:50 ` Catalin Marinas 2014-08-27 14:50 ` Catalin Marinas 2014-08-28 4:05 ` Olof Johansson 2014-08-28 4:05 ` Olof Johansson 2014-09-03 8:14 ` Naveen Krishna Ch 2014-09-03 8:14 ` Naveen Krishna Ch 2014-08-27 11:34 ` [PATCH 00/14] Support 64bit Cortex A57 based Exynos7 SoC Tomasz Figa 2014-08-27 11:34 ` Tomasz Figa 2014-09-13 10:57 ` Tomasz Figa 2014-09-13 10:57 ` Tomasz Figa 2014-09-14 13:45 ` Thomas Abraham 2014-09-14 13:45 ` Thomas Abraham 2014-08-28 3:47 ` Olof Johansson 2014-08-28 3:47 ` Olof Johansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140828233006.GC16165@verge.net.au \ --to=horms@verge.net.au \ --cc=Catalin.Marinas@arm.com \ --cc=benh@kernel.crashing.org \ --cc=ch.naveen@samsung.com \ --cc=cpgs@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=naveenkrishna.ch@gmail.com \ --cc=olof@lixom.net \ --cc=robh@kernel.org \ --cc=thomas.ab@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.