From: Naveen Krishna Ch <naveenkrishna.ch@gmail.com> To: Mark Rutland <mark.rutland@arm.com> Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>, Catalin Marinas <Catalin.Marinas@arm.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "cpgs@samsung.com" <cpgs@samsung.com>, Thomas Abraham <thomas.ab@samsung.com>, Rob Herring <robh@kernel.org> Subject: Re: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7 Date: Wed, 3 Sep 2014 13:18:41 +0530 [thread overview] Message-ID: <CAHfPSqD2_=-zr8p0STSThfdik296tHZkHhXemdxCrSqTx7e1UQ@mail.gmail.com> (raw) In-Reply-To: <20140827104231.GB7773@leverpostej> Hi Mark, On 27 August 2014 16:12, Mark Rutland <mark.rutland@arm.com> wrote: > Hi Naveen, > > On Wed, Aug 27, 2014 at 10:44:18AM +0100, Naveen Krishna Chatradhi wrote: >> Add initial device tree nodes for EXYNOS7 SoC. >> Also, includes the dt-binding definitions for clock ids. > > Fallout from a rebase? That latter part doesn't seem to be relevant. Yes, this is fixed now. > >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Cc: Thomas Abraham <thomas.ab@samsung.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> --- >> arch/arm64/boot/dts/exynos7.dtsi | 553 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 553 insertions(+) >> create mode 100644 arch/arm64/boot/dts/exynos7.dtsi >> >> diff --git a/arch/arm64/boot/dts/exynos7.dtsi b/arch/arm64/boot/dts/exynos7.dtsi >> new file mode 100644 >> index 0000000..6b9eaf4 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos7.dtsi >> @@ -0,0 +1,553 @@ >> +/* >> + * SAMSUNG EXYNOS7 SoC device tree source >> + * >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * SAMSUNG EXYNOS7 SoC device nodes are listed in this file. >> + * EXYNOS7 based board files can include this file and provide >> + * values for board specfic bindings. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#include <dt-bindings/clock/exynos7-clk.h> >> + >> +/ { >> + compatible = "samsung,exynos7"; >> + interrupt-parent = <&gic>; >> + #address-cells = <1>; >> + #size-cells = <1>; > > Can we guarantee everything going to live within 0x0 - 0xffffffff for > all boards using the SoC? > > I suspect that we can't, so the addresses and sizes at the top level > should be two cells. At some point there is bound to be something above > 4GB that we'll need to map, so to save us from a painful dts refactoring > we should have the dts organised to support that from the outside. Ok, this is fixed with #address-cells = 2 and #size-cells = 2. > > [...] > >> + cpus { >> + #address-cells = <2>; >> + #size-cells = <0>; >> + >> + cpu@0 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a57", "arm,armv8"; >> + reg = <0x0 0x0>; >> + }; >> + }; > > Only UP? This is a quad core SoC and the rest of the CPU nodes have been added in the second version of this series. > > [...] > >> + gic: interrupt-controller@11001000 { >> + compatible = "arm,gic-400"; >> + #interrupt-cells = <3>; >> + #address-cells = <0>; >> + interrupt-controller; >> + reg = <0x11001000 0x1000>, >> + <0x11002000 0x1000>, >> + <0x11004000 0x2000>, >> + <0x11006000 0x2000>; >> + }; > > Nice to see GICV and GICH. > > [...] > >> + mct@101C0000 { >> + compatible = "samsung,exynos4210-mct"; >> + reg = <0x101C0000 0x800>; >> + interrupt-controller; >> + #interrupt-cells = <1>; >> + interrupt-parent = <&mct_map>; >> + interrupts = <0>, <1>, <2>, <3>, >> + <4>, <5>, <6>, <7>, >> + <8>, <9>, <10>, <11>; >> + clocks = <&fin_pll>, <&clock_peris PCLK_MCT>; >> + clock-names = "fin_pll", "mct"; >> + >> + mct_map: mct-map { >> + #interrupt-cells = <1>; >> + #address-cells = <0>; >> + #size-cells = <0>; >> + interrupt-map = <0 &gic 0 112 0>, >> + <1 &gic 0 113 0>, >> + <2 &gic 0 114 0>, >> + <3 &gic 0 115 0>, >> + <4 &gic 0 116 0>, >> + <5 &gic 0 117 0>, >> + <6 &gic 0 118 0>, >> + <7 &gic 0 119 0>, >> + <8 &gic 0 120 0>, >> + <9 &gic 0 121 0>, >> + <10 &gic 0 122 0>, >> + <11 &gic 0 123 0>; >> + }; >> + }; > > I don't see why need the map here. Why can't we describe the GIC > interrupts directly? Right, it was not required. Also, we will try and use only arch timer and not MCT. > > [...] > >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts = <1 13 0xff01>, >> + <1 14 0xff01>, >> + <1 11 0xff01>, >> + <1 10 0xff01>; >> + clock-frequency = <24000000>; > > Your firmware/bootloader should configure CNTFRQ, and this shouldn't be > necessary. The clock-frequency property is an incomplete workaround for > broken firmware that in an ideal world we could kill off. > >> + use-clocksource-only; >> + use-physical-timer; > > Neither of these properties were introduced by this series, and no > rationale was given. > > What are these properties for, and why do you believe they are > necessary? Sorry, that was a mistake. This has been fixed. > > Thanks, > Mark. Thanks. -- Shine bright, (: Nav :)
WARNING: multiple messages have this Message-ID (diff)
From: naveenkrishna.ch@gmail.com (Naveen Krishna Ch) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7 Date: Wed, 3 Sep 2014 13:18:41 +0530 [thread overview] Message-ID: <CAHfPSqD2_=-zr8p0STSThfdik296tHZkHhXemdxCrSqTx7e1UQ@mail.gmail.com> (raw) In-Reply-To: <20140827104231.GB7773@leverpostej> Hi Mark, On 27 August 2014 16:12, Mark Rutland <mark.rutland@arm.com> wrote: > Hi Naveen, > > On Wed, Aug 27, 2014 at 10:44:18AM +0100, Naveen Krishna Chatradhi wrote: >> Add initial device tree nodes for EXYNOS7 SoC. >> Also, includes the dt-binding definitions for clock ids. > > Fallout from a rebase? That latter part doesn't seem to be relevant. Yes, this is fixed now. > >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Cc: Thomas Abraham <thomas.ab@samsung.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> --- >> arch/arm64/boot/dts/exynos7.dtsi | 553 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 553 insertions(+) >> create mode 100644 arch/arm64/boot/dts/exynos7.dtsi >> >> diff --git a/arch/arm64/boot/dts/exynos7.dtsi b/arch/arm64/boot/dts/exynos7.dtsi >> new file mode 100644 >> index 0000000..6b9eaf4 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos7.dtsi >> @@ -0,0 +1,553 @@ >> +/* >> + * SAMSUNG EXYNOS7 SoC device tree source >> + * >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * SAMSUNG EXYNOS7 SoC device nodes are listed in this file. >> + * EXYNOS7 based board files can include this file and provide >> + * values for board specfic bindings. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#include <dt-bindings/clock/exynos7-clk.h> >> + >> +/ { >> + compatible = "samsung,exynos7"; >> + interrupt-parent = <&gic>; >> + #address-cells = <1>; >> + #size-cells = <1>; > > Can we guarantee everything going to live within 0x0 - 0xffffffff for > all boards using the SoC? > > I suspect that we can't, so the addresses and sizes at the top level > should be two cells. At some point there is bound to be something above > 4GB that we'll need to map, so to save us from a painful dts refactoring > we should have the dts organised to support that from the outside. Ok, this is fixed with #address-cells = 2 and #size-cells = 2. > > [...] > >> + cpus { >> + #address-cells = <2>; >> + #size-cells = <0>; >> + >> + cpu at 0 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a57", "arm,armv8"; >> + reg = <0x0 0x0>; >> + }; >> + }; > > Only UP? This is a quad core SoC and the rest of the CPU nodes have been added in the second version of this series. > > [...] > >> + gic: interrupt-controller at 11001000 { >> + compatible = "arm,gic-400"; >> + #interrupt-cells = <3>; >> + #address-cells = <0>; >> + interrupt-controller; >> + reg = <0x11001000 0x1000>, >> + <0x11002000 0x1000>, >> + <0x11004000 0x2000>, >> + <0x11006000 0x2000>; >> + }; > > Nice to see GICV and GICH. > > [...] > >> + mct at 101C0000 { >> + compatible = "samsung,exynos4210-mct"; >> + reg = <0x101C0000 0x800>; >> + interrupt-controller; >> + #interrupt-cells = <1>; >> + interrupt-parent = <&mct_map>; >> + interrupts = <0>, <1>, <2>, <3>, >> + <4>, <5>, <6>, <7>, >> + <8>, <9>, <10>, <11>; >> + clocks = <&fin_pll>, <&clock_peris PCLK_MCT>; >> + clock-names = "fin_pll", "mct"; >> + >> + mct_map: mct-map { >> + #interrupt-cells = <1>; >> + #address-cells = <0>; >> + #size-cells = <0>; >> + interrupt-map = <0 &gic 0 112 0>, >> + <1 &gic 0 113 0>, >> + <2 &gic 0 114 0>, >> + <3 &gic 0 115 0>, >> + <4 &gic 0 116 0>, >> + <5 &gic 0 117 0>, >> + <6 &gic 0 118 0>, >> + <7 &gic 0 119 0>, >> + <8 &gic 0 120 0>, >> + <9 &gic 0 121 0>, >> + <10 &gic 0 122 0>, >> + <11 &gic 0 123 0>; >> + }; >> + }; > > I don't see why need the map here. Why can't we describe the GIC > interrupts directly? Right, it was not required. Also, we will try and use only arch timer and not MCT. > > [...] > >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts = <1 13 0xff01>, >> + <1 14 0xff01>, >> + <1 11 0xff01>, >> + <1 10 0xff01>; >> + clock-frequency = <24000000>; > > Your firmware/bootloader should configure CNTFRQ, and this shouldn't be > necessary. The clock-frequency property is an incomplete workaround for > broken firmware that in an ideal world we could kill off. > >> + use-clocksource-only; >> + use-physical-timer; > > Neither of these properties were introduced by this series, and no > rationale was given. > > What are these properties for, and why do you believe they are > necessary? Sorry, that was a mistake. This has been fixed. > > Thanks, > Mark. Thanks. -- Shine bright, (: Nav :)
next prev parent reply other threads:[~2014-09-03 7:48 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-08-27 9:44 [PATCH 00/14] Support 64bit Cortex A57 based Exynos7 SoC Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 9:44 ` [PATCH 10/14] arm64: dts: add pinctrl support to EXYNOS7 Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 11:14 ` Tomasz Figa 2014-08-27 11:14 ` Tomasz Figa 2014-08-29 5:46 ` Naveen Krishna Ch 2014-08-29 5:46 ` Naveen Krishna Ch 2014-08-27 9:44 ` [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7 Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 10:42 ` Mark Rutland 2014-08-27 10:42 ` Mark Rutland 2014-08-27 14:54 ` Catalin Marinas 2014-08-27 14:54 ` Catalin Marinas 2014-09-03 7:48 ` Naveen Krishna Ch [this message] 2014-09-03 7:48 ` Naveen Krishna Ch 2014-08-27 11:30 ` Tomasz Figa 2014-08-27 11:30 ` Tomasz Figa 2014-09-03 7:55 ` Naveen Krishna Ch 2014-09-03 7:55 ` Naveen Krishna Ch 2014-08-28 3:56 ` Olof Johansson 2014-08-28 3:56 ` Olof Johansson 2014-08-28 8:35 ` Marc Zyngier 2014-08-28 8:35 ` Marc Zyngier 2014-08-28 9:48 ` Mark Rutland 2014-08-28 9:48 ` Mark Rutland 2014-08-28 16:28 ` Olof Johansson 2014-08-28 16:28 ` Olof Johansson 2014-08-28 17:03 ` Mark Rutland 2014-08-28 17:03 ` Mark Rutland 2014-08-28 17:19 ` Olof Johansson 2014-08-28 17:19 ` Olof Johansson 2014-08-28 17:39 ` Mark Rutland 2014-08-28 17:39 ` Mark Rutland 2014-08-28 17:47 ` Geert Uytterhoeven 2014-08-28 17:47 ` Geert Uytterhoeven 2014-08-28 18:17 ` Mark Rutland 2014-08-28 18:17 ` Mark Rutland 2014-08-28 17:54 ` Rob Herring 2014-08-28 17:54 ` Rob Herring 2014-08-28 22:23 ` Olof Johansson 2014-08-28 22:23 ` Olof Johansson 2014-08-28 23:30 ` Simon Horman 2014-08-28 23:30 ` Simon Horman 2014-08-28 17:27 ` Marc Zyngier 2014-08-28 17:27 ` Marc Zyngier 2014-08-28 17:30 ` Mark Rutland 2014-08-28 17:30 ` Mark Rutland 2014-08-28 17:37 ` Marc Zyngier 2014-08-28 17:37 ` Marc Zyngier 2014-08-28 17:45 ` Mark Rutland 2014-08-28 17:45 ` Mark Rutland [not found] ` <53FF6668.4080502-5wv7dgnIgG8@public.gmane.org> 2014-08-28 17:33 ` Rob Herring 2014-08-28 17:33 ` Rob Herring 2014-08-28 17:43 ` Mark Rutland 2014-08-28 17:43 ` Mark Rutland 2014-09-03 8:05 ` Naveen Krishna Ch 2014-09-03 8:05 ` Naveen Krishna Ch 2014-08-27 9:44 ` [PATCH 12/14] arm64: dts: add Exynos7 based Espresso board dts file Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 11:32 ` Tomasz Figa 2014-08-27 11:32 ` Tomasz Figa 2014-08-28 4:00 ` Olof Johansson 2014-08-28 4:00 ` Olof Johansson 2014-08-29 5:51 ` Naveen Krishna Ch 2014-08-29 5:51 ` Naveen Krishna Ch 2014-08-27 9:44 ` [PATCH 13/14] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Naveen Krishna Chatradhi 2014-08-27 9:44 ` Naveen Krishna Chatradhi 2014-08-27 11:09 ` Mark Rutland 2014-08-27 11:09 ` Mark Rutland 2014-08-27 14:50 ` Catalin Marinas 2014-08-27 14:50 ` Catalin Marinas 2014-08-28 4:05 ` Olof Johansson 2014-08-28 4:05 ` Olof Johansson 2014-09-03 8:14 ` Naveen Krishna Ch 2014-09-03 8:14 ` Naveen Krishna Ch 2014-08-27 11:34 ` [PATCH 00/14] Support 64bit Cortex A57 based Exynos7 SoC Tomasz Figa 2014-08-27 11:34 ` Tomasz Figa 2014-09-13 10:57 ` Tomasz Figa 2014-09-13 10:57 ` Tomasz Figa 2014-09-14 13:45 ` Thomas Abraham 2014-09-14 13:45 ` Thomas Abraham 2014-08-28 3:47 ` Olof Johansson 2014-08-28 3:47 ` Olof Johansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHfPSqD2_=-zr8p0STSThfdik296tHZkHhXemdxCrSqTx7e1UQ@mail.gmail.com' \ --to=naveenkrishna.ch@gmail.com \ --cc=Catalin.Marinas@arm.com \ --cc=ch.naveen@samsung.com \ --cc=cpgs@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh@kernel.org \ --cc=thomas.ab@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.