From: Dmitry Torokhov <dmitry.torokhov@gmail.com> To: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Cc: Kukjin Kim <kgene.kim@samsung.com>, Doug Anderson <dianders@chromium.org>, Olof Johansson <olof@lixom.net>, afaerber@suse.de, Nick Dyer <nick.dyer@itdev.co.uk>, Yufeng Shen <miletus@chromium.org>, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sjoerd Simons <sjoerd.simons@collabora.co.uk> Subject: Re: [PATCH v4 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad Date: Wed, 10 Sep 2014 15:25:56 -0700 [thread overview] Message-ID: <20140910222553.GF38736@core.coreip.homeip.net> (raw) In-Reply-To: <1410348691-18317-2-git-send-email-javier.martinez@collabora.co.uk> On Wed, Sep 10, 2014 at 01:31:29PM +0200, Javier Martinez Canillas wrote: > From: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > > The Peach Pit board has an Atmel maXTouch trackpad device. > Add the needed Device Tree nodes to support it. > > This Device Tree change is based on the Chrome OS 3.8 tree > but adapted to use the mainline Atmel maXTouch DT binding. > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > > Changes since v3: > - Use KEY_RESERVED even for not reserved pins with a GPIO not hooked. > Suggested by Nick Dyer. > - Add a comment to specify the maXTouch chip version so is more clear. > Suggested by Nick Dyer. > - Omit trailing omit KEY_RESERVED after the GPIO pins. Suggested by Nick Dyer. > > Changes since v2: > - Add spaces around '=' on properties. Suggested by Andreas Faerber. > > Changes since v1: > - Change trackpad IRQ pad function from 0x0 (GPIO input) to 0xf (GPIO IRQ). > suggested by Tomasz Figa. > - Remove BTN_TOOL_* from "linux,gpio-keymap" property since those are set > by input mt core if INPUT_MT_POINTER is set. Suggested by Nick Dyer. > - Use correct values for "linux,gpio-keymap" property. Suggested by Nick Dyer. > - Remove support for Peach Pi board since it uses a different Atmel touchpad > that requires an Atmel object protocol (T100) not supported by the driver. > - Use IRQ type constants from <dt-bindings/interrupt-controller/irq.h> instead > of magic numbers. Suggested by Andreas Faerber. > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index f247709..ad56d4c 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -507,6 +507,28 @@ > }; > }; > > +&hsi2c_8 { > + status = "okay"; > + clock-frequency = <333000>; > + > + /* Atmel mXT336S */ > + trackpad@4b { > + compatible = "atmel,maxtouch"; > + reg = <0x4b>; > + interrupt-parent = <&gpx1>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + wakeup-source; > + pinctrl-names = "default"; > + pinctrl-0 = <&trackpad_irq>; > + linux,gpio-keymap = <KEY_RESERVED > + KEY_RESERVED > + KEY_RESERVED /* GPIO0 */ > + KEY_RESERVED /* GPIO1 */ > + KEY_RESERVED /* GPIO2 */ > + BTN_LEFT>; /* GPIO3 */ Seems like a single space sneaked between the semicolon and the tab. Maybe whoever applies could squash it. Thanks. -- Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad Date: Wed, 10 Sep 2014 15:25:56 -0700 [thread overview] Message-ID: <20140910222553.GF38736@core.coreip.homeip.net> (raw) In-Reply-To: <1410348691-18317-2-git-send-email-javier.martinez@collabora.co.uk> On Wed, Sep 10, 2014 at 01:31:29PM +0200, Javier Martinez Canillas wrote: > From: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > > The Peach Pit board has an Atmel maXTouch trackpad device. > Add the needed Device Tree nodes to support it. > > This Device Tree change is based on the Chrome OS 3.8 tree > but adapted to use the mainline Atmel maXTouch DT binding. > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > > Changes since v3: > - Use KEY_RESERVED even for not reserved pins with a GPIO not hooked. > Suggested by Nick Dyer. > - Add a comment to specify the maXTouch chip version so is more clear. > Suggested by Nick Dyer. > - Omit trailing omit KEY_RESERVED after the GPIO pins. Suggested by Nick Dyer. > > Changes since v2: > - Add spaces around '=' on properties. Suggested by Andreas Faerber. > > Changes since v1: > - Change trackpad IRQ pad function from 0x0 (GPIO input) to 0xf (GPIO IRQ). > suggested by Tomasz Figa. > - Remove BTN_TOOL_* from "linux,gpio-keymap" property since those are set > by input mt core if INPUT_MT_POINTER is set. Suggested by Nick Dyer. > - Use correct values for "linux,gpio-keymap" property. Suggested by Nick Dyer. > - Remove support for Peach Pi board since it uses a different Atmel touchpad > that requires an Atmel object protocol (T100) not supported by the driver. > - Use IRQ type constants from <dt-bindings/interrupt-controller/irq.h> instead > of magic numbers. Suggested by Andreas Faerber. > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index f247709..ad56d4c 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -507,6 +507,28 @@ > }; > }; > > +&hsi2c_8 { > + status = "okay"; > + clock-frequency = <333000>; > + > + /* Atmel mXT336S */ > + trackpad at 4b { > + compatible = "atmel,maxtouch"; > + reg = <0x4b>; > + interrupt-parent = <&gpx1>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + wakeup-source; > + pinctrl-names = "default"; > + pinctrl-0 = <&trackpad_irq>; > + linux,gpio-keymap = <KEY_RESERVED > + KEY_RESERVED > + KEY_RESERVED /* GPIO0 */ > + KEY_RESERVED /* GPIO1 */ > + KEY_RESERVED /* GPIO2 */ > + BTN_LEFT>; /* GPIO3 */ Seems like a single space sneaked between the semicolon and the tab. Maybe whoever applies could squash it. Thanks. -- Dmitry
next prev parent reply other threads:[~2014-09-10 22:26 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-10 11:31 [PATCH v4 0/3] Add Atmel maXTouch support for Peach boards Javier Martinez Canillas 2014-09-10 11:31 ` Javier Martinez Canillas 2014-09-10 11:31 ` [PATCH v4 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad Javier Martinez Canillas 2014-09-10 11:31 ` Javier Martinez Canillas 2014-09-10 22:25 ` Dmitry Torokhov [this message] 2014-09-10 22:25 ` Dmitry Torokhov 2014-09-11 9:44 ` Javier Martinez Canillas 2014-09-11 9:44 ` Javier Martinez Canillas 2014-09-13 16:36 ` Kukjin Kim 2014-09-13 16:36 ` Kukjin Kim 2014-09-10 11:31 ` [PATCH v4 2/3] ARM: dts: Add Peach Pi " Javier Martinez Canillas 2014-09-10 11:31 ` Javier Martinez Canillas 2014-09-10 22:26 ` Dmitry Torokhov 2014-09-10 22:26 ` Dmitry Torokhov 2014-09-10 11:31 ` [PATCH v4 3/3] ARM: exynos_defconfig: Enable Atmel maXTouch support Javier Martinez Canillas 2014-09-10 11:31 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140910222553.GF38736@core.coreip.homeip.net \ --to=dmitry.torokhov@gmail.com \ --cc=afaerber@suse.de \ --cc=dianders@chromium.org \ --cc=javier.martinez@collabora.co.uk \ --cc=kgene.kim@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=miletus@chromium.org \ --cc=nick.dyer@itdev.co.uk \ --cc=olof@lixom.net \ --cc=sjoerd.simons@collabora.co.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.