From: Kukjin Kim <kgene.kim@samsung.com> To: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Kukjin Kim <kgene.kim@samsung.com>, Doug Anderson <dianders@chromium.org>, Nick Dyer <nick.dyer@itdev.co.uk>, linux-kernel@vger.kernel.org, Sjoerd Simons <sjoerd.simons@collabora.co.uk>, linux-samsung-soc@vger.kernel.org, Olof Johansson <olof@lixom.net>, Yufeng Shen <miletus@chromium.org>, afaerber@suse.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad Date: Sun, 14 Sep 2014 01:36:34 +0900 [thread overview] Message-ID: <54147292.2000901@samsung.com> (raw) In-Reply-To: <54116F07.9090007@collabora.co.uk> On 09/11/14 18:44, Javier Martinez Canillas wrote: > Hello Dmitry, > Hi, > On 09/11/2014 12:25 AM, Dmitry Torokhov wrote: >>> >>> +&hsi2c_8 { >>> + status = "okay"; >>> + clock-frequency =<333000>; >>> + >>> + /* Atmel mXT336S */ >>> + trackpad@4b { >>> + compatible = "atmel,maxtouch"; >>> + reg =<0x4b>; >>> + interrupt-parent =<&gpx1>; >>> + interrupts =<1 IRQ_TYPE_EDGE_FALLING>; >>> + wakeup-source; >>> + pinctrl-names = "default"; >>> + pinctrl-0 =<&trackpad_irq>; >>> + linux,gpio-keymap =<KEY_RESERVED >>> + KEY_RESERVED >>> + KEY_RESERVED /* GPIO0 */ >>> + KEY_RESERVED /* GPIO1 */ >>> + KEY_RESERVED /* GPIO2 */ >>> + BTN_LEFT>; /* GPIO3 */ >> >> Seems like a single space sneaked between the semicolon and the tab. >> Maybe whoever applies could squash it. >> > > Right, I set c-default-style to "linux" on Emacs but seems it gets confused > sometimes when editing Device Tree source files. Sorry about that. > Applied this whole series with fixing a white space Dmitry commented. Note, I will handle all of exynos_defconfig changes separately. Thanks, Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad Date: Sun, 14 Sep 2014 01:36:34 +0900 [thread overview] Message-ID: <54147292.2000901@samsung.com> (raw) In-Reply-To: <54116F07.9090007@collabora.co.uk> On 09/11/14 18:44, Javier Martinez Canillas wrote: > Hello Dmitry, > Hi, > On 09/11/2014 12:25 AM, Dmitry Torokhov wrote: >>> >>> +&hsi2c_8 { >>> + status = "okay"; >>> + clock-frequency =<333000>; >>> + >>> + /* Atmel mXT336S */ >>> + trackpad at 4b { >>> + compatible = "atmel,maxtouch"; >>> + reg =<0x4b>; >>> + interrupt-parent =<&gpx1>; >>> + interrupts =<1 IRQ_TYPE_EDGE_FALLING>; >>> + wakeup-source; >>> + pinctrl-names = "default"; >>> + pinctrl-0 =<&trackpad_irq>; >>> + linux,gpio-keymap =<KEY_RESERVED >>> + KEY_RESERVED >>> + KEY_RESERVED /* GPIO0 */ >>> + KEY_RESERVED /* GPIO1 */ >>> + KEY_RESERVED /* GPIO2 */ >>> + BTN_LEFT>; /* GPIO3 */ >> >> Seems like a single space sneaked between the semicolon and the tab. >> Maybe whoever applies could squash it. >> > > Right, I set c-default-style to "linux" on Emacs but seems it gets confused > sometimes when editing Device Tree source files. Sorry about that. > Applied this whole series with fixing a white space Dmitry commented. Note, I will handle all of exynos_defconfig changes separately. Thanks, Kukjin
next prev parent reply other threads:[~2014-09-13 16:36 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-10 11:31 [PATCH v4 0/3] Add Atmel maXTouch support for Peach boards Javier Martinez Canillas 2014-09-10 11:31 ` Javier Martinez Canillas 2014-09-10 11:31 ` [PATCH v4 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad Javier Martinez Canillas 2014-09-10 11:31 ` Javier Martinez Canillas 2014-09-10 22:25 ` Dmitry Torokhov 2014-09-10 22:25 ` Dmitry Torokhov 2014-09-11 9:44 ` Javier Martinez Canillas 2014-09-11 9:44 ` Javier Martinez Canillas 2014-09-13 16:36 ` Kukjin Kim [this message] 2014-09-13 16:36 ` Kukjin Kim 2014-09-10 11:31 ` [PATCH v4 2/3] ARM: dts: Add Peach Pi " Javier Martinez Canillas 2014-09-10 11:31 ` Javier Martinez Canillas 2014-09-10 22:26 ` Dmitry Torokhov 2014-09-10 22:26 ` Dmitry Torokhov 2014-09-10 11:31 ` [PATCH v4 3/3] ARM: exynos_defconfig: Enable Atmel maXTouch support Javier Martinez Canillas 2014-09-10 11:31 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54147292.2000901@samsung.com \ --to=kgene.kim@samsung.com \ --cc=afaerber@suse.de \ --cc=dianders@chromium.org \ --cc=dmitry.torokhov@gmail.com \ --cc=javier.martinez@collabora.co.uk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=miletus@chromium.org \ --cc=nick.dyer@itdev.co.uk \ --cc=olof@lixom.net \ --cc=sjoerd.simons@collabora.co.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.