From: "Theodore Ts'o" <tytso@mit.edu> To: Benjamin LaHaise <bcrl@kvack.org> Cc: Dave Chinner <david@fromorbit.com>, Milosz Tanski <milosz@adfin.com>, Jeff Moyer <jmoyer@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@infradead.org>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, linux-aio@kvack.org, Mel Gorman <mgorman@suse.de>, Volker Lendecke <Volker.Lendecke@sernet.de>, Tejun Heo <tj@kernel.org> Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Date: Wed, 17 Sep 2014 09:47:02 -0400 [thread overview] Message-ID: <20140917134702.GB10720@thunk.org> (raw) In-Reply-To: <20140917122448.GR24821@kvack.org> On Wed, Sep 17, 2014 at 08:24:48AM -0400, Benjamin LaHaise wrote: > > Linus flamed me for that a few weeks ago. The problem is that if one > uses "git format-patch" to prepare a series of emails to post, that it > users the patch's author for the From: entry. I think that is a bug > in git since multiple people have encountered this issue. It's not > like git doesn't know what one's email address is.... That's true, but "git send-email" takes care of doing the rewrite so that your e-mail address is on the from line and the original author's from: line is moved into the body of the e-mail: % git log -1 commit 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Author: Michael Forney <forney@google.com> Date: Mon Sep 15 14:30:00 2014 -0400 Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling Signed-off-by: Michael Forney <forney@google.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> % git format-patch -o /tmp/p -1 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch % head -5 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch >From 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Mon Sep 17 00:00:00 2001 From: Michael Forney <forney@google.com> Date: Mon, 15 Sep 2014 14:30:00 -0400 Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling % git send-email /tmp/p --to tytso@mit.edu /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch (mbox) Adding cc: Michael Forney <forney@google.com> from line 'From: Michael Forney <forney@google.com>' (body) Adding cc: Michael Forney <forney@google.com> from line 'Signed-off-by: Michael Forney <forney@google.com>' (body) Adding cc: Theodore Ts'o <tytso@mit.edu> from line 'Signed-off-by: Theodore Ts'o <tytso@mit.edu>' From: Theodore Ts'o <tytso@mit.edu> To: tytso@mit.edu Cc: Michael Forney <forney@google.com> Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling Date: Wed, 17 Sep 2014 09:45:09 -0400 Message-Id: <1410961509-10620-1-git-send-email-tytso@mit.edu> X-Mailer: git-send-email 2.1.0 Send this email? ([y]es|[n]o|[q]uit|[a]ll): ^C % git version git version 2.1.0 Perhaps you and other people are using your own scripts, and not using git send-email? - Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu> To: Benjamin LaHaise <bcrl@kvack.org> Cc: Dave Chinner <david@fromorbit.com>, Milosz Tanski <milosz@adfin.com>, Jeff Moyer <jmoyer@redhat.com>, LKML <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@infradead.org>, "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>, linux-aio@kvack.org, Mel Gorman <mgorman@suse.de>, Volker Lendecke <Volker.Lendecke@sernet.de>, Tejun Heo <tj@kernel.org> Subject: Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Date: Wed, 17 Sep 2014 09:47:02 -0400 [thread overview] Message-ID: <20140917134702.GB10720@thunk.org> (raw) In-Reply-To: <20140917122448.GR24821@kvack.org> On Wed, Sep 17, 2014 at 08:24:48AM -0400, Benjamin LaHaise wrote: > > Linus flamed me for that a few weeks ago. The problem is that if one > uses "git format-patch" to prepare a series of emails to post, that it > users the patch's author for the From: entry. I think that is a bug > in git since multiple people have encountered this issue. It's not > like git doesn't know what one's email address is.... That's true, but "git send-email" takes care of doing the rewrite so that your e-mail address is on the from line and the original author's from: line is moved into the body of the e-mail: % git log -1 commit 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Author: Michael Forney <forney@google.com> Date: Mon Sep 15 14:30:00 2014 -0400 Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling Signed-off-by: Michael Forney <forney@google.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> % git format-patch -o /tmp/p -1 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch % head -5 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch >From 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10 Mon Sep 17 00:00:00 2001 From: Michael Forney <forney@google.com> Date: Mon, 15 Sep 2014 14:30:00 -0400 Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling % git send-email /tmp/p --to tytso@mit.edu /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch (mbox) Adding cc: Michael Forney <forney@google.com> from line 'From: Michael Forney <forney@google.com>' (body) Adding cc: Michael Forney <forney@google.com> from line 'Signed-off-by: Michael Forney <forney@google.com>' (body) Adding cc: Theodore Ts'o <tytso@mit.edu> from line 'Signed-off-by: Theodore Ts'o <tytso@mit.edu>' From: Theodore Ts'o <tytso@mit.edu> To: tytso@mit.edu Cc: Michael Forney <forney@google.com> Subject: [PATCH] Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling Date: Wed, 17 Sep 2014 09:45:09 -0400 Message-Id: <1410961509-10620-1-git-send-email-tytso@mit.edu> X-Mailer: git-send-email 2.1.0 Send this email? ([y]es|[n]o|[q]uit|[a]ll): ^C % git version git version 2.1.0 Perhaps you and other people are using your own scripts, and not using git send-email? - Ted -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2014-09-17 13:48 UTC|newest] Thread overview: 167+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-15 20:20 [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only) Milosz Tanski 2014-09-15 20:20 ` Milosz Tanski 2014-09-15 20:20 ` [PATCH 1/7] Prepare for adding a new readv/writev with user flags Milosz Tanski 2014-09-15 20:20 ` Milosz Tanski 2014-09-15 20:28 ` Al Viro 2014-09-15 21:15 ` Christoph Hellwig 2014-09-15 21:15 ` Christoph Hellwig 2014-09-15 21:44 ` Milosz Tanski 2014-09-15 21:44 ` Milosz Tanski 2014-09-15 20:20 ` [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2 Milosz Tanski 2014-09-15 20:20 ` Milosz Tanski 2014-09-16 19:20 ` Jeff Moyer 2014-09-16 19:20 ` Jeff Moyer 2014-09-16 19:54 ` Milosz Tanski 2014-09-16 19:54 ` Milosz Tanski 2014-09-16 21:03 ` Christoph Hellwig 2014-09-16 21:03 ` Christoph Hellwig 2014-09-17 15:43 ` Theodore Ts'o 2014-09-17 15:43 ` Theodore Ts'o 2014-09-17 16:05 ` Milosz Tanski 2014-09-17 16:05 ` Milosz Tanski 2014-09-17 16:59 ` Theodore Ts'o 2014-09-17 16:59 ` Theodore Ts'o 2014-09-17 17:24 ` Zach Brown 2014-09-17 17:24 ` Zach Brown 2014-09-15 20:20 ` [PATCH 3/7] Export new vector IO (with flags) to userland Milosz Tanski 2014-09-15 20:20 ` Milosz Tanski 2014-09-15 20:21 ` [PATCH 4/7] O_NONBLOCK flag for readv2/preadv2 Milosz Tanski 2014-09-15 20:21 ` Milosz Tanski 2014-09-16 19:19 ` Jeff Moyer 2014-09-16 19:19 ` Jeff Moyer 2014-09-16 19:44 ` Milosz Tanski 2014-09-16 19:44 ` Milosz Tanski 2014-09-16 19:53 ` Jeff Moyer 2014-09-16 19:53 ` Jeff Moyer 2014-09-15 20:21 ` [PATCH 5/7] documentation updates Christoph Hellwig 2014-09-15 20:21 ` Christoph Hellwig 2014-09-15 20:21 ` [PATCH 6/7] move flags enforcement to vfs_preadv/vfs_pwritev Christoph Hellwig 2014-09-15 21:15 ` Christoph Hellwig 2014-09-15 21:15 ` Christoph Hellwig 2014-09-15 21:45 ` Milosz Tanski 2014-09-15 21:45 ` Milosz Tanski 2014-09-15 20:22 ` [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Christoph Hellwig 2014-09-15 20:22 ` Christoph Hellwig 2014-09-16 19:27 ` Jeff Moyer 2014-09-16 19:27 ` Jeff Moyer 2014-09-16 19:45 ` Milosz Tanski 2014-09-16 19:45 ` Milosz Tanski 2014-09-16 21:42 ` Dave Chinner 2014-09-16 21:42 ` Dave Chinner 2014-09-17 12:24 ` Benjamin LaHaise 2014-09-17 12:24 ` Benjamin LaHaise 2014-09-17 13:47 ` Theodore Ts'o [this message] 2014-09-17 13:47 ` Theodore Ts'o 2014-09-17 13:56 ` Benjamin LaHaise 2014-09-17 13:56 ` Benjamin LaHaise 2014-09-17 15:33 ` Milosz Tanski 2014-09-17 15:33 ` Milosz Tanski 2014-09-17 15:49 ` Theodore Ts'o 2014-09-17 15:49 ` Theodore Ts'o 2014-09-17 15:52 ` Zach Brown 2014-09-17 15:52 ` Zach Brown 2014-09-16 21:04 ` Christoph Hellwig 2014-09-16 21:04 ` Christoph Hellwig 2014-09-16 21:24 ` Jeff Moyer 2014-09-16 21:24 ` Jeff Moyer 2014-09-15 20:27 ` [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only) Milosz Tanski 2014-09-15 20:27 ` Milosz Tanski 2014-09-15 21:33 ` Andreas Dilger 2014-09-15 22:13 ` Milosz Tanski 2014-09-15 22:13 ` Milosz Tanski 2014-09-15 22:36 ` Elliott, Robert (Server Storage) 2014-09-15 22:36 ` Elliott, Robert (Server Storage) 2014-09-16 18:24 ` Zach Brown 2014-09-16 18:24 ` Zach Brown 2014-09-19 11:21 ` Christoph Hellwig 2014-09-19 11:21 ` Christoph Hellwig 2014-09-22 15:48 ` Jeff Moyer 2014-09-22 15:48 ` Jeff Moyer 2014-09-22 16:32 ` Milosz Tanski 2014-09-22 16:32 ` Milosz Tanski 2014-09-22 16:42 ` Christoph Hellwig 2014-09-22 17:02 ` Milosz Tanski 2014-09-22 17:02 ` Milosz Tanski 2014-09-22 16:25 ` Elliott, Robert (Server Storage) 2014-09-15 21:58 ` Jeff Moyer 2014-09-15 21:58 ` Jeff Moyer 2014-09-15 22:27 ` Milosz Tanski 2014-09-15 22:27 ` Milosz Tanski 2014-09-16 13:44 ` Jeff Moyer 2014-09-16 13:44 ` Jeff Moyer 2014-09-19 11:23 ` Christoph Hellwig 2014-09-19 11:23 ` Christoph Hellwig 2014-09-16 19:30 ` Jeff Moyer 2014-09-16 19:30 ` Jeff Moyer 2014-09-16 20:34 ` Milosz Tanski 2014-09-16 20:34 ` Milosz Tanski 2014-09-16 20:49 ` Jeff Moyer 2014-09-16 20:49 ` Jeff Moyer 2014-09-17 14:49 ` [RFC 1/2] aio: async readahead Benjamin LaHaise 2014-09-17 14:49 ` Benjamin LaHaise 2014-09-17 15:26 ` [RFC 2/2] ext4: async readpage for indirect style inodes Benjamin LaHaise 2014-09-17 15:26 ` Benjamin LaHaise 2014-09-19 11:26 ` [RFC 1/2] aio: async readahead Christoph Hellwig 2014-09-19 11:26 ` Christoph Hellwig 2014-09-19 16:01 ` Benjamin LaHaise 2014-09-19 16:01 ` Benjamin LaHaise 2014-09-17 22:20 ` [RFC v2 0/5] Non-blockling buffered fs read (page cache only) Milosz Tanski 2014-09-17 22:20 ` Milosz Tanski 2014-09-17 22:20 ` [RFC v2 1/5] Prepare for adding a new readv/writev with user flags Milosz Tanski 2014-09-17 22:20 ` Milosz Tanski 2014-09-17 22:20 ` [RFC v2 2/5] Define new syscalls readv2,preadv2,writev2,pwritev2 Milosz Tanski 2014-09-17 22:20 ` Milosz Tanski 2014-09-18 18:48 ` Darrick J. Wong 2014-09-18 18:48 ` Darrick J. Wong 2014-09-19 10:52 ` Christoph Hellwig 2014-09-19 10:52 ` Christoph Hellwig 2014-09-20 0:19 ` Darrick J. Wong 2014-09-20 0:19 ` Darrick J. Wong 2014-09-17 22:20 ` [RFC v2 3/5] Export new vector IO (with flags) to userland Milosz Tanski 2014-09-17 22:20 ` Milosz Tanski 2014-09-17 22:20 ` [RFC v2 4/5] O_NONBLOCK flag for readv2/preadv2 Milosz Tanski 2014-09-17 22:20 ` Milosz Tanski 2014-09-19 11:27 ` Christoph Hellwig 2014-09-19 11:27 ` Christoph Hellwig 2014-09-19 11:59 ` Milosz Tanski 2014-09-19 11:59 ` Milosz Tanski 2014-09-22 17:12 ` Jeff Moyer 2014-09-22 17:12 ` Jeff Moyer 2014-09-17 22:20 ` [RFC v2 5/5] Check for O_NONBLOCK in all read_iter instances Milosz Tanski 2014-09-17 22:20 ` Milosz Tanski 2014-09-19 11:26 ` Christoph Hellwig 2014-09-19 11:26 ` Christoph Hellwig 2014-09-19 14:42 ` [RFC v2 0/5] Non-blockling buffered fs read (page cache only) Jonathan Corbet 2014-09-19 14:42 ` Jonathan Corbet 2014-09-19 16:13 ` Volker Lendecke 2014-09-19 16:13 ` Volker Lendecke 2014-09-19 17:19 ` Milosz Tanski 2014-09-19 17:19 ` Milosz Tanski 2014-09-19 17:33 ` Milosz Tanski 2014-09-19 17:33 ` Milosz Tanski 2014-09-22 14:12 ` Jonathan Corbet 2014-09-22 14:12 ` Jonathan Corbet 2014-09-22 14:24 ` Jeff Moyer 2014-09-22 14:24 ` Jeff Moyer 2014-09-22 14:25 ` Christoph Hellwig 2014-09-22 14:25 ` Christoph Hellwig 2014-09-22 14:30 ` Milosz Tanski 2014-09-22 14:30 ` Milosz Tanski 2014-09-24 21:46 ` [RFC v3 0/4] vfs: " Milosz Tanski 2014-09-24 21:46 ` Milosz Tanski 2014-09-24 21:46 ` [RFC v3 1/4] vfs: Prepare for adding a new preadv/pwritev with user flags Milosz Tanski 2014-09-24 21:46 ` Milosz Tanski 2014-09-24 21:46 ` [RFC v3 2/4] vfs: Define new syscalls preadv2,pwritev2 Milosz Tanski 2014-09-24 21:46 ` Milosz Tanski 2014-09-24 21:46 ` [RFC v3 3/4] vfs: Export new vector IO syscalls (with flags) to userland Milosz Tanski 2014-09-24 21:46 ` Milosz Tanski 2014-09-24 21:46 ` [RFC v3 4/4] vfs: RWF_NONBLOCK flag for preadv2 Milosz Tanski 2014-09-24 21:46 ` Milosz Tanski 2014-09-25 4:06 ` [RFC v3 0/4] vfs: Non-blockling buffered fs read (page cache only) Michael Kerrisk 2014-09-25 4:06 ` Michael Kerrisk 2014-09-25 11:16 ` Jan Kara 2014-09-25 11:16 ` Jan Kara 2014-09-25 15:48 ` Milosz Tanski 2014-09-25 15:48 ` Milosz Tanski 2014-10-08 2:53 ` Milosz Tanski 2014-10-08 2:53 ` Milosz Tanski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140917134702.GB10720@thunk.org \ --to=tytso@mit.edu \ --cc=Volker.Lendecke@sernet.de \ --cc=bcrl@kvack.org \ --cc=david@fromorbit.com \ --cc=hch@infradead.org \ --cc=jmoyer@redhat.com \ --cc=linux-aio@kvack.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mgorman@suse.de \ --cc=milosz@adfin.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.