All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milosz Tanski <milosz@adfin.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeff Moyer <jmoyer@redhat.com>,
	"Elliott, Robert (Server Storage)" <Elliott@hp.com>,
	Andreas Dilger <adilger@dilger.ca>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-aio@kvack.org" <linux-aio@kvack.org>,
	Mel Gorman <mgorman@suse.de>,
	Volker Lendecke <Volker.Lendecke@sernet.de>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only)
Date: Mon, 22 Sep 2014 13:02:03 -0400	[thread overview]
Message-ID: <CANP1eJG0CDtAA-7q3MvQE7Fz0=awYu0V4p43w-1vw2oV=gg-qQ@mail.gmail.com> (raw)
In-Reply-To: <20140922164237.GA30229@infradead.org>

I'll send out the next RFC with 2 syscalls and magic position values.
I'm waiting for Jeff to chime in on the v2 patchset before I send out
the next one.

On Mon, Sep 22, 2014 at 12:42 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Sep 22, 2014 at 12:32:02PM -0400, Milosz Tanski wrote:
>> I spent some time thinking about multi-position scatter/gather in
>> context of this over the weekend. The non-blocking case seams easy,
>> the implementation I purposed needs an extra loop. Where this gets
>> hairy is making the non-trivial blocking case work well (as in have
>> concurrent requests for each of the ranges) in the filesystem code. If
>> that's the road we're going to go down I have a gut feeling we're
>> going to get stuck in the same spot(s) as the other non-blocking
>> buffered r/w attempts from the past.
>
> The other thing sis that we have a basically ready, easy to use
> implementation of flagged I/O (my name for the new syscalls), while
> S/G I/O will take forever to discuss and is the natual vehicle for
> other extensions like T10 DIX.
>
> I'd like to suggest you consolidate your syscalls down from 4 to 2
> as suggestes by overloading the negative offset argument, giving
> us two more syscalls slows for S/G once it's ready.  Note that
> a sync S/G syscalls should of course also support these flags, although
> I suspect the primary use cases for S/G I/O would be through the aio
> machinery.



-- 
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016

p: 646-253-9055
e: milosz@adfin.com

WARNING: multiple messages have this Message-ID (diff)
From: Milosz Tanski <milosz@adfin.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeff Moyer <jmoyer@redhat.com>,
	"Elliott, Robert (Server Storage)" <Elliott@hp.com>,
	Andreas Dilger <adilger@dilger.ca>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-aio@kvack.org" <linux-aio@kvack.org>,
	Mel Gorman <mgorman@suse.de>,
	Volker Lendecke <Volker.Lendecke@sernet.de>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only)
Date: Mon, 22 Sep 2014 13:02:03 -0400	[thread overview]
Message-ID: <CANP1eJG0CDtAA-7q3MvQE7Fz0=awYu0V4p43w-1vw2oV=gg-qQ@mail.gmail.com> (raw)
In-Reply-To: <20140922164237.GA30229@infradead.org>

I'll send out the next RFC with 2 syscalls and magic position values.
I'm waiting for Jeff to chime in on the v2 patchset before I send out
the next one.

On Mon, Sep 22, 2014 at 12:42 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Sep 22, 2014 at 12:32:02PM -0400, Milosz Tanski wrote:
>> I spent some time thinking about multi-position scatter/gather in
>> context of this over the weekend. The non-blocking case seams easy,
>> the implementation I purposed needs an extra loop. Where this gets
>> hairy is making the non-trivial blocking case work well (as in have
>> concurrent requests for each of the ranges) in the filesystem code. If
>> that's the road we're going to go down I have a gut feeling we're
>> going to get stuck in the same spot(s) as the other non-blocking
>> buffered r/w attempts from the past.
>
> The other thing sis that we have a basically ready, easy to use
> implementation of flagged I/O (my name for the new syscalls), while
> S/G I/O will take forever to discuss and is the natual vehicle for
> other extensions like T10 DIX.
>
> I'd like to suggest you consolidate your syscalls down from 4 to 2
> as suggestes by overloading the negative offset argument, giving
> us two more syscalls slows for S/G once it's ready.  Note that
> a sync S/G syscalls should of course also support these flags, although
> I suspect the primary use cases for S/G I/O would be through the aio
> machinery.



-- 
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016

p: 646-253-9055
e: milosz@adfin.com

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>

  reply	other threads:[~2014-09-22 17:02 UTC|newest]

Thread overview: 167+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15 20:20 [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-15 20:20 ` Milosz Tanski
2014-09-15 20:20 ` [PATCH 1/7] Prepare for adding a new readv/writev with user flags Milosz Tanski
2014-09-15 20:20   ` Milosz Tanski
2014-09-15 20:28   ` Al Viro
2014-09-15 21:15     ` Christoph Hellwig
2014-09-15 21:15       ` Christoph Hellwig
2014-09-15 21:44       ` Milosz Tanski
2014-09-15 21:44         ` Milosz Tanski
2014-09-15 20:20 ` [PATCH 2/7] Define new syscalls readv2,preadv2,writev2,pwritev2 Milosz Tanski
2014-09-15 20:20   ` Milosz Tanski
2014-09-16 19:20   ` Jeff Moyer
2014-09-16 19:20     ` Jeff Moyer
2014-09-16 19:54     ` Milosz Tanski
2014-09-16 19:54       ` Milosz Tanski
2014-09-16 21:03     ` Christoph Hellwig
2014-09-16 21:03       ` Christoph Hellwig
2014-09-17 15:43   ` Theodore Ts'o
2014-09-17 15:43     ` Theodore Ts'o
2014-09-17 16:05     ` Milosz Tanski
2014-09-17 16:05       ` Milosz Tanski
2014-09-17 16:59       ` Theodore Ts'o
2014-09-17 16:59         ` Theodore Ts'o
2014-09-17 17:24         ` Zach Brown
2014-09-17 17:24           ` Zach Brown
2014-09-15 20:20 ` [PATCH 3/7] Export new vector IO (with flags) to userland Milosz Tanski
2014-09-15 20:20   ` Milosz Tanski
2014-09-15 20:21 ` [PATCH 4/7] O_NONBLOCK flag for readv2/preadv2 Milosz Tanski
2014-09-15 20:21   ` Milosz Tanski
2014-09-16 19:19   ` Jeff Moyer
2014-09-16 19:19     ` Jeff Moyer
2014-09-16 19:44     ` Milosz Tanski
2014-09-16 19:44       ` Milosz Tanski
2014-09-16 19:53       ` Jeff Moyer
2014-09-16 19:53         ` Jeff Moyer
2014-09-15 20:21 ` [PATCH 5/7] documentation updates Christoph Hellwig
2014-09-15 20:21   ` Christoph Hellwig
2014-09-15 20:21 ` [PATCH 6/7] move flags enforcement to vfs_preadv/vfs_pwritev Christoph Hellwig
2014-09-15 21:15   ` Christoph Hellwig
2014-09-15 21:15     ` Christoph Hellwig
2014-09-15 21:45     ` Milosz Tanski
2014-09-15 21:45       ` Milosz Tanski
2014-09-15 20:22 ` [PATCH 7/7] check for O_NONBLOCK in all read_iter instances Christoph Hellwig
2014-09-15 20:22   ` Christoph Hellwig
2014-09-16 19:27   ` Jeff Moyer
2014-09-16 19:27     ` Jeff Moyer
2014-09-16 19:45     ` Milosz Tanski
2014-09-16 19:45       ` Milosz Tanski
2014-09-16 21:42       ` Dave Chinner
2014-09-16 21:42         ` Dave Chinner
2014-09-17 12:24         ` Benjamin LaHaise
2014-09-17 12:24           ` Benjamin LaHaise
2014-09-17 13:47           ` Theodore Ts'o
2014-09-17 13:47             ` Theodore Ts'o
2014-09-17 13:56             ` Benjamin LaHaise
2014-09-17 13:56               ` Benjamin LaHaise
2014-09-17 15:33               ` Milosz Tanski
2014-09-17 15:33                 ` Milosz Tanski
2014-09-17 15:49                 ` Theodore Ts'o
2014-09-17 15:49                   ` Theodore Ts'o
2014-09-17 15:52               ` Zach Brown
2014-09-17 15:52                 ` Zach Brown
2014-09-16 21:04     ` Christoph Hellwig
2014-09-16 21:04       ` Christoph Hellwig
2014-09-16 21:24       ` Jeff Moyer
2014-09-16 21:24         ` Jeff Moyer
2014-09-15 20:27 ` [RFC PATCH 0/7] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-15 20:27   ` Milosz Tanski
2014-09-15 21:33 ` Andreas Dilger
2014-09-15 22:13   ` Milosz Tanski
2014-09-15 22:13     ` Milosz Tanski
2014-09-15 22:36   ` Elliott, Robert (Server Storage)
2014-09-15 22:36     ` Elliott, Robert (Server Storage)
2014-09-16 18:24     ` Zach Brown
2014-09-16 18:24       ` Zach Brown
2014-09-19 11:21     ` Christoph Hellwig
2014-09-19 11:21       ` Christoph Hellwig
2014-09-22 15:48       ` Jeff Moyer
2014-09-22 15:48         ` Jeff Moyer
2014-09-22 16:32         ` Milosz Tanski
2014-09-22 16:32           ` Milosz Tanski
2014-09-22 16:42           ` Christoph Hellwig
2014-09-22 17:02             ` Milosz Tanski [this message]
2014-09-22 17:02               ` Milosz Tanski
2014-09-22 16:25       ` Elliott, Robert (Server Storage)
2014-09-15 21:58 ` Jeff Moyer
2014-09-15 21:58   ` Jeff Moyer
2014-09-15 22:27   ` Milosz Tanski
2014-09-15 22:27     ` Milosz Tanski
2014-09-16 13:44     ` Jeff Moyer
2014-09-16 13:44       ` Jeff Moyer
2014-09-19 11:23   ` Christoph Hellwig
2014-09-19 11:23     ` Christoph Hellwig
2014-09-16 19:30 ` Jeff Moyer
2014-09-16 19:30   ` Jeff Moyer
2014-09-16 20:34   ` Milosz Tanski
2014-09-16 20:34     ` Milosz Tanski
2014-09-16 20:49     ` Jeff Moyer
2014-09-16 20:49       ` Jeff Moyer
2014-09-17 14:49 ` [RFC 1/2] aio: async readahead Benjamin LaHaise
2014-09-17 14:49   ` Benjamin LaHaise
2014-09-17 15:26   ` [RFC 2/2] ext4: async readpage for indirect style inodes Benjamin LaHaise
2014-09-17 15:26     ` Benjamin LaHaise
2014-09-19 11:26   ` [RFC 1/2] aio: async readahead Christoph Hellwig
2014-09-19 11:26     ` Christoph Hellwig
2014-09-19 16:01     ` Benjamin LaHaise
2014-09-19 16:01       ` Benjamin LaHaise
2014-09-17 22:20 ` [RFC v2 0/5] Non-blockling buffered fs read (page cache only) Milosz Tanski
2014-09-17 22:20   ` Milosz Tanski
2014-09-17 22:20   ` [RFC v2 1/5] Prepare for adding a new readv/writev with user flags Milosz Tanski
2014-09-17 22:20     ` Milosz Tanski
2014-09-17 22:20   ` [RFC v2 2/5] Define new syscalls readv2,preadv2,writev2,pwritev2 Milosz Tanski
2014-09-17 22:20     ` Milosz Tanski
2014-09-18 18:48     ` Darrick J. Wong
2014-09-18 18:48       ` Darrick J. Wong
2014-09-19 10:52       ` Christoph Hellwig
2014-09-19 10:52         ` Christoph Hellwig
2014-09-20  0:19         ` Darrick J. Wong
2014-09-20  0:19           ` Darrick J. Wong
2014-09-17 22:20   ` [RFC v2 3/5] Export new vector IO (with flags) to userland Milosz Tanski
2014-09-17 22:20     ` Milosz Tanski
2014-09-17 22:20   ` [RFC v2 4/5] O_NONBLOCK flag for readv2/preadv2 Milosz Tanski
2014-09-17 22:20     ` Milosz Tanski
2014-09-19 11:27     ` Christoph Hellwig
2014-09-19 11:27       ` Christoph Hellwig
2014-09-19 11:59       ` Milosz Tanski
2014-09-19 11:59         ` Milosz Tanski
2014-09-22 17:12     ` Jeff Moyer
2014-09-22 17:12       ` Jeff Moyer
2014-09-17 22:20   ` [RFC v2 5/5] Check for O_NONBLOCK in all read_iter instances Milosz Tanski
2014-09-17 22:20     ` Milosz Tanski
2014-09-19 11:26     ` Christoph Hellwig
2014-09-19 11:26       ` Christoph Hellwig
2014-09-19 14:42   ` [RFC v2 0/5] Non-blockling buffered fs read (page cache only) Jonathan Corbet
2014-09-19 14:42     ` Jonathan Corbet
2014-09-19 16:13     ` Volker Lendecke
2014-09-19 16:13       ` Volker Lendecke
2014-09-19 17:19     ` Milosz Tanski
2014-09-19 17:19       ` Milosz Tanski
2014-09-19 17:33     ` Milosz Tanski
2014-09-19 17:33       ` Milosz Tanski
2014-09-22 14:12       ` Jonathan Corbet
2014-09-22 14:12         ` Jonathan Corbet
2014-09-22 14:24         ` Jeff Moyer
2014-09-22 14:24           ` Jeff Moyer
2014-09-22 14:25         ` Christoph Hellwig
2014-09-22 14:25           ` Christoph Hellwig
2014-09-22 14:30         ` Milosz Tanski
2014-09-22 14:30           ` Milosz Tanski
2014-09-24 21:46 ` [RFC v3 0/4] vfs: " Milosz Tanski
2014-09-24 21:46   ` Milosz Tanski
2014-09-24 21:46   ` [RFC v3 1/4] vfs: Prepare for adding a new preadv/pwritev with user flags Milosz Tanski
2014-09-24 21:46     ` Milosz Tanski
2014-09-24 21:46   ` [RFC v3 2/4] vfs: Define new syscalls preadv2,pwritev2 Milosz Tanski
2014-09-24 21:46     ` Milosz Tanski
2014-09-24 21:46   ` [RFC v3 3/4] vfs: Export new vector IO syscalls (with flags) to userland Milosz Tanski
2014-09-24 21:46     ` Milosz Tanski
2014-09-24 21:46   ` [RFC v3 4/4] vfs: RWF_NONBLOCK flag for preadv2 Milosz Tanski
2014-09-24 21:46     ` Milosz Tanski
2014-09-25  4:06   ` [RFC v3 0/4] vfs: Non-blockling buffered fs read (page cache only) Michael Kerrisk
2014-09-25  4:06     ` Michael Kerrisk
2014-09-25 11:16     ` Jan Kara
2014-09-25 11:16       ` Jan Kara
2014-09-25 15:48     ` Milosz Tanski
2014-09-25 15:48       ` Milosz Tanski
2014-10-08  2:53   ` Milosz Tanski
2014-10-08  2:53     ` Milosz Tanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANP1eJG0CDtAA-7q3MvQE7Fz0=awYu0V4p43w-1vw2oV=gg-qQ@mail.gmail.com' \
    --to=milosz@adfin.com \
    --cc=Elliott@hp.com \
    --cc=Volker.Lendecke@sernet.de \
    --cc=adilger@dilger.ca \
    --cc=hch@infradead.org \
    --cc=jmoyer@redhat.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.