From: Will Deacon <will.deacon@arm.com> To: Arnd Bergmann <arnd@arndb.de> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Robert Richter <rric@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, "grant.likely@linaro.org" <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Liviu Dudau <Liviu.Dudau@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Robert Richter <rrichter@cavium.com>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, Sunil Goutham <sgoutham@cavium.com> Subject: Re: [PATCH 1/6] pci, thunder: Add support for Thunder PCIe host controller Date: Wed, 24 Sep 2014 17:49:46 +0100 [thread overview] Message-ID: <20140924164946.GI16244@arm.com> (raw) In-Reply-To: <27476217.5ToIFGoMDz@wuerfel> On Wed, Sep 24, 2014 at 05:12:26PM +0100, Arnd Bergmann wrote: > On Wednesday 24 September 2014 17:37:43 Robert Richter wrote: > > From: Sunil Goutham <sgoutham@cavium.com> > > > > This patch adds support for PCI host controller of Cavium Thunder > > SoCs. > > I had expected this hardware to be SBSA compliant. Why do you need > a hardware specific driver, is this a workaround for buggy hardware > or just noncompliant? Patches welcome to pci-host-generic.c :) Lorenzo already has code to port it to Liviu's new API, so do shout if it's not suitable for your needs. > > +static int thunder_pcie_msi_enable(struct thunder_pcie *pcie, > > + struct pci_bus *bus) > > +{ > > + struct device_node *msi_node; > > + > > + msi_node = of_parse_phandle(pcie->node, "msi-parent", 0); > > + if (!msi_node) > > + return -ENODEV; > > + > > + pcie->msi = of_pci_find_msi_chip_by_node(msi_node); > > + if (!pcie->msi) > > + return -ENODEV; > > + > > + pcie->msi->dev = pcie->dev; > > + bus->msi = pcie->msi; > > + > > + return 0; > > +} > > This is probably something we should add to the generic host driver as well, > so it can work with SBSA compliant implementations that come with an MSI > controller. Maybe move it into common code so it can be shared with that > driver. Agreed. I've been carrying something similar [1] (based on a hacked-up version of bios32, so not bothered to post it) whilst I've been waiting for the arm64 core PCI code to get merged. Will [1] https://git.kernel.org/cgit/linux/kernel/git/will/linux.git/commit/drivers/pci/host/pci-host-generic.c?h=iommu/pci&id=b719acf062ceccfbd79ee7b1ae0b7904ea4da27e
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/6] pci, thunder: Add support for Thunder PCIe host controller Date: Wed, 24 Sep 2014 17:49:46 +0100 [thread overview] Message-ID: <20140924164946.GI16244@arm.com> (raw) In-Reply-To: <27476217.5ToIFGoMDz@wuerfel> On Wed, Sep 24, 2014 at 05:12:26PM +0100, Arnd Bergmann wrote: > On Wednesday 24 September 2014 17:37:43 Robert Richter wrote: > > From: Sunil Goutham <sgoutham@cavium.com> > > > > This patch adds support for PCI host controller of Cavium Thunder > > SoCs. > > I had expected this hardware to be SBSA compliant. Why do you need > a hardware specific driver, is this a workaround for buggy hardware > or just noncompliant? Patches welcome to pci-host-generic.c :) Lorenzo already has code to port it to Liviu's new API, so do shout if it's not suitable for your needs. > > +static int thunder_pcie_msi_enable(struct thunder_pcie *pcie, > > + struct pci_bus *bus) > > +{ > > + struct device_node *msi_node; > > + > > + msi_node = of_parse_phandle(pcie->node, "msi-parent", 0); > > + if (!msi_node) > > + return -ENODEV; > > + > > + pcie->msi = of_pci_find_msi_chip_by_node(msi_node); > > + if (!pcie->msi) > > + return -ENODEV; > > + > > + pcie->msi->dev = pcie->dev; > > + bus->msi = pcie->msi; > > + > > + return 0; > > +} > > This is probably something we should add to the generic host driver as well, > so it can work with SBSA compliant implementations that come with an MSI > controller. Maybe move it into common code so it can be shared with that > driver. Agreed. I've been carrying something similar [1] (based on a hacked-up version of bios32, so not bothered to post it) whilst I've been waiting for the arm64 core PCI code to get merged. Will [1] https://git.kernel.org/cgit/linux/kernel/git/will/linux.git/commit/drivers/pci/host/pci-host-generic.c?h=iommu/pci&id=b719acf062ceccfbd79ee7b1ae0b7904ea4da27e
next prev parent reply other threads:[~2014-09-24 16:50 UTC|newest] Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-24 15:37 [PATCH 0/6] pci, thunder: Add Cavium Thunder PCIe host controller Robert Richter 2014-09-24 15:37 ` Robert Richter 2014-09-24 15:37 ` [PATCH 1/6] pci, thunder: Add support for " Robert Richter 2014-09-24 15:37 ` Robert Richter 2014-09-24 15:37 ` Robert Richter 2014-09-24 16:12 ` Arnd Bergmann 2014-09-24 16:12 ` Arnd Bergmann 2014-09-24 16:49 ` Will Deacon [this message] 2014-09-24 16:49 ` Will Deacon 2014-09-24 16:49 ` Will Deacon 2014-09-30 9:14 ` Sunil Kovvuri 2014-09-30 9:14 ` Sunil Kovvuri 2014-09-30 9:14 ` Sunil Kovvuri 2014-09-24 15:37 ` [PATCH 2/6] GICv3: Add ITS entry to THUNDER dts Robert Richter 2014-09-24 15:37 ` Robert Richter 2014-09-24 15:37 ` Robert Richter 2015-06-25 23:19 ` Chalamarla, Tirumalesh 2015-06-25 23:19 ` Chalamarla, Tirumalesh 2015-06-25 23:19 ` Chalamarla, Tirumalesh 2015-06-25 23:19 ` Chalamarla, Tirumalesh 2015-06-26 9:00 ` Marc Zyngier 2015-06-26 9:00 ` Marc Zyngier 2015-06-26 9:00 ` Marc Zyngier 2014-09-24 15:37 ` [PATCH 3/6] pci, thunder: Add PCIe host controller devicetree bindings Robert Richter 2014-09-24 15:37 ` Robert Richter 2014-09-24 16:06 ` Arnd Bergmann 2014-09-24 16:06 ` Arnd Bergmann 2014-09-24 18:04 ` Sunil Kovvuri 2014-09-24 18:04 ` Sunil Kovvuri 2014-09-24 18:34 ` Arnd Bergmann 2014-09-24 18:34 ` Arnd Bergmann 2014-09-24 18:34 ` Arnd Bergmann 2014-09-24 19:07 ` Sunil Kovvuri 2014-09-24 19:07 ` Sunil Kovvuri 2014-09-25 7:31 ` Arnd Bergmann 2014-09-25 7:31 ` Arnd Bergmann 2014-09-25 16:16 ` Bjorn Helgaas 2014-09-25 16:16 ` Bjorn Helgaas 2014-09-25 19:26 ` Arnd Bergmann 2014-09-25 19:26 ` Arnd Bergmann 2014-09-25 20:10 ` Bjorn Helgaas 2014-09-25 20:10 ` Bjorn Helgaas 2014-09-25 20:10 ` Bjorn Helgaas 2014-09-25 20:22 ` Arnd Bergmann 2014-09-25 20:22 ` Arnd Bergmann 2014-09-25 20:22 ` Arnd Bergmann 2014-09-25 20:49 ` Bjorn Helgaas 2014-09-25 20:49 ` Bjorn Helgaas 2014-09-26 18:26 ` Rob Herring 2014-09-26 18:26 ` Rob Herring 2014-09-26 18:26 ` Rob Herring 2014-09-30 9:11 ` Sunil Kovvuri 2014-09-30 9:11 ` Sunil Kovvuri 2014-09-30 9:11 ` Sunil Kovvuri 2014-10-07 14:27 ` Robert Richter 2014-10-07 14:27 ` Robert Richter 2014-10-07 14:27 ` Robert Richter 2014-10-07 15:01 ` Liviu Dudau 2014-10-07 15:01 ` Liviu Dudau 2014-10-07 15:01 ` Liviu Dudau 2014-10-07 15:01 ` Liviu Dudau 2014-10-08 8:49 ` Robert Richter 2014-10-08 8:49 ` Robert Richter 2014-10-08 8:49 ` Robert Richter 2014-10-08 16:44 ` Liviu Dudau 2014-10-08 16:44 ` Liviu Dudau 2014-10-08 16:44 ` Liviu Dudau 2014-10-09 6:23 ` Robert Richter 2014-10-09 6:23 ` Robert Richter 2014-10-09 6:23 ` Robert Richter 2014-10-09 6:23 ` Robert Richter 2014-09-24 15:37 ` [PATCH 4/6] pci, thunder: Document " Robert Richter 2014-09-24 15:37 ` Robert Richter 2014-09-24 15:37 ` [PATCH 5/6] arm64, defconfig: Enable PCI Robert Richter 2014-09-24 15:37 ` Robert Richter 2014-09-24 16:14 ` Arnd Bergmann 2014-09-24 16:14 ` Arnd Bergmann 2014-09-24 16:26 ` Robert Richter 2014-09-24 16:26 ` Robert Richter 2014-09-24 17:10 ` Catalin Marinas 2014-09-24 17:10 ` Catalin Marinas 2014-09-24 17:10 ` Catalin Marinas 2014-09-24 18:40 ` Arnd Bergmann 2014-09-24 18:40 ` Arnd Bergmann 2014-09-24 18:40 ` Arnd Bergmann 2014-09-25 9:35 ` Catalin Marinas 2014-09-25 9:35 ` Catalin Marinas 2014-09-25 9:35 ` Catalin Marinas 2014-09-25 10:45 ` Arnd Bergmann 2014-09-25 10:45 ` Arnd Bergmann 2014-09-25 10:45 ` Arnd Bergmann 2014-09-24 15:37 ` [PATCH 6/6] pci, thunder: Enable Cavium Thunder PCIe host controller Robert Richter 2014-09-24 15:37 ` Robert Richter 2014-09-24 17:12 ` Catalin Marinas 2014-09-24 17:12 ` Catalin Marinas 2014-09-24 17:12 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20140924164946.GI16244@arm.com \ --to=will.deacon@arm.com \ --cc=Liviu.Dudau@arm.com \ --cc=arnd@arndb.de \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=grant.likely@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=rric@kernel.org \ --cc=rrichter@cavium.com \ --cc=sgoutham@cavium.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.