Re: [PATCH 1/2] of: Allow selection of OF_DYNAMIC and OF_OVERLAY if OF_UNITTEST

[Grant Likely <grant.likely@linaro.org>]

On Fri, 23 Jan 2015 17:10:04 +0100
, Geert Uytterhoeven <geert+renesas@glider.be>
 wrote:
> Currently OF_DYNAMIC and OF_OVERLAY are not visible to the user, and are
> selected automatically only when needed.
> 
> Allow them to be enabled manually to improve device tree unit test
> coverage.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I like the change. Merged, thanks.

g.

> ---
>  drivers/of/Kconfig | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 38d1c51f58b108db..e9301686493933cc 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -34,7 +34,11 @@ config OF_PROMTREE
>  # Hardly any platforms need this.  It is safe to select, but only do so if you
>  # need it.
>  config OF_DYNAMIC
> -	bool
> +	bool "Support for dynamic device trees" if OF_UNITTEST
> +	help
> +	  On some platforms, the device tree can be manipulated at runtime.
> +	  While this option is selected automatically on such platforms, you
> +	  can enable it manually to improve device tree unit test coverage.
>  
>  config OF_ADDRESS
>  	def_bool y
> @@ -84,9 +88,14 @@ config OF_RESOLVE
>  	bool
>  
>  config OF_OVERLAY
> -	bool
> +	bool "Support for device tree overlays" if OF_UNITTEST
>  	depends on OF
>  	select OF_DYNAMIC
>  	select OF_RESOLVE
> +	help
> +	  Overlays are a method to dynamically modify part of the kernel's
> +	  device tree with dynamically loaded data.
> +	  While this option is selected automatically when needed, you can
> +	  enable it manually to improve device tree unit test coverage.
>  
>  endmenu # OF
> -- 
> 1.9.1
>