From: Boris Brezillon <boris.brezillon@free-electrons.com> To: Paul Bolle <pebolle@tiscali.nl> Cc: Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>, linux-crypto@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, devicetree@vger.kernel.org, Tawfik Bayouk <tawfik@marvell.com>, Lior Amsalem <alior@marvell.com>, Nadav Haklai <nadavh@marvell.com>, Eran Ben-Avi <benavi@marvell.com>, Thomas Petazzoni <info@free-electrons.com>, Gregory CLEMENT <gregory.clement@free-electrons.com>, Jason Cooper <jason@lakedaemon.net>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Andrew Lunn <andrew@lunn.ch>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Arnaud Ebalard <arno@natisbad.org> Subject: Re: [PATCH 1/2] crypto: add new driver for Marvell CESA Date: Fri, 10 Apr 2015 13:17:08 +0200 [thread overview] Message-ID: <20150410131708.258b0a99@bbrezillon> (raw) In-Reply-To: <1428662339.17822.18.camel@x220> Hi Paul, On Fri, 10 Apr 2015 12:38:59 +0200 Paul Bolle <pebolle@tiscali.nl> wrote: > (This patch needed a trivial context change in drivers/crypto/Makefile > to get it applied on top of next-20150409.) I'll rebase my work on linux-next. > > On Thu, 2015-04-09 at 16:58 +0200, Boris Brezillon wrote: > > --- a/drivers/crypto/Kconfig > > +++ b/drivers/crypto/Kconfig > > @@ -164,8 +164,10 @@ config CRYPTO_DEV_MV_CESA > > depends on PLAT_ORION > > select CRYPTO_ALGAPI > > select CRYPTO_AES > > + select CRYPTO_DES > > select CRYPTO_BLKCIPHER2 > > select CRYPTO_HASH > > + select SRAM > > help > > This driver allows you to utilize the Cryptographic Engines and > > Security Accelerator (CESA) which can be found on the Marvell Orion > > > --- a/drivers/crypto/Makefile > > +++ b/drivers/crypto/Makefile > > > -obj-$(CONFIG_CRYPTO_DEV_MV_CESA) += mv_cesa.o > > +obj-$(CONFIG_CRYPTO_DEV_MV_CESA) += marvell/ > > > --- /dev/null > > +++ b/drivers/crypto/marvell/Makefile > > @@ -0,0 +1 @@ > > +obj-$(CONFIG_CRYPTO_DEV_MV_CESA) += cesa.o cipher.o hash.o tdma.o > > For a modular build (which is all I tried) this doesn't do what you > probably want, as this will generate four modules. Assuming you want to > keep the mv_cesa name for the module, you could try something like: > obj-$(CONFIG_CRYPTO_DEV_MV_CESA) += mv_cesa.o > mv_cesa-objs := cesa.o cipher.o hash.o tdma.o > > Does that do what you want? Yes, I'll fix that in v2. > > > --- /dev/null > > +++ b/drivers/crypto/marvell/cesa.c > > > + * This program is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU General Public License version 2 as published > > + * by the Free Software Foundation. > > This states the license is GPL v2. > > > +static struct platform_driver marvell_cesa = { > > + .probe = mv_cesa_probe, > > + .remove = mv_cesa_remove, > > + .driver = { > > + .owner = THIS_MODULE, > > + .name = "mv_crypto", > > + .of_match_table = mv_cesa_of_match_table, > > + }, > > +}; > > +MODULE_ALIAS("platform:mv_crypto"); > > (It's nicer to make that macro be a part of the block of the other > MODULE_ macros.) > > > +module_platform_driver(marvell_cesa); > > (And it's nicer to have this directly follow the definition of > marvell_cesa.) Absolutely. > > > +MODULE_AUTHOR("Boris Brezillon <boris.brezillon@free-electrons.com>"); > > +MODULE_AUTHOR("Arnaud Ebalard <arno@natisbad.org>"); > > +MODULE_DESCRIPTION("Support for Marvell's cryptographic engine"); > > +MODULE_LICENSE("GPL"); > > And this states the license is GPL v2 or later. So either the comment at > the top of this file or this macro need to be changed. I'll change the MODULE_LICENSE definition. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] crypto: add new driver for Marvell CESA Date: Fri, 10 Apr 2015 13:17:08 +0200 [thread overview] Message-ID: <20150410131708.258b0a99@bbrezillon> (raw) In-Reply-To: <1428662339.17822.18.camel@x220> Hi Paul, On Fri, 10 Apr 2015 12:38:59 +0200 Paul Bolle <pebolle@tiscali.nl> wrote: > (This patch needed a trivial context change in drivers/crypto/Makefile > to get it applied on top of next-20150409.) I'll rebase my work on linux-next. > > On Thu, 2015-04-09 at 16:58 +0200, Boris Brezillon wrote: > > --- a/drivers/crypto/Kconfig > > +++ b/drivers/crypto/Kconfig > > @@ -164,8 +164,10 @@ config CRYPTO_DEV_MV_CESA > > depends on PLAT_ORION > > select CRYPTO_ALGAPI > > select CRYPTO_AES > > + select CRYPTO_DES > > select CRYPTO_BLKCIPHER2 > > select CRYPTO_HASH > > + select SRAM > > help > > This driver allows you to utilize the Cryptographic Engines and > > Security Accelerator (CESA) which can be found on the Marvell Orion > > > --- a/drivers/crypto/Makefile > > +++ b/drivers/crypto/Makefile > > > -obj-$(CONFIG_CRYPTO_DEV_MV_CESA) += mv_cesa.o > > +obj-$(CONFIG_CRYPTO_DEV_MV_CESA) += marvell/ > > > --- /dev/null > > +++ b/drivers/crypto/marvell/Makefile > > @@ -0,0 +1 @@ > > +obj-$(CONFIG_CRYPTO_DEV_MV_CESA) += cesa.o cipher.o hash.o tdma.o > > For a modular build (which is all I tried) this doesn't do what you > probably want, as this will generate four modules. Assuming you want to > keep the mv_cesa name for the module, you could try something like: > obj-$(CONFIG_CRYPTO_DEV_MV_CESA) += mv_cesa.o > mv_cesa-objs := cesa.o cipher.o hash.o tdma.o > > Does that do what you want? Yes, I'll fix that in v2. > > > --- /dev/null > > +++ b/drivers/crypto/marvell/cesa.c > > > + * This program is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU General Public License version 2 as published > > + * by the Free Software Foundation. > > This states the license is GPL v2. > > > +static struct platform_driver marvell_cesa = { > > + .probe = mv_cesa_probe, > > + .remove = mv_cesa_remove, > > + .driver = { > > + .owner = THIS_MODULE, > > + .name = "mv_crypto", > > + .of_match_table = mv_cesa_of_match_table, > > + }, > > +}; > > +MODULE_ALIAS("platform:mv_crypto"); > > (It's nicer to make that macro be a part of the block of the other > MODULE_ macros.) > > > +module_platform_driver(marvell_cesa); > > (And it's nicer to have this directly follow the definition of > marvell_cesa.) Absolutely. > > > +MODULE_AUTHOR("Boris Brezillon <boris.brezillon@free-electrons.com>"); > > +MODULE_AUTHOR("Arnaud Ebalard <arno@natisbad.org>"); > > +MODULE_DESCRIPTION("Support for Marvell's cryptographic engine"); > > +MODULE_LICENSE("GPL"); > > And this states the license is GPL v2 or later. So either the comment at > the top of this file or this macro need to be changed. I'll change the MODULE_LICENSE definition. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
next prev parent reply other threads:[~2015-04-10 11:17 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-09 14:58 [PATCH 0/2] crypto: add new driver for Marvell CESA Boris Brezillon 2015-04-09 14:58 ` Boris Brezillon 2015-04-09 14:58 ` [PATCH 1/2] " Boris Brezillon [not found] ` <1428591523-1780-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2015-04-10 10:38 ` Paul Bolle 2015-04-10 10:38 ` Paul Bolle 2015-04-10 10:38 ` Paul Bolle 2015-04-10 11:17 ` Boris Brezillon [this message] 2015-04-10 11:17 ` Boris Brezillon 2015-04-09 14:58 ` [PATCH 2/2] crypto: marvell/CESA: update DT bindings documentation Boris Brezillon 2015-04-09 14:58 ` Boris Brezillon 2015-04-09 15:18 ` [PATCH 0/2] crypto: add new driver for Marvell CESA Andrew Lunn 2015-04-09 15:18 ` Andrew Lunn [not found] ` <20150409172826.18916274@bbrezillon> 2015-04-09 15:37 ` Andrew Lunn 2015-04-09 15:37 ` Andrew Lunn 2015-04-09 15:37 ` Andrew Lunn 2015-04-09 15:37 ` Andrew Lunn 2015-04-09 15:34 ` Sebastian Hesselbarth 2015-04-09 15:34 ` Sebastian Hesselbarth 2015-04-09 15:57 ` Boris Brezillon 2015-04-09 15:57 ` Boris Brezillon 2015-04-09 23:21 ` Arnaud Ebalard 2015-04-09 23:21 ` Arnaud Ebalard 2015-04-09 23:21 ` Arnaud Ebalard 2015-04-09 15:52 ` Stephan Mueller 2015-04-09 15:52 ` Stephan Mueller 2015-04-10 13:50 ` Jason Cooper 2015-04-10 13:50 ` Jason Cooper 2015-04-10 15:11 ` Boris Brezillon 2015-04-10 15:11 ` Boris Brezillon 2015-04-10 22:30 ` Jason Cooper 2015-04-10 22:30 ` Jason Cooper 2015-04-13 9:39 ` Gregory CLEMENT 2015-04-13 9:39 ` Gregory CLEMENT 2015-04-13 12:47 ` Jason Cooper 2015-04-13 12:47 ` Jason Cooper 2015-04-13 16:06 ` Arnaud Ebalard 2015-04-13 16:06 ` Arnaud Ebalard 2015-04-13 20:11 ` Jason Cooper 2015-04-13 20:11 ` Jason Cooper 2015-04-17 8:33 ` Boris Brezillon 2015-04-17 8:33 ` Boris Brezillon 2015-04-17 8:39 ` Boris Brezillon 2015-04-17 8:39 ` Boris Brezillon 2015-04-17 10:59 ` Jason Cooper 2015-04-17 10:59 ` Jason Cooper 2015-04-17 13:01 ` Gregory CLEMENT 2015-04-17 13:01 ` Gregory CLEMENT 2015-04-17 14:19 ` Boris Brezillon 2015-04-17 14:19 ` Boris Brezillon 2015-04-17 14:32 ` Maxime Ripard 2015-04-17 14:32 ` Maxime Ripard 2015-04-17 14:40 ` Gregory CLEMENT 2015-04-17 14:40 ` Gregory CLEMENT 2015-04-17 14:50 ` Maxime Ripard 2015-04-17 14:50 ` Maxime Ripard 2015-04-17 15:01 ` Gregory CLEMENT 2015-04-17 15:01 ` Gregory CLEMENT 2015-04-17 15:01 ` Gregory CLEMENT 2015-04-17 15:49 ` Maxime Ripard 2015-04-17 15:49 ` Maxime Ripard 2015-04-17 16:04 ` Gregory CLEMENT 2015-04-17 16:04 ` Gregory CLEMENT 2015-04-17 16:04 ` Gregory CLEMENT 2015-04-28 19:52 ` Boris Brezillon 2015-04-28 19:52 ` Boris Brezillon 2015-04-29 9:49 ` Herbert Xu 2015-04-29 9:49 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150410131708.258b0a99@bbrezillon \ --to=boris.brezillon@free-electrons.com \ --cc=alior@marvell.com \ --cc=andrew@lunn.ch \ --cc=arno@natisbad.org \ --cc=benavi@marvell.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=gregory.clement@free-electrons.com \ --cc=herbert@gondor.apana.org.au \ --cc=ijc+devicetree@hellion.org.uk \ --cc=info@free-electrons.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=nadavh@marvell.com \ --cc=pawel.moll@arm.com \ --cc=pebolle@tiscali.nl \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=tawfik@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.