Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>,
	Arnaud Ebalard <arno@natisbad.org>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Thomas Petazzoni <info@free-electrons.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Eran Ben-Avi <benavi@marvell.com>,
	Nadav Haklai <nadavh@marvell.com>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	linux-crypto@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
	Tawfik Bayouk <tawfik@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Lior Amsalem <alior@marvell.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 0/2] crypto: add new driver for Marvell CESA
Date: Fri, 17 Apr 2015 10:39:46 +0200	[thread overview]
Message-ID: <20150417103946.2a46c243@bbrezillon> (raw)
In-Reply-To: <20150417103356.6ce78145@bbrezillon>

On Fri, 17 Apr 2015 10:33:56 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> Hi Jason,
> 
> On Mon, 13 Apr 2015 20:11:46 +0000
> Jason Cooper <jason@lakedaemon.net> wrote:
> 
> > > 
> > > > I'd appreciate if we'd look into it.  I understand from on-list and
> > > > off-list discussion that the rewrite was unavoidable.  So I'm willing to
> > > > concede that.  Giving people time to migrate from old to new while still
> > > > being able to update for other security fixes seems reasonable.
> > > 
> > > Jason, what do you think of the approach above? 
> > 
> > I say keep it simple.  We shouldn't use the DT changes to trigger one
> > vice the other.  We need to be able to build both, but only load one at
> > a time.  If that's anything other than simple to do, then we make it a
> > Kconfig binary choice and move on.
> 
> Actually I was planning to handle it with a Kconfig dependency rule
> (NEW_DRIVER depends on !OLD_DRIVER and OLD_DRIVER depends
> on !NEW_DRIVER).
> I don't know how to make it a runtime check without adding new
> compatible strings for the kirkwood, dove and orion platforms, and I'm
> sure sure this is a good idea.
  ^ not

> Do you have any ideas ?
> 
> Regards,
> 
> Boris
> 
> 


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com