Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe

From: Johan Hovold <johan@kernel.org>
To: Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>
Cc: Johan Hovold <johan@kernel.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Milo Kim <milo.kim@ti.com>,
	patches@opensource.wolfsonmicro.com,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe
Date: Tue, 14 Apr 2015 15:04:06 +0200	[thread overview]
Message-ID: <20150414130406.GA26326@localhost> (raw)
In-Reply-To: <20150326083209.GE5951@x1>

Hi Mark and Lee,

On Thu, Mar 26, 2015 at 08:32:09AM +0000, Lee Jones wrote:
> On Wed, 25 Mar 2015, Johan Hovold wrote:
> 
> > Fix broken probe of da9052 regulators, which since commit b3f6c73db732
> > ("mfd: da9052-core: Fix platform-device id collision") use a
> > non-deterministic platform-device id to retrieve static regulator
> > information. Fortunately, adequate error handling was in place so probe
> > would simply fail with an error message.
> > 
> > Update the mfd-cell ids to be zero-based and use those to identify the
> > cells when probing the regulator devices.
> > 
> > Fixes: b3f6c73db732 ("mfd: da9052-core: Fix platform-device id collision")
> > Cc: stable <stable@vger.kernel.org>	# v3.19
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> >  drivers/mfd/da9052-core.c            | 8 ++++----
> >  drivers/regulator/da9052-regulator.c | 5 +++--
> 
> Need an Ack from Mark, but looks good to me.
> 
> Acked-by: Lee Jones <lee.jones@linaro.org>

Mark, did you have a chance to look at this one?

It fixes a regression due to an mfd commit, but not sure who of you that
wants to take it.

Thanks,
Johan