Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe

From: Lee Jones <lee.jones@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	Support Opensource <support.opensource@diasemi.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Milo Kim <milo.kim@ti.com>,
	patches@opensource.wolfsonmicro.com,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: da9052: fix broken regulator probe
Date: Mon, 18 May 2015 10:10:49 +0100	[thread overview]
Message-ID: <20150518091049.GN22418@x1> (raw)
In-Reply-To: <20150515144739.GC13976@localhost>

On Fri, 15 May 2015, Johan Hovold wrote:
> On Thu, May 14, 2015 at 08:19:43AM +0100, Lee Jones wrote:
> > On Wed, 13 May 2015, Mark Brown wrote:
> > 
> > > On Wed, May 13, 2015 at 05:54:19PM +0100, Lee Jones wrote:
> > > > On Wed, 13 May 2015, Mark Brown wrote:
> > > 
> > > > > If you're looking for me to review something you need to send it to me,
> > > > > and the chances of me looking at it are very much increased if there's a
> > > > > relevant subject line.  I'm CCed (not even on the to list) on endless
> > > > > large threads and reposts of patch serieses about MFD drivers most of
> > > > > which are of very little relevance to me so they get ignored very
> > > > > easily.
> > > 
> > > > Calm down dear, it's only a commercial.
> > > 
> > > > I wasn't having a pop.  Rather empathising with your situation and
> > > > facilitating a resend that you're likely to see.
> > > 
> > > > I'm sure Johan will do the right thing.
> > > 
> > > My point is that a simple resend has a reasonable chance of getting
> > > dropped on the floor.
> > 
> > As I say, I'm sure Johan will do what's required for that not to
> > happen.
> 
> Seriously? *Me* do the right thing?

Yes, *you*.  If a patch slips though a Maintainer's net, which does
happen every so often [*], I'm sure even you are not infallible to
that, a submitter must issue a RESEND (as you have now just done so).

> We have a regression in your subsystems (mfd/regulator) with a fix
> that's been sitting in both your mailboxes since March 25th.

Fully aware and ready to apply once the correct process has been
carried out.  I get shirty when people submit MFD patches without
permission, and I refuse to be a hypocrite.

> And now that Mark finally responds to a mail after repeated reminders
> from both me and Lee, he still doesn't care enough to look up the
> original mail or at least make sure that a resend does not get lost
> again.

See [*] about how Mark deals with his torrent of daily mail.

> You two even work for the same organisation. 

Irrelevant.

> Just pick up the phone or
> find a way to get a message across that mail filter instead of wasting
> everyone else's time.
> 
> I have resent the patch now. Please make sure it gets applied.

[*] Especially when you receive as much email as Mark does.  To cope
he has a brain-highpass-filter on the subject line and purges his
inbox regularly.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog