All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
To: Trond Myklebust
	<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
Cc: Eric Dumazet
	<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Anna Schumaker
	<anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
	Linux NFS Mailing List
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux Network Devel Mailing List
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )
Date: Thu, 18 Jun 2015 15:49:14 -0400	[thread overview]
Message-ID: <20150618154914.57424225@gandalf.local.home> (raw)
In-Reply-To: <CAHQdGtQfF8sgfj6B2H=Sg+mn6ghPD+4UuZMSMFjj3XCVee60pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]

On Thu, 18 Jun 2015 15:24:52 -0400
Trond Myklebust <trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org> wrote:

> On Wed, Jun 17, 2015 at 11:08 PM, Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> wrote:
> > On Fri, 12 Jun 2015 11:50:38 -0400
> > Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> wrote:
> >
> >> I reverted the following commits:
> >>
> >> c627d31ba0696cbd829437af2be2f2dee3546b1e
> >> 9e2b9f37760e129cee053cc7b6e7288acc2a7134
> >> caf4ccd4e88cf2795c927834bc488c8321437586
> >>
> >> And the issue goes away. That is, I watched the port go from
> >> ESTABLISHED to TIME_WAIT, and then gone, and theirs no hidden port.
> >>
> >> In fact, I watched the port with my portlist.c module, and it
> >> disappeared there too when it entered the TIME_WAIT state.
> >>
> 
> I've scanned those commits again and again, and I'm not seeing how we
> could be introducing a socket leak there. The only suspect I can see
> would be the NFS swap bugs that Jeff fixed a few weeks ago. Are you
> using NFS swap?

Not that I'm aware of.

> 
> > I've been running v4.0.5 with the above commits reverted for 5 days
> > now, and there's still no hidden port appearing.
> >
> > What's the status on this? Should those commits be reverted or is there
> > another solution to this bug?
> >
> 
> I'm trying to reproduce, but I've had no luck yet.

It seems to happen with the connection to my wife's machine, and that
is where my wife's box connects two directories via nfs:

This is what's in my wife's /etc/fstab directory

goliath:/home/upload     /upload         nfs     auto,rw,intr,soft       0 0
goliath:/home/gallery    /gallery        nfs     auto,ro,intr,soft	 0 0

And here's what's in my /etc/exports directory

/home/upload       wife(no_root_squash,no_all_squash,rw,sync,no_subtree_check)
/home/gallery      192.168.23.0/24(ro,sync,no_subtree_check)

Attached is my config.

-- Steve



[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40609 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Linux Network Devel Mailing List <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )
Date: Thu, 18 Jun 2015 15:49:14 -0400	[thread overview]
Message-ID: <20150618154914.57424225@gandalf.local.home> (raw)
In-Reply-To: <CAHQdGtQfF8sgfj6B2H=Sg+mn6ghPD+4UuZMSMFjj3XCVee60pw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]

On Thu, 18 Jun 2015 15:24:52 -0400
Trond Myklebust <trond.myklebust@primarydata.com> wrote:

> On Wed, Jun 17, 2015 at 11:08 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Fri, 12 Jun 2015 11:50:38 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >> I reverted the following commits:
> >>
> >> c627d31ba0696cbd829437af2be2f2dee3546b1e
> >> 9e2b9f37760e129cee053cc7b6e7288acc2a7134
> >> caf4ccd4e88cf2795c927834bc488c8321437586
> >>
> >> And the issue goes away. That is, I watched the port go from
> >> ESTABLISHED to TIME_WAIT, and then gone, and theirs no hidden port.
> >>
> >> In fact, I watched the port with my portlist.c module, and it
> >> disappeared there too when it entered the TIME_WAIT state.
> >>
> 
> I've scanned those commits again and again, and I'm not seeing how we
> could be introducing a socket leak there. The only suspect I can see
> would be the NFS swap bugs that Jeff fixed a few weeks ago. Are you
> using NFS swap?

Not that I'm aware of.

> 
> > I've been running v4.0.5 with the above commits reverted for 5 days
> > now, and there's still no hidden port appearing.
> >
> > What's the status on this? Should those commits be reverted or is there
> > another solution to this bug?
> >
> 
> I'm trying to reproduce, but I've had no luck yet.

It seems to happen with the connection to my wife's machine, and that
is where my wife's box connects two directories via nfs:

This is what's in my wife's /etc/fstab directory

goliath:/home/upload     /upload         nfs     auto,rw,intr,soft       0 0
goliath:/home/gallery    /gallery        nfs     auto,ro,intr,soft	 0 0

And here's what's in my /etc/exports directory

/home/upload       wife(no_root_squash,no_all_squash,rw,sync,no_subtree_check)
/home/gallery      192.168.23.0/24(ro,sync,no_subtree_check)

Attached is my config.

-- Steve



[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40609 bytes --]

  parent reply	other threads:[~2015-06-18 19:49 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  3:49 [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ) Steven Rostedt
2015-06-12 14:10 ` Trond Myklebust
     [not found]   ` <CAHQdGtSyHtMfyVxT=hFY4m6XvM=3mxnZ=ajVJWYNXvYqE0+3zA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-12 14:40     ` Eric Dumazet
2015-06-12 14:40       ` Eric Dumazet
2015-06-12 14:57       ` Trond Myklebust
     [not found]         ` <CAHQdGtROSzCUWaFobiEPPb2TZwduoARaHQ7viQC=XhjzyXGtrQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-12 15:43           ` Eric Dumazet
2015-06-12 15:43             ` Eric Dumazet
     [not found]       ` <1434120035.27504.77.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-06-12 15:34         ` Steven Rostedt
2015-06-12 15:34           ` Steven Rostedt
     [not found]           ` <20150612113420.5c114183-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-06-12 15:50             ` Steven Rostedt
2015-06-12 15:50               ` Steven Rostedt
2015-06-12 15:53               ` Steven Rostedt
     [not found]               ` <20150612115038.44e20ccd-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-06-18  3:08                 ` Steven Rostedt
2015-06-18  3:08                   ` Steven Rostedt
     [not found]                   ` <20150617230819.0a11e47a-2kNGR76GQU9OHLTnHDQRgA@public.gmane.org>
2015-06-18 19:24                     ` Trond Myklebust
2015-06-18 19:24                       ` Trond Myklebust
     [not found]                       ` <CAHQdGtQfF8sgfj6B2H=Sg+mn6ghPD+4UuZMSMFjj3XCVee60pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-18 19:49                         ` Steven Rostedt [this message]
2015-06-18 19:49                           ` Steven Rostedt
     [not found]                           ` <20150618154914.57424225-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-06-18 22:50                             ` Jeff Layton
2015-06-18 22:50                               ` Jeff Layton
     [not found]                               ` <20150618185051.2b2828c3-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2015-06-19  1:08                                 ` Steven Rostedt
2015-06-19  1:08                                   ` Steven Rostedt
2015-06-19  1:37                                   ` Jeff Layton
     [not found]                                     ` <20150618213702.33f64b20-08S845evdOaAjSkqwZiSMmfYqLom42DlXqFh9Ls21Oc@public.gmane.org>
2015-06-19  3:21                                       ` Steven Rostedt
2015-06-19  3:21                                         ` Steven Rostedt
2015-06-19 16:25                                     ` Steven Rostedt
     [not found]                                       ` <20150619122553.43d2d86c-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-06-19 17:17                                         ` Steven Rostedt
2015-06-19 17:17                                           ` Steven Rostedt
2015-06-19 17:17                                           ` Steven Rostedt
2015-06-19 17:39                                           ` Trond Myklebust
2015-06-19 17:39                                             ` Trond Myklebust
2015-06-19 17:39                                             ` Trond Myklebust
     [not found]                                             ` <CAHQdGtRCYoeToxyDHjnd+6f40J8SrScmQKKOW5O8AzJo3NefAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-19 19:52                                               ` Jeff Layton
2015-06-19 19:52                                                 ` Jeff Layton
2015-06-19 19:52                                                 ` Jeff Layton
     [not found]                                                 ` <20150619155226.7c5d6637-08S845evdOaAjSkqwZiSMmfYqLom42DlXqFh9Ls21Oc@public.gmane.org>
2015-06-19 20:30                                                   ` Trond Myklebust
2015-06-19 20:30                                                     ` Trond Myklebust
2015-06-19 20:30                                                     ` Trond Myklebust
     [not found]                                                     ` <1434745818.8838.1.camel-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2015-06-19 21:56                                                       ` Steven Rostedt
2015-06-19 21:56                                                         ` Steven Rostedt
2015-06-19 21:56                                                         ` Steven Rostedt
2015-06-19 22:14                                                       ` Steven Rostedt
2015-06-19 22:14                                                         ` Steven Rostedt
2015-06-19 22:14                                                         ` Steven Rostedt
     [not found]                                                         ` <20150619181440.22f54e6a-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-06-19 23:25                                                           ` Trond Myklebust
2015-06-19 23:25                                                             ` Trond Myklebust
2015-06-19 23:25                                                             ` Trond Myklebust
     [not found]                                                             ` <1434756359.8498.2.camel-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2015-06-20  0:37                                                               ` Steven Rostedt
2015-06-20  0:37                                                                 ` Steven Rostedt
2015-06-20  0:37                                                                 ` Steven Rostedt
2015-06-20  0:50                                                                 ` Steven Rostedt
2015-06-20  0:50                                                                   ` Steven Rostedt
2015-06-20  0:50                                                                   ` Steven Rostedt
2015-06-20  1:27                                                               ` Steven Rostedt
2015-06-20  1:27                                                                 ` Steven Rostedt
2015-06-20  1:27                                                                 ` Steven Rostedt
     [not found]                                                                 ` <20150619212706.2f13a44e-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-06-20  2:44                                                                   ` Trond Myklebust
2015-06-20  2:44                                                                     ` Trond Myklebust
2015-06-20  2:44                                                                     ` Trond Myklebust
2016-06-22 16:41                                                                 ` It's back! (Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )) Steven Rostedt
2015-06-19 21:50                                               ` [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ) Steven Rostedt
2015-06-19 21:50                                                 ` Steven Rostedt
2015-06-19 21:50                                                 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150618154914.57424225@gandalf.local.home \
    --to=rostedt-nx8x9ylhiw1afugrpc6u6w@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
    --cc=eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.