All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jeff Layton <jlayton@poochiereds.net>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Linux Network Devel Mailing List <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Bruce James Fields <bfields@fieldses.org>
Subject: Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )
Date: Fri, 19 Jun 2015 22:44:29 -0400	[thread overview]
Message-ID: <CAHQdGtQWx8udzG6VT8NwX5eWoDgnfyx7B-n-+75kakXf=a-F1g@mail.gmail.com> (raw)
In-Reply-To: <20150619212706.2f13a44e@gandalf.local.home>

On Fri, Jun 19, 2015 at 9:27 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 19 Jun 2015 19:25:59 -0400
> Trond Myklebust <trond.myklebust@primarydata.com> wrote:
>
>
>> 8<--------------------------------------------------------------
>> >From 4876cc779ff525b9c2376d8076edf47815e71f2c Mon Sep 17 00:00:00 2001
>> From: Trond Myklebust <trond.myklebust@primarydata.com>
>> Date: Fri, 19 Jun 2015 16:17:57 -0400
>> Subject: [PATCH v2] SUNRPC: Ensure we release the TCP socket once it has been
>>  closed
>>
>> This fixes a regression introduced by commit caf4ccd4e88cf2 ("SUNRPC:
>> Make xs_tcp_close() do a socket shutdown rather than a sock_release").
>> Prior to that commit, the autoclose feature would ensure that an
>> idle connection would result in the socket being both disconnected and
>> released, whereas now only gets disconnected.
>>
>> While the current behaviour is harmless, it does leave the port bound
>> until either RPC traffic resumes or the RPC client is shut down.
>
> Is there a way to test RPC traffic resuming? I'd like to try that before
> declaring this bug harmless.

You should be seeing the same issue if you mount an NFSv3 partition.
After about 5 minutes of inactivity, the client will close down the
connection to the server, and rkhunter should again see the phantom
socket. If you then try to access the partition, the RPC layer should
immediately release the socket and establish a new connection on the
same port.

Cheers
  Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
To: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
Cc: Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>,
	Eric Dumazet
	<eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Anna Schumaker
	<anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
	Linux NFS Mailing List
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux Network Devel Mailing List
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Bruce James Fields
	<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
Subject: Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )
Date: Fri, 19 Jun 2015 22:44:29 -0400	[thread overview]
Message-ID: <CAHQdGtQWx8udzG6VT8NwX5eWoDgnfyx7B-n-+75kakXf=a-F1g@mail.gmail.com> (raw)
In-Reply-To: <20150619212706.2f13a44e-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>

On Fri, Jun 19, 2015 at 9:27 PM, Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> wrote:
> On Fri, 19 Jun 2015 19:25:59 -0400
> Trond Myklebust <trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org> wrote:
>
>
>> 8<--------------------------------------------------------------
>> >From 4876cc779ff525b9c2376d8076edf47815e71f2c Mon Sep 17 00:00:00 2001
>> From: Trond Myklebust <trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
>> Date: Fri, 19 Jun 2015 16:17:57 -0400
>> Subject: [PATCH v2] SUNRPC: Ensure we release the TCP socket once it has been
>>  closed
>>
>> This fixes a regression introduced by commit caf4ccd4e88cf2 ("SUNRPC:
>> Make xs_tcp_close() do a socket shutdown rather than a sock_release").
>> Prior to that commit, the autoclose feature would ensure that an
>> idle connection would result in the socket being both disconnected and
>> released, whereas now only gets disconnected.
>>
>> While the current behaviour is harmless, it does leave the port bound
>> until either RPC traffic resumes or the RPC client is shut down.
>
> Is there a way to test RPC traffic resuming? I'd like to try that before
> declaring this bug harmless.

You should be seeing the same issue if you mount an NFSv3 partition.
After about 5 minutes of inactivity, the client will close down the
connection to the server, and rkhunter should again see the phantom
socket. If you then try to access the partition, the RPC layer should
immediately release the socket and establish a new connection on the
same port.

Cheers
  Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in

WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jeff Layton <jlayton@poochiereds.net>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Linux Network Devel Mailing List <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Bruce James Fields <bfields@fieldses.org>
Subject: Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )
Date: Fri, 19 Jun 2015 22:44:29 -0400	[thread overview]
Message-ID: <CAHQdGtQWx8udzG6VT8NwX5eWoDgnfyx7B-n-+75kakXf=a-F1g@mail.gmail.com> (raw)
In-Reply-To: <20150619212706.2f13a44e@gandalf.local.home>

On Fri, Jun 19, 2015 at 9:27 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 19 Jun 2015 19:25:59 -0400
> Trond Myklebust <trond.myklebust@primarydata.com> wrote:
>
>
>> 8<--------------------------------------------------------------
>> >From 4876cc779ff525b9c2376d8076edf47815e71f2c Mon Sep 17 00:00:00 2001
>> From: Trond Myklebust <trond.myklebust@primarydata.com>
>> Date: Fri, 19 Jun 2015 16:17:57 -0400
>> Subject: [PATCH v2] SUNRPC: Ensure we release the TCP socket once it has been
>>  closed
>>
>> This fixes a regression introduced by commit caf4ccd4e88cf2 ("SUNRPC:
>> Make xs_tcp_close() do a socket shutdown rather than a sock_release").
>> Prior to that commit, the autoclose feature would ensure that an
>> idle connection would result in the socket being both disconnected and
>> released, whereas now only gets disconnected.
>>
>> While the current behaviour is harmless, it does leave the port bound
>> until either RPC traffic resumes or the RPC client is shut down.
>
> Is there a way to test RPC traffic resuming? I'd like to try that before
> declaring this bug harmless.

You should be seeing the same issue if you mount an NFSv3 partition.
After about 5 minutes of inactivity, the client will close down the
connection to the server, and rkhunter should again see the phantom
socket. If you then try to access the partition, the RPC layer should
immediately release the socket and establish a new connection on the
same port.

Cheers
  Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in

  reply	other threads:[~2015-06-20  2:44 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12  3:49 [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ) Steven Rostedt
2015-06-12 14:10 ` Trond Myklebust
2015-06-12 14:40   ` Eric Dumazet
2015-06-12 14:40     ` Eric Dumazet
2015-06-12 14:57     ` Trond Myklebust
2015-06-12 15:43       ` Eric Dumazet
2015-06-12 15:43         ` Eric Dumazet
2015-06-12 15:34     ` Steven Rostedt
2015-06-12 15:34       ` Steven Rostedt
2015-06-12 15:50       ` Steven Rostedt
2015-06-12 15:50         ` Steven Rostedt
2015-06-12 15:53         ` Steven Rostedt
2015-06-18  3:08         ` Steven Rostedt
2015-06-18  3:08           ` Steven Rostedt
2015-06-18 19:24           ` Trond Myklebust
2015-06-18 19:24             ` Trond Myklebust
2015-06-18 19:49             ` Steven Rostedt
2015-06-18 19:49               ` Steven Rostedt
2015-06-18 22:50               ` Jeff Layton
2015-06-18 22:50                 ` Jeff Layton
2015-06-19  1:08                 ` Steven Rostedt
2015-06-19  1:08                   ` Steven Rostedt
2015-06-19  1:37                   ` Jeff Layton
2015-06-19  3:21                     ` Steven Rostedt
2015-06-19  3:21                       ` Steven Rostedt
2015-06-19 16:25                     ` Steven Rostedt
2015-06-19 17:17                       ` Steven Rostedt
2015-06-19 17:17                         ` Steven Rostedt
2015-06-19 17:17                         ` Steven Rostedt
2015-06-19 17:39                         ` Trond Myklebust
2015-06-19 17:39                           ` Trond Myklebust
2015-06-19 17:39                           ` Trond Myklebust
2015-06-19 19:52                           ` Jeff Layton
2015-06-19 19:52                             ` Jeff Layton
2015-06-19 19:52                             ` Jeff Layton
2015-06-19 20:30                             ` Trond Myklebust
2015-06-19 20:30                               ` Trond Myklebust
2015-06-19 20:30                               ` Trond Myklebust
2015-06-19 21:56                               ` Steven Rostedt
2015-06-19 21:56                                 ` Steven Rostedt
2015-06-19 21:56                                 ` Steven Rostedt
2015-06-19 22:14                               ` Steven Rostedt
2015-06-19 22:14                                 ` Steven Rostedt
2015-06-19 22:14                                 ` Steven Rostedt
2015-06-19 23:25                                 ` Trond Myklebust
2015-06-19 23:25                                   ` Trond Myklebust
2015-06-19 23:25                                   ` Trond Myklebust
2015-06-20  0:37                                   ` Steven Rostedt
2015-06-20  0:37                                     ` Steven Rostedt
2015-06-20  0:37                                     ` Steven Rostedt
2015-06-20  0:50                                     ` Steven Rostedt
2015-06-20  0:50                                       ` Steven Rostedt
2015-06-20  0:50                                       ` Steven Rostedt
2015-06-20  1:27                                   ` Steven Rostedt
2015-06-20  1:27                                     ` Steven Rostedt
2015-06-20  1:27                                     ` Steven Rostedt
2015-06-20  2:44                                     ` Trond Myklebust [this message]
2015-06-20  2:44                                       ` Trond Myklebust
2015-06-20  2:44                                       ` Trond Myklebust
2016-06-22 16:41                                     ` It's back! (Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )) Steven Rostedt
2015-06-19 21:50                           ` [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ) Steven Rostedt
2015-06-19 21:50                             ` Steven Rostedt
2015-06-19 21:50                             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHQdGtQWx8udzG6VT8NwX5eWoDgnfyx7B-n-+75kakXf=a-F1g@mail.gmail.com' \
    --to=trond.myklebust@primarydata.com \
    --cc=akpm@linux-foundation.org \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=eric.dumazet@gmail.com \
    --cc=jlayton@poochiereds.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.