From: Trond Myklebust <trond.myklebust@primarydata.com> To: Steven Rostedt <rostedt@goodmis.org> Cc: Eric Dumazet <eric.dumazet@gmail.com>, Anna Schumaker <anna.schumaker@netapp.com>, Linux NFS Mailing List <linux-nfs@vger.kernel.org>, Linux Network Devel Mailing List <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ) Date: Thu, 18 Jun 2015 15:24:52 -0400 [thread overview] Message-ID: <CAHQdGtQfF8sgfj6B2H=Sg+mn6ghPD+4UuZMSMFjj3XCVee60pw@mail.gmail.com> (raw) In-Reply-To: <20150617230819.0a11e47a@grimm.local.home> On Wed, Jun 17, 2015 at 11:08 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > On Fri, 12 Jun 2015 11:50:38 -0400 > Steven Rostedt <rostedt@goodmis.org> wrote: > >> I reverted the following commits: >> >> c627d31ba0696cbd829437af2be2f2dee3546b1e >> 9e2b9f37760e129cee053cc7b6e7288acc2a7134 >> caf4ccd4e88cf2795c927834bc488c8321437586 >> >> And the issue goes away. That is, I watched the port go from >> ESTABLISHED to TIME_WAIT, and then gone, and theirs no hidden port. >> >> In fact, I watched the port with my portlist.c module, and it >> disappeared there too when it entered the TIME_WAIT state. >> I've scanned those commits again and again, and I'm not seeing how we could be introducing a socket leak there. The only suspect I can see would be the NFS swap bugs that Jeff fixed a few weeks ago. Are you using NFS swap? > I've been running v4.0.5 with the above commits reverted for 5 days > now, and there's still no hidden port appearing. > > What's the status on this? Should those commits be reverted or is there > another solution to this bug? > I'm trying to reproduce, but I've had no luck yet. Cheers Trond
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org> To: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> Cc: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Anna Schumaker <anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>, Linux NFS Mailing List <linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Network Devel Mailing List <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Subject: Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ) Date: Thu, 18 Jun 2015 15:24:52 -0400 [thread overview] Message-ID: <CAHQdGtQfF8sgfj6B2H=Sg+mn6ghPD+4UuZMSMFjj3XCVee60pw@mail.gmail.com> (raw) In-Reply-To: <20150617230819.0a11e47a-2kNGR76GQU9OHLTnHDQRgA@public.gmane.org> On Wed, Jun 17, 2015 at 11:08 PM, Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> wrote: > On Fri, 12 Jun 2015 11:50:38 -0400 > Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org> wrote: > >> I reverted the following commits: >> >> c627d31ba0696cbd829437af2be2f2dee3546b1e >> 9e2b9f37760e129cee053cc7b6e7288acc2a7134 >> caf4ccd4e88cf2795c927834bc488c8321437586 >> >> And the issue goes away. That is, I watched the port go from >> ESTABLISHED to TIME_WAIT, and then gone, and theirs no hidden port. >> >> In fact, I watched the port with my portlist.c module, and it >> disappeared there too when it entered the TIME_WAIT state. >> I've scanned those commits again and again, and I'm not seeing how we could be introducing a socket leak there. The only suspect I can see would be the NFS swap bugs that Jeff fixed a few weeks ago. Are you using NFS swap? > I've been running v4.0.5 with the above commits reverted for 5 days > now, and there's still no hidden port appearing. > > What's the status on this? Should those commits be reverted or is there > another solution to this bug? > I'm trying to reproduce, but I've had no luck yet. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-18 19:25 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-12 3:49 [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ) Steven Rostedt 2015-06-12 14:10 ` Trond Myklebust 2015-06-12 14:40 ` Eric Dumazet 2015-06-12 14:40 ` Eric Dumazet 2015-06-12 14:57 ` Trond Myklebust 2015-06-12 15:43 ` Eric Dumazet 2015-06-12 15:43 ` Eric Dumazet 2015-06-12 15:34 ` Steven Rostedt 2015-06-12 15:34 ` Steven Rostedt 2015-06-12 15:50 ` Steven Rostedt 2015-06-12 15:50 ` Steven Rostedt 2015-06-12 15:53 ` Steven Rostedt 2015-06-18 3:08 ` Steven Rostedt 2015-06-18 3:08 ` Steven Rostedt 2015-06-18 19:24 ` Trond Myklebust [this message] 2015-06-18 19:24 ` Trond Myklebust 2015-06-18 19:49 ` Steven Rostedt 2015-06-18 19:49 ` Steven Rostedt 2015-06-18 22:50 ` Jeff Layton 2015-06-18 22:50 ` Jeff Layton 2015-06-19 1:08 ` Steven Rostedt 2015-06-19 1:08 ` Steven Rostedt 2015-06-19 1:37 ` Jeff Layton 2015-06-19 3:21 ` Steven Rostedt 2015-06-19 3:21 ` Steven Rostedt 2015-06-19 16:25 ` Steven Rostedt 2015-06-19 17:17 ` Steven Rostedt 2015-06-19 17:17 ` Steven Rostedt 2015-06-19 17:17 ` Steven Rostedt 2015-06-19 17:39 ` Trond Myklebust 2015-06-19 17:39 ` Trond Myklebust 2015-06-19 17:39 ` Trond Myklebust 2015-06-19 19:52 ` Jeff Layton 2015-06-19 19:52 ` Jeff Layton 2015-06-19 19:52 ` Jeff Layton 2015-06-19 20:30 ` Trond Myklebust 2015-06-19 20:30 ` Trond Myklebust 2015-06-19 20:30 ` Trond Myklebust 2015-06-19 21:56 ` Steven Rostedt 2015-06-19 21:56 ` Steven Rostedt 2015-06-19 21:56 ` Steven Rostedt 2015-06-19 22:14 ` Steven Rostedt 2015-06-19 22:14 ` Steven Rostedt 2015-06-19 22:14 ` Steven Rostedt 2015-06-19 23:25 ` Trond Myklebust 2015-06-19 23:25 ` Trond Myklebust 2015-06-19 23:25 ` Trond Myklebust 2015-06-20 0:37 ` Steven Rostedt 2015-06-20 0:37 ` Steven Rostedt 2015-06-20 0:37 ` Steven Rostedt 2015-06-20 0:50 ` Steven Rostedt 2015-06-20 0:50 ` Steven Rostedt 2015-06-20 0:50 ` Steven Rostedt 2015-06-20 1:27 ` Steven Rostedt 2015-06-20 1:27 ` Steven Rostedt 2015-06-20 1:27 ` Steven Rostedt 2015-06-20 2:44 ` Trond Myklebust 2015-06-20 2:44 ` Trond Myklebust 2015-06-20 2:44 ` Trond Myklebust 2016-06-22 16:41 ` It's back! (Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )) Steven Rostedt 2015-06-19 21:50 ` [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ) Steven Rostedt 2015-06-19 21:50 ` Steven Rostedt 2015-06-19 21:50 ` Steven Rostedt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHQdGtQfF8sgfj6B2H=Sg+mn6ghPD+4UuZMSMFjj3XCVee60pw@mail.gmail.com' \ --to=trond.myklebust@primarydata.com \ --cc=akpm@linux-foundation.org \ --cc=anna.schumaker@netapp.com \ --cc=eric.dumazet@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.