Re: [PATCH v5] NET: Add ezchip ethernet driver

[David Miller <davem@davemloft.net>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=iso-8859-7, Size: 1718 bytes --]

From: Noam Camus <noamc@ezchip.com>
Date: Tue, 16 Jun 2015 17:35:42 +0300

> From: Noam Camus <noamc@ezchip.com>
> 
> Simple LAN device for debug or management purposes.
> Device supports interrupts for RX and TX(completion).
> Device does not have DMA ability.
> 
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> Signed-off-by: Tal Zilcer <talz@ezchip.com>
> Acked-by: Alexey Brodkin <abrodkin@synopsys.com>

This builds with several warnings and also doesn't compile.

drivers/net/ethernet/ezchip/nps_enet.c: In function ¡nps_enet_read_rx_fifo¢:
drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c: In function ¡nps_enet_send_frame¢:
drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
drivers/net/ethernet/ezchip/nps_enet.c: In function ¡nps_enet_poll_controller¢:
drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ¡nps_enet_board_irq_handler¢ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

I do not even see where npe_enet_board_irq_handler could possible be defined.

It is quite infuriating to receive a patch like this which is claimed
to be complete and ready to be applied to my tree, yet it is very
clearly not.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠsåy«\x1e­æ¶\x17…\x01\x06­†ÛiÿÿðÃ\x0fí»\x1fè®\x0få’i\x7f