All of lore.kernel.org
 help / color / mirror / Atom feed
From: Noam Camus <noamc@ezchip.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
	"vgupta@synopsys.com" <vgupta@synopsys.com>,
	Gilad Ben Yossef <giladb@ezchip.com>,
	Chris Metcalf <cmetcalf@ezchip.com>, Tal Zilcer <talz@ezchip.com>
Subject: RE: [PATCH v5] NET: Add ezchip ethernet driver
Date: Mon, 22 Jun 2015 14:52:48 +0000	[thread overview]
Message-ID: <DB4PR02MB272B2804219ED0AD76BA1B2D6A10@DB4PR02MB272.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <20150621.092218.2158342160706463595.davem@davemloft.net>

From: David Miller [mailto:davem@davemloft.net] 
Sent: Sunday, June 21, 2015 7:22 PM

> This builds with several warnings and also doesn't compile.
>
> drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_read_rx_fifo’:
> drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_send_frame’:
> drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Once I start to use newer GCC (5.1.1) I get those as well. My previous GCC (4.8) did not report them.

> drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_poll_controller’:
> drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ‘nps_enet_board_irq_handler’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
My configuration lacked the CONFIG_NET_POLL_CONTROLLER this is why I missed this typo caused due to renaming. I added CONFIG_NETCONSOLE to my configuration, now GCC report this error as well.

> I do not even see where npe_enet_board_irq_handler could possible be defined.
It was renamed: nps_enet_board_irq_handler -> nps_enet_irq_handler (I removed the _board).

> It is quite infuriating to receive a patch like this which is claimed to be complete and ready to be applied to my tree, yet it is very clearly not.
My sincerest apologies  for any problem I have made. I will send another version that will be worth applying to your tree.

Noam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

WARNING: multiple messages have this Message-ID (diff)
From: Noam Camus <noamc@ezchip.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
	"vgupta@synopsys.com" <vgupta@synopsys.com>,
	Gilad Ben Yossef <giladb@ezchip.com>,
	Chris Metcalf <cmetcalf@ezchip.com>, Tal Zilcer <talz@ezchip.com>
Subject: RE: [PATCH v5] NET: Add ezchip ethernet driver
Date: Mon, 22 Jun 2015 14:52:48 +0000	[thread overview]
Message-ID: <DB4PR02MB272B2804219ED0AD76BA1B2D6A10@DB4PR02MB272.eurprd02.prod.outlook.com> (raw)
In-Reply-To: <20150621.092218.2158342160706463595.davem@davemloft.net>

From: David Miller [mailto:davem@davemloft.net] 
Sent: Sunday, June 21, 2015 7:22 PM

> This builds with several warnings and also doesn't compile.
>
> drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_read_rx_fifo’:
> drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> drivers/net/ethernet/ezchip/nps_enet.c:43:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_send_frame’:
> drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> drivers/net/ethernet/ezchip/nps_enet.c:366:24: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Once I start to use newer GCC (5.1.1) I get those as well. My previous GCC (4.8) did not report them.

> drivers/net/ethernet/ezchip/nps_enet.c: In function ‘nps_enet_poll_controller’:
> drivers/net/ethernet/ezchip/nps_enet.c:535:2: error: implicit declaration of function ‘nps_enet_board_irq_handler’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
My configuration lacked the CONFIG_NET_POLL_CONTROLLER this is why I missed this typo caused due to renaming. I added CONFIG_NETCONSOLE to my configuration, now GCC report this error as well.

> I do not even see where npe_enet_board_irq_handler could possible be defined.
It was renamed: nps_enet_board_irq_handler -> nps_enet_irq_handler (I removed the _board).

> It is quite infuriating to receive a patch like this which is claimed to be complete and ready to be applied to my tree, yet it is very clearly not.
My sincerest apologies  for any problem I have made. I will send another version that will be worth applying to your tree.

Noam

  reply	other threads:[~2015-06-22 14:53 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 12:44 [PATCH] NET: Add ezchip ethernet driver Noam Camus
2015-06-09 14:11 ` Alexey Brodkin
2015-06-10  7:54 ` Paul Bolle
2015-06-11  8:33 ` [PATCH v2] " Noam Camus
2015-06-11 17:41   ` [PATCH v3] " Noam Camus
2015-06-14  6:26     ` [PATCH v4] " Noam Camus
2015-06-14 20:25       ` Florian Fainelli
2015-06-16 14:35       ` [PATCH v5] " Noam Camus
2015-06-21 16:22         ` David Miller
2015-06-21 16:22           ` David Miller
2015-06-22 14:52           ` Noam Camus [this message]
2015-06-22 14:52             ` Noam Camus
2015-06-22 17:45         ` Mahesh Bandewar
2015-06-22 17:45           ` Mahesh Bandewar
2015-06-22 23:47           ` Paul Gortmaker
2015-06-22 23:47             ` Paul Gortmaker
2015-06-23  6:05           ` Noam Camus
2015-06-23  6:05             ` Noam Camus
2015-06-23  7:31           ` David Miller
2015-06-23  7:31             ` David Miller
2015-06-22 20:51         ` [PATCH v6] " Noam Camus
2015-06-22 20:51           ` Noam Camus
2015-06-22 21:04           ` Rami Rosen
2015-06-22 21:04             ` Rami Rosen
2015-06-23  8:43           ` [PATCH v7] " Noam Camus
2015-06-23 14:17             ` David Miller
2015-06-24  3:40             ` Paul Gortmaker
2015-06-11 22:43   ` [PATCH v2] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB4PR02MB272B2804219ED0AD76BA1B2D6A10@DB4PR02MB272.eurprd02.prod.outlook.com \
    --to=noamc@ezchip.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=cmetcalf@ezchip.com \
    --cc=davem@davemloft.net \
    --cc=giladb@ezchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=talz@ezchip.com \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.