All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Andy Gross <agross@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs
Date: Tue, 1 Sep 2015 11:04:54 -0700	[thread overview]
Message-ID: <20150901180453.GC19120@codeaurora.org> (raw)
In-Reply-To: <20150901050644.GD13472@usrtlx11787.corpusers.net>

On 08/31, Bjorn Andersson wrote:
> On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote:
> 
> > The smd structures are always in little endian, but the smd
> > driver is not capable of being used on big endian CPUs. Annotate
> > the little endian data members and update the code to do the
> > proper byte swapping.
> > 
> 
> I think this looks good, but I think it would be better to reference
> the 8-bit entries of the info struct as "flags" rather than INFO8s.
> 
> Could you please change the name of the macros to
> {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to

Sure. I also found another missing __le32 marking on the "hdr"
stack structure. I'll test out some smd sending before resending
the patches.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs
Date: Tue, 1 Sep 2015 11:04:54 -0700	[thread overview]
Message-ID: <20150901180453.GC19120@codeaurora.org> (raw)
In-Reply-To: <20150901050644.GD13472@usrtlx11787.corpusers.net>

On 08/31, Bjorn Andersson wrote:
> On Mon 31 Aug 18:39 PDT 2015, Stephen Boyd wrote:
> 
> > The smd structures are always in little endian, but the smd
> > driver is not capable of being used on big endian CPUs. Annotate
> > the little endian data members and update the code to do the
> > proper byte swapping.
> > 
> 
> I think this looks good, but I think it would be better to reference
> the 8-bit entries of the info struct as "flags" rather than INFO8s.
> 
> Could you please change the name of the macros to
> {G,S}ET_{R,T}X_CHANNEL_FLAG() to make the code slightly easier to

Sure. I also found another missing __le32 marking on the "hdr"
stack structure. I'll test out some smd sending before resending
the patches.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-09-01 18:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01  1:39 [PATCH 0/3] qcom smd big endian support Stephen Boyd
2015-09-01  1:39 ` Stephen Boyd
2015-09-01  1:39 ` [PATCH 1/3] soc: qcom: smd: Represent channel layout in structures Stephen Boyd
2015-09-01  1:39   ` Stephen Boyd
2015-09-01  1:39   ` Stephen Boyd
2015-09-01  4:55   ` Bjorn Andersson
2015-09-01  4:55     ` Bjorn Andersson
2015-09-01  4:55     ` Bjorn Andersson
2015-09-01 17:51     ` Stephen Boyd
2015-09-01 17:51       ` Stephen Boyd
2015-09-01 17:51       ` Stephen Boyd
2015-09-01  1:39 ` [PATCH 2/3] soc: qcom: smd: Use __iowrite32_copy() instead of open-coding it Stephen Boyd
2015-09-01  1:39   ` Stephen Boyd
2015-09-01  4:59   ` Bjorn Andersson
2015-09-01  4:59     ` Bjorn Andersson
2015-09-01  4:59     ` Bjorn Andersson
2015-09-01 18:03     ` Stephen Boyd
2015-09-01 18:03       ` Stephen Boyd
2015-09-01 18:03       ` Stephen Boyd
2015-09-01 20:30       ` Stephen Boyd
2015-09-01 20:30         ` Stephen Boyd
2015-09-01 20:30         ` Stephen Boyd
2015-09-01  1:39 ` [PATCH 3/3] soc: qcom: smd: Handle big endian CPUs Stephen Boyd
2015-09-01  1:39   ` Stephen Boyd
2015-09-01  5:06   ` Bjorn Andersson
2015-09-01  5:06     ` Bjorn Andersson
2015-09-01  5:06     ` Bjorn Andersson
2015-09-01 18:04     ` Stephen Boyd [this message]
2015-09-01 18:04       ` Stephen Boyd
2015-09-01 18:04       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150901180453.GC19120@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=agross@codeaurora.org \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.