From: Yury Norov <ynorov@caviumnetworks.com> To: Arnd Bergmann <arnd@arndb.de> Cc: <catalin.marinas@arm.com>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <pinskia@gmail.com>, <ddaney.cavm@gmail.com>, <jan.dakinevich@gmail.com>, <Prasun.Kapoor@caviumnetworks.com>, <christoph.muellner@theobroma-systems.com>, <philipp.tomsich@theobroma-systems.com>, <broonie@kernel.org>, <andrey.konovalov@linaro.org>, <Nathan_Lynch@mentor.com>, <agraf@suse.de>, <bamvor.zhangjian@huawei.com>, <klimov.linux@gmail.com>, <joseph@codesourcery.com>, <schwab@suse.de> Subject: Re: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Wed, 2 Dec 2015 13:01:53 +0300 [thread overview] Message-ID: <20151202100153.GA21461@yury-N73SV> (raw) In-Reply-To: <3754277.KmO9Nk3XLD@wuerfel> On Tue, Nov 17, 2015 at 10:57:52PM +0100, Arnd Bergmann wrote: It looks, all them are needed. > > +asmlinkage long compat_sys_mmap2_wrapper(void); > > +#define sys_mmap2 compat_sys_mmap2_wrapper This wrapper checks alignement of pgoff, if page sise is greater than 4K > > +asmlinkage long compat_sys_fstatfs64_wrapper(void); > > +#define compat_sys_fstatfs64 compat_sys_fstatfs64_wrapper > > +asmlinkage long compat_sys_statfs64_wrapper(void); > > +#define compat_sys_statfs64 compat_sys_statfs64_wrapper This two hacks fix an alignment issue. I didn't check all details but it looks like sizeof(compat_statfs64) is different in kernel and library. And this size is passed as 2nd argument to compat syscalls. We can handle it in userspace but I don't see any advantage. All this handlers are shared between ilp32 and aarch32. This is best we came up, as it doesn't add new hacks, but reuses old ones...
WARNING: multiple messages have this Message-ID (diff)
From: ynorov@caviumnetworks.com (Yury Norov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Wed, 2 Dec 2015 13:01:53 +0300 [thread overview] Message-ID: <20151202100153.GA21461@yury-N73SV> (raw) In-Reply-To: <3754277.KmO9Nk3XLD@wuerfel> On Tue, Nov 17, 2015 at 10:57:52PM +0100, Arnd Bergmann wrote: It looks, all them are needed. > > +asmlinkage long compat_sys_mmap2_wrapper(void); > > +#define sys_mmap2 compat_sys_mmap2_wrapper This wrapper checks alignement of pgoff, if page sise is greater than 4K > > +asmlinkage long compat_sys_fstatfs64_wrapper(void); > > +#define compat_sys_fstatfs64 compat_sys_fstatfs64_wrapper > > +asmlinkage long compat_sys_statfs64_wrapper(void); > > +#define compat_sys_statfs64 compat_sys_statfs64_wrapper This two hacks fix an alignment issue. I didn't check all details but it looks like sizeof(compat_statfs64) is different in kernel and library. And this size is passed as 2nd argument to compat syscalls. We can handle it in userspace but I don't see any advantage. All this handlers are shared between ilp32 and aarch32. This is best we came up, as it doesn't add new hacks, but reuses old ones...
next prev parent reply other threads:[~2015-12-02 10:02 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-17 21:16 [RFC2 PATCH v6 00/19] ILP32 for ARM64 Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 21:16 ` [PATCH v6 01/19] arm64:ilp32: add documentation on the ILP32 ABI " Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-18 8:09 ` Zhangjian (Bamvor) 2015-11-18 8:09 ` Zhangjian (Bamvor) 2015-11-17 21:16 ` [PATCH v6 02/19] arm64: ensure the kernel is compiled for LP64 Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 21:16 ` [PATCH v6 03/19] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 21:16 ` [PATCH v6 04/19] arm64: change some CONFIG_COMPAT over to use CONFIG_AARCH32_EL0 instead Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-12-03 12:02 ` Catalin Marinas 2015-12-03 12:02 ` Catalin Marinas 2015-12-04 21:58 ` Yury Norov 2015-12-04 21:58 ` Yury Norov 2015-11-17 21:16 ` [PATCH v6 05/19] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-12-03 11:31 ` Catalin Marinas 2015-12-03 11:31 ` Catalin Marinas 2015-12-03 11:36 ` Dr. Philipp Tomsich 2015-12-03 11:36 ` Dr. Philipp Tomsich 2015-11-17 21:16 ` [PATCH v6 06/19] arm64:ilp32: share signal structures between ILP32 and LP64 ABIs Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 22:14 ` Arnd Bergmann 2015-11-17 22:14 ` Arnd Bergmann 2015-11-17 21:16 ` [PATCH v6 07/19] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-12-03 12:13 ` Catalin Marinas 2015-12-03 12:13 ` Catalin Marinas 2015-12-04 17:05 ` Yury Norov 2015-12-04 17:05 ` Yury Norov 2015-12-05 11:00 ` Catalin Marinas 2015-12-05 11:00 ` Catalin Marinas 2015-11-17 21:16 ` [PATCH v6 08/19] arm64:ilp32: add is_ilp32_compat_{task,thread} and TIF_32BIT_AARCH64 Yury Norov 2015-11-17 21:16 ` [PATCH v6 08/19] arm64:ilp32: add is_ilp32_compat_{task, thread} " Yury Norov 2015-11-17 21:16 ` [PATCH v6 09/19] arm64:ilp32: share HWCAP between LP64 and ILP32 Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 21:16 ` [PATCH v6 10/19] arm64:ilp32 use the native LP64 'start_thread' for ILP32 threads Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-12-03 12:20 ` Catalin Marinas 2015-12-03 12:20 ` Catalin Marinas 2015-11-17 21:16 ` [PATCH v6 11/19] arm64:ilp32: support core dump generation for ILP32 Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-12-03 16:39 ` Catalin Marinas 2015-12-03 16:39 ` Catalin Marinas 2015-11-17 21:16 ` [PATCH v6 12/19] ptrace: Allow compat to use the native siginfo Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 21:16 ` [PATCH v6 13/19] arm64: ilp32: common 32-bit wrappers Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 21:16 ` [PATCH v6 14/19] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 21:57 ` Arnd Bergmann 2015-11-17 21:57 ` Arnd Bergmann 2015-11-18 8:14 ` Arnd Bergmann 2015-11-18 8:14 ` Arnd Bergmann 2015-11-19 13:21 ` Andreas Schwab 2015-11-19 13:21 ` Andreas Schwab 2015-11-19 13:32 ` Arnd Bergmann 2015-11-19 13:32 ` Arnd Bergmann 2015-11-30 15:34 ` Arnd Bergmann 2015-11-30 15:34 ` Arnd Bergmann 2015-11-30 20:21 ` Yury Norov 2015-11-30 20:21 ` Yury Norov 2015-11-30 21:49 ` Arnd Bergmann 2015-11-30 21:49 ` Arnd Bergmann 2015-12-01 0:20 ` Andrew Pinski 2015-12-01 0:20 ` Andrew Pinski 2015-12-01 0:40 ` Yury Norov 2015-12-01 0:40 ` Yury Norov 2015-12-01 10:26 ` Arnd Bergmann 2015-12-01 10:26 ` Arnd Bergmann 2015-12-01 9:20 ` Andreas Schwab 2015-12-01 9:20 ` Andreas Schwab 2015-12-01 10:22 ` Arnd Bergmann 2015-12-01 10:22 ` Arnd Bergmann 2015-12-01 11:01 ` Andreas Schwab 2015-12-01 11:01 ` Andreas Schwab 2015-12-01 11:30 ` Arnd Bergmann 2015-12-01 11:30 ` Arnd Bergmann 2015-12-02 0:24 ` Yury Norov 2015-12-02 0:24 ` Yury Norov 2015-12-02 10:03 ` Arnd Bergmann 2015-12-02 10:03 ` Arnd Bergmann 2015-12-03 17:17 ` Catalin Marinas 2015-12-03 17:17 ` Catalin Marinas 2015-12-01 21:29 ` Yury Norov 2015-12-01 21:29 ` Yury Norov 2015-12-01 22:39 ` Arnd Bergmann 2015-12-01 22:39 ` Arnd Bergmann 2015-12-01 23:35 ` Yury Norov 2015-12-01 23:35 ` Yury Norov 2015-12-02 8:37 ` Arnd Bergmann 2015-12-02 8:37 ` Arnd Bergmann 2015-12-02 9:15 ` Yury Norov 2015-12-02 9:15 ` Yury Norov 2015-12-02 10:35 ` Yury Norov 2015-12-02 10:35 ` Yury Norov 2015-12-02 13:46 ` Arnd Bergmann 2015-12-02 13:46 ` Arnd Bergmann 2015-12-02 13:54 ` Arnd Bergmann 2015-12-02 13:54 ` Arnd Bergmann 2015-12-02 13:57 ` Will Deacon 2015-12-02 13:57 ` Will Deacon 2015-12-03 17:47 ` Catalin Marinas 2015-12-03 17:47 ` Catalin Marinas 2015-12-03 18:14 ` Yury Norov 2015-12-03 18:14 ` Yury Norov 2015-12-03 20:42 ` Arnd Bergmann 2015-12-03 20:42 ` Arnd Bergmann 2015-12-02 10:01 ` Yury Norov [this message] 2015-12-02 10:01 ` Yury Norov 2015-12-02 11:03 ` Arnd Bergmann 2015-12-02 11:03 ` Arnd Bergmann 2015-11-17 21:16 ` [PATCH v6 15/19] arm64: ilp32: force IPC_64 in msgctl, shmctl, semctl Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 22:07 ` Arnd Bergmann 2015-11-17 22:07 ` Arnd Bergmann 2015-11-18 8:25 ` Andreas Schwab 2015-11-18 8:25 ` Andreas Schwab 2015-11-18 9:23 ` Arnd Bergmann 2015-11-18 9:23 ` Arnd Bergmann 2015-11-18 10:07 ` Geert Uytterhoeven 2015-11-18 10:07 ` Geert Uytterhoeven 2015-11-18 12:04 ` Arnd Bergmann 2015-11-18 12:04 ` Arnd Bergmann 2015-11-17 21:16 ` [PATCH v6 16/19] aarch64: ilp32: use generic stat64 structure Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 22:09 ` Arnd Bergmann 2015-11-17 22:09 ` Arnd Bergmann 2015-11-18 20:36 ` Yury Norov 2015-11-18 20:36 ` Yury Norov 2015-11-18 20:45 ` Arnd Bergmann 2015-11-18 20:45 ` Arnd Bergmann 2015-11-17 21:16 ` [PATCH v6 17/19] arm64:ilp32: use the native siginfo instead of the compat siginfo Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-17 21:16 ` [PATCH v6 18/19] arm64:ilp32: change COMPAT_ELF_PLATFORM to report a a subplatform for ILP32 Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-18 8:11 ` Zhangjian (Bamvor) 2015-11-18 8:11 ` Zhangjian (Bamvor) 2015-11-18 11:21 ` pinskia 2015-11-18 11:21 ` pinskia at gmail.com 2015-11-18 20:25 ` Yury Norov 2015-11-18 20:25 ` Yury Norov 2015-11-18 21:47 ` Dr. Philipp Tomsich 2015-11-18 21:47 ` Dr. Philipp Tomsich 2015-11-17 21:16 ` [PATCH v6 19/19] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov 2015-11-17 21:16 ` Yury Norov 2015-11-18 8:00 ` [RFC2 PATCH v6 00/19] ILP32 for ARM64 Zhangjian (Bamvor) 2015-11-18 8:00 ` Zhangjian (Bamvor) 2015-11-23 16:49 ` Andreas Schwab 2015-11-23 16:49 ` Andreas Schwab 2015-12-03 17:59 ` Catalin Marinas 2015-12-03 17:59 ` Catalin Marinas 2015-12-04 15:35 ` Yury Norov 2015-12-04 15:35 ` Yury Norov 2015-12-04 17:18 ` Catalin Marinas 2015-12-04 17:18 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151202100153.GA21461@yury-N73SV \ --to=ynorov@caviumnetworks.com \ --cc=Nathan_Lynch@mentor.com \ --cc=Prasun.Kapoor@caviumnetworks.com \ --cc=agraf@suse.de \ --cc=andrey.konovalov@linaro.org \ --cc=arnd@arndb.de \ --cc=bamvor.zhangjian@huawei.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=christoph.muellner@theobroma-systems.com \ --cc=ddaney.cavm@gmail.com \ --cc=jan.dakinevich@gmail.com \ --cc=joseph@codesourcery.com \ --cc=klimov.linux@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=philipp.tomsich@theobroma-systems.com \ --cc=pinskia@gmail.com \ --cc=schwab@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.