All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mark.rutland@arm.com,
	punit.agrawal@arm.com, arm@kernel.org
Subject: Re: [PATCH v4 05/12] arm-cci: PMU: Add support for transactions
Date: Thu, 17 Dec 2015 19:42:55 +0100	[thread overview]
Message-ID: <20151217184255.GI6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1450374559-23315-6-git-send-email-suzuki.poulose@arm.com>

On Thu, Dec 17, 2015 at 05:49:12PM +0000, Suzuki K. Poulose wrote:
> This patch adds the transaction hooks for CCI PMU, which can be
> later exploited to amortise the cost of writing the counters for
> CCI-500 PMU.
> 
> We keep track of only the 'ADD' transactions. While we are in a
> transaction, we keep track of the indices allocated for the events
> and delay the following operations until the transaction is committed.
>  1) Programming the event on the counter
>  2) Enabling the counter
>  3) Setting the period for the event.

So that's not really what the txn interface is for, its meant to
amortize event scheduling.

The above doesn't look like it has a failure case, in which case you can
achieve the same simpler, using pmu::pmu_{dis,en}able().


WARNING: multiple messages have this Message-ID (diff)
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 05/12] arm-cci: PMU: Add support for transactions
Date: Thu, 17 Dec 2015 19:42:55 +0100	[thread overview]
Message-ID: <20151217184255.GI6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1450374559-23315-6-git-send-email-suzuki.poulose@arm.com>

On Thu, Dec 17, 2015 at 05:49:12PM +0000, Suzuki K. Poulose wrote:
> This patch adds the transaction hooks for CCI PMU, which can be
> later exploited to amortise the cost of writing the counters for
> CCI-500 PMU.
> 
> We keep track of only the 'ADD' transactions. While we are in a
> transaction, we keep track of the indices allocated for the events
> and delay the following operations until the transaction is committed.
>  1) Programming the event on the counter
>  2) Enabling the counter
>  3) Setting the period for the event.

So that's not really what the txn interface is for, its meant to
amortize event scheduling.

The above doesn't look like it has a failure case, in which case you can
achieve the same simpler, using pmu::pmu_{dis,en}able().

  reply	other threads:[~2015-12-17 18:43 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 17:49 [PATCHv4 00/12] arm-cci: PMU updates Suzuki K. Poulose
2015-12-17 17:49 ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 01/12] arm-cci: Define CCI counter period Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 02/12] arm-cci: Refactor pmu_write_counter Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 03/12] arm-cci: Group writes to counter Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 04/12] arm-cci: Fix the flags for pmu_start called from pmu_add Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 05/12] arm-cci: PMU: Add support for transactions Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 18:42   ` Peter Zijlstra [this message]
2015-12-17 18:42     ` Peter Zijlstra
2015-12-18 10:28     ` Suzuki K. Poulose
2015-12-18 10:28       ` Suzuki K. Poulose
2015-12-18 10:42       ` Peter Zijlstra
2015-12-18 10:42         ` Peter Zijlstra
2015-12-18 10:58         ` Suzuki K. Poulose
2015-12-18 10:58           ` Suzuki K. Poulose
2015-12-18 11:47           ` Peter Zijlstra
2015-12-18 11:47             ` Peter Zijlstra
2015-12-21 10:55             ` Suzuki K. Poulose
2015-12-21 10:55               ` Suzuki K. Poulose
2016-01-05 13:37               ` Peter Zijlstra
2016-01-05 13:37                 ` Peter Zijlstra
2016-01-05 13:43                 ` Suzuki K. Poulose
2016-01-05 13:43                   ` Suzuki K. Poulose
2016-01-05 14:53                   ` Peter Zijlstra
2016-01-05 14:53                     ` Peter Zijlstra
2015-12-17 17:49 ` [PATCH v4 06/12] arm-cci: Refactor CCI PMU enable/disable methods Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 07/12] arm-cci: Get the status of a counter Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 08/12] arm-cci: Add routines to save/restore all counters Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 09/12] arm-cci: Provide hook for writing to PMU counters Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 10/12] arm-cci: CCI-500: Work around PMU counter writes Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 11/12] arm-cci500: Rearrange PMU driver for code sharing with CCI-550 PMU Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose
2015-12-17 17:49 ` [PATCH v4 12/12] arm-cci: CoreLink CCI-550 PMU driver Suzuki K. Poulose
2015-12-17 17:49   ` Suzuki K. Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151217184255.GI6344@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=arm@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=punit.agrawal@arm.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.