All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
	mturquette@baylibre.com, sboyd@codeaurora.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 7/9] ARM: dts: omap4: add hwmod module clocks
Date: Fri, 18 Dec 2015 07:06:33 -0800	[thread overview]
Message-ID: <20151218150633.GG23396@atomide.com> (raw)
In-Reply-To: <1450447141-29936-8-git-send-email-t-kristo@ti.com>

* Tero Kristo <t-kristo@ti.com> [151218 05:57]:
> +	mmu_dsp_mod_ck: mmu_dsp_mod_ck {
> +		#clock-cells = <0>;
> +		compatible = "ti,omap4-hw-mod-clock";
> +		reg = <0x0420>;
> +		clocks = <&dpll_iva_m4x2_ck>;
> +	};
> +
> +	dsp_mod_ck: dsp_mod_ck {
> +		#clock-cells = <0>;
> +		compatible = "ti,omap4-hw-mod-clock";
> +		reg = <0x0420>;
> +		clocks = <&dpll_iva_m4x2_ck>;
> +	};

In general we should get rid of the overlapping reg entries
for clocks. That's a separate patch series for sure.. But I
think it can be done simply with something like this probably
for all of them (totally untested):

	mux_div_gate_ck: clk@420 {
		#clock-cells = <1>;
		compatible = "ti,mux-divider-gate";
		clock-indices = <0>, <1>;
		clock-output-names = "mux", "div", "gate";
		reg = <0x420 0x4>;
		foo_mux_ck: clock@0 {
			reg = <0>;
			compatible = "ti,mux-clock";
		};
		foo_div_ck: clock@8 {
			reg = <8>;
			compatible = "ti,divider-clock";
			ti,max-div = <31>;
		};
		foo_gate_ck: clock@16 {
			reg = <16>;
			compatible = "ti,gate-clock";
			clocks = <&mux_source_ck>;
		};
	};

Then the output can be referenced with the standard clock binding
index. For example to use the mux clock:

clocks = <&mux_div_gate_ck 0>;

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 7/9] ARM: dts: omap4: add hwmod module clocks
Date: Fri, 18 Dec 2015 07:06:33 -0800	[thread overview]
Message-ID: <20151218150633.GG23396@atomide.com> (raw)
In-Reply-To: <1450447141-29936-8-git-send-email-t-kristo@ti.com>

* Tero Kristo <t-kristo@ti.com> [151218 05:57]:
> +	mmu_dsp_mod_ck: mmu_dsp_mod_ck {
> +		#clock-cells = <0>;
> +		compatible = "ti,omap4-hw-mod-clock";
> +		reg = <0x0420>;
> +		clocks = <&dpll_iva_m4x2_ck>;
> +	};
> +
> +	dsp_mod_ck: dsp_mod_ck {
> +		#clock-cells = <0>;
> +		compatible = "ti,omap4-hw-mod-clock";
> +		reg = <0x0420>;
> +		clocks = <&dpll_iva_m4x2_ck>;
> +	};

In general we should get rid of the overlapping reg entries
for clocks. That's a separate patch series for sure.. But I
think it can be done simply with something like this probably
for all of them (totally untested):

	mux_div_gate_ck: clk at 420 {
		#clock-cells = <1>;
		compatible = "ti,mux-divider-gate";
		clock-indices = <0>, <1>;
		clock-output-names = "mux", "div", "gate";
		reg = <0x420 0x4>;
		foo_mux_ck: clock at 0 {
			reg = <0>;
			compatible = "ti,mux-clock";
		};
		foo_div_ck: clock at 8 {
			reg = <8>;
			compatible = "ti,divider-clock";
			ti,max-div = <31>;
		};
		foo_gate_ck: clock at 16 {
			reg = <16>;
			compatible = "ti,gate-clock";
			clocks = <&mux_source_ck>;
		};
	};

Then the output can be referenced with the standard clock binding
index. For example to use the mux clock:

clocks = <&mux_div_gate_ck 0>;

Regards,

Tony

  reply	other threads:[~2015-12-18 15:06 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-18 13:58 [RFC 0/9] ARM: OMAP4: hwmod clkctrl conversion to DT + clock driver Tero Kristo
2015-12-18 13:58 ` Tero Kristo
2015-12-18 13:58 ` Tero Kristo
2015-12-18 13:58 ` [RFC 1/9] ARM: OMAP2+: omap_device: create clock alias purely from DT data Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 15:16   ` Tony Lindgren
2015-12-18 15:16     ` Tony Lindgren
2015-12-18 13:58 ` [RFC 2/9] ARM: OMAP2+: hwmod: initialize main clocks directly from DT Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58 ` [RFC 3/9] clk: ti: remove un-used definitions from public clk_hw_omap struct Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58 ` [RFC 4/9] clk: ti: mux: export mux clock APIs locally Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58 ` [RFC 5/9] dt-bindings: clk: ti: Document module clock type Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58 ` [RFC 6/9] clk: ti: add support for omap4 module clocks Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 15:36   ` Tony Lindgren
2015-12-18 15:36     ` Tony Lindgren
2016-01-01  5:48   ` Michael Turquette
2016-01-01  5:48     ` Michael Turquette
2016-01-01  5:48     ` Michael Turquette
2016-01-04  7:36     ` Tero Kristo
2016-01-04  7:36       ` Tero Kristo
2016-01-04  7:36       ` Tero Kristo
2016-01-04 10:21       ` Geert Uytterhoeven
2016-01-04 10:21         ` Geert Uytterhoeven
2016-01-04 10:21         ` Geert Uytterhoeven
2016-01-04 13:27         ` Tero Kristo
2016-01-04 13:27           ` Tero Kristo
2016-01-04 14:42           ` Russell King - ARM Linux
2016-01-04 14:42             ` Russell King - ARM Linux
2016-01-04 16:37             ` Tony Lindgren
2016-01-04 16:37               ` Tony Lindgren
2016-01-04 19:15               ` Tero Kristo
2016-01-04 19:15                 ` Tero Kristo
2016-01-05  1:23                 ` Michael Turquette
2016-01-05  1:23                   ` Michael Turquette
2016-01-05  1:23                   ` Michael Turquette
2016-01-05  1:29       ` Michael Turquette
2016-01-05  1:29         ` Michael Turquette
2016-01-05  1:29         ` Michael Turquette
2015-12-18 13:58 ` [RFC 7/9] ARM: dts: omap4: add hwmod " Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 13:58   ` Tero Kristo
2015-12-18 15:06   ` Tony Lindgren [this message]
2015-12-18 15:06     ` Tony Lindgren
2015-12-18 13:59 ` [RFC 8/9] ARM: OMAP4: hwmod_data: use module clocks from DT Tero Kristo
2015-12-18 13:59   ` Tero Kristo
2015-12-18 13:59   ` Tero Kristo
2015-12-18 15:11   ` Tony Lindgren
2015-12-18 15:11     ` Tony Lindgren
2015-12-18 13:59 ` [RFC 9/9] clk: ti: omap4: update clock aliases to reflect new module clocks Tero Kristo
2015-12-18 13:59   ` Tero Kristo
2015-12-18 13:59   ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151218150633.GG23396@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.