[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Hi,

here you will find my current snapshot for the next Kodi release:
https://github.com/bkuhls/buildroot/tree/kodi16

Current release status is beta4:
http://kodi.tv/kodi-16-0-beta-4-jarvis-is-getting-ready-4/

My tree uses HEAD of the Jarvis branch:
https://github.com/xbmc/xbmc/tree/Jarvis

The first two patches in my series do not depend on the Kodi version 
bump, I am using them with 15.2 already, therefore they precede the Kodi 
version bump:
http://patchwork.ozlabs.org/patch/538512/
http://patchwork.ozlabs.org/patch/538513/

Kodi moved to C++11 so we need gcc >= 4.7:
https://github.com/xbmc/xbmc/pull/6412

I know that hash files are missing, I will add them to the patch series 
of the final bump after the release of Kodi 16.0-Jarvis.

Feedback welcome ;)

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sat, 19 Dec 2015 19:05:23 +0100 schrieb Bernd Kuhls:

> Hi,
> 
> here you will find my current snapshot for the next Kodi release:
> https://github.com/bkuhls/buildroot/tree/kodi16

Hi,

after a first review by Thomas I just updated the branch.

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Thomas Petazzoni]

Bernd,

On Sun, 20 Dec 2015 13:13:19 +0100, Bernd Kuhls wrote:

> after a first review by Thomas I just updated the branch.

Thanks. I don't know if others will agree, but I believe it might make
things easier to review if all the very simple "bump version" patches
for all kodi add-ons were merged into a single patch. I know we
normally don't do that, but it would make the series a lot shorter, and
would emphasize the few updates for which it's not just a mechanical
bump. So, this "big" commit would only contain the version bumps for
the packages that don't require anything but a change to the version.
If you need to do more than that, then it should be in a separate
commit per package.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Yann E. MORIN]

Thomas, Bernd, All,

On 2015-12-20 13:54 +0100, Thomas Petazzoni spake thusly:
> On Sun, 20 Dec 2015 13:13:19 +0100, Bernd Kuhls wrote:
> > after a first review by Thomas I just updated the branch.
> 
> Thanks. I don't know if others will agree, but I believe it might make
> things easier to review if all the very simple "bump version" patches
> for all kodi add-ons were merged into a single patch. I know we
> normally don't do that, but it would make the series a lot shorter, and
> would emphasize the few updates for which it's not just a mechanical
> bump. So, this "big" commit would only contain the version bumps for
> the packages that don't require anything but a change to the version.
> If you need to do more than that, then it should be in a separate
> commit per package.

Well, I'm not too fond of that. But indeed, it's a pain to review either
way.

Maybe a middle-ground solution would be to bump all the screensavers in
one patch, all the audiocoders in a second one and so on?

Also, I'm not too fond of doing reviews on a github repository. I'd
largely prefer we have a complete RFC series on the list, otherwise the
reviews are lost. For example, I now can't see what Thomas as said,
since the branch has been rebased and previous comments are lost.

So, if the bumps are grouped by catregories, the series will
machanically be shorter, and will be easier to handle on the list.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Thomas Petazzoni]

Hello,

On Sun, 20 Dec 2015 14:00:54 +0100, Yann E. MORIN wrote:

> Well, I'm not too fond of that. But indeed, it's a pain to review either
> way.
> 
> Maybe a middle-ground solution would be to bump all the screensavers in
> one patch, all the audiocoders in a second one and so on?

I'm fine with this, but I'd like to keep my request to have the "simple
bumps" grouped together in certain commits, but as soon as the bump is
not just a mechanical one, it should be a separate patch. I.e for
example:

	kodi-screensaver-*: mechanical bumps
	kodi-screensaver-baz: bump version

> Also, I'm not too fond of doing reviews on a github repository. I'd
> largely prefer we have a complete RFC series on the list, otherwise the
> reviews are lost. For example, I now can't see what Thomas as said,
> since the branch has been rebased and previous comments are lost.

I think Bernd's intention was just to announce that he was going to
post all the patches as soon as Kodi 16 was out, but he wants to wait
for that release to happen before posting 100 patches on the list.

But by grouping package bumps a little bit, the size of the series
would be a lot shorter, and it would therefore be a bit more acceptable
to post such an RFC series on the list.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sun, 20 Dec 2015 14:16:13 +0100 schrieb Thomas Petazzoni:

>> Also, I'm not too fond of doing reviews on a github repository. I'd
>> largely prefer we have a complete RFC series on the list, otherwise the
>> reviews are lost. For example, I now can't see what Thomas as said,
>> since the branch has been rebased and previous comments are lost.
> 
> I think Bernd's intention was just to announce that he was going to post
> all the patches as soon as Kodi 16 was out, but he wants to wait for
> that release to happen before posting 100 patches on the list.

Hi Thomas,

yes, you got my intention right, and, btw, I just followed your advice ;) 
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/120960

@Yann: Thomas' comments were about license files and one missing SELECT 
in Config.in and the format of a patch file, no big stuff.

Just to get things right, these patches should be squashed into one patch 
bumping all audio en-/decoder addons?

* 13b3dfb - package/kodi-audioencoder-wav: bump version 
* cef928f - package/kodi-audioencoder-vorbis: bump version 
* f5a66b6 - package/kodi-audioencoder-lame: bump version 
* 603a6b6 - package/kodi-audioencoder-flac: bump version 
* fd66f18 - package/kodi-audiodecoder-vgmstream: bump version 
* 16a8773 - package/kodi-audiodecoder-timidity: bump version 
* 91d7adf - package/kodi-audiodecoder-stsound: bump version 
* 666a842 - package/kodi-audiodecoder-snesapu: bump version 
* 7abfa7e - package/kodi-audiodecoder-sidplay: bump version 
* 9476aa9 - package/kodi-audiodecoder-nosefart: bump version 
* 6a13973 - package/kodi-audiodecoder-modplug: bump version 

These should be squashed into one patch to bump all pvr addons:
* 909e692 - package/kodi-pvr-wmc: bump version 
* 19e326d - package/kodi-pvr-vuplus: bump version 
* f8db75b - package/kodi-pvr-vdr-vnsi: bump version 
* 7e50b7d - package/kodi-pvr-vbox: bump version 
* ebeea23 - package/kodi-pvr-stalker: bump version 
* a988af9 - package/kodi-pvr-pctv: bump version 
* 35557cb - package/kodi-pvr-njoy: bump version 
* 24b0af6 - package/kodi-pvr-nextpvr: bump version 
* 59045cb - package/kodi-pvr-mythtv: bump version 
* dd75d83 - package/kodi-pvr-mediaportal-tvserver: bump version 
* bc96596 - package/kodi-pvr-iptvsimple: bump version 
* 8383797 - package/kodi-pvr-hts: bump version 
* b0a5951 - package/kodi-pvr-filmon: bump version 
* 5d8466f - package/kodi-pvr-dvbviewer: bump version 
* c1d70ad - package/kodi-pvr-dvblink: bump version 
* 21337f8 - package/kodi-pvr-argustv: bump version 

and one patch for visualisation bumps:
* 304d2be - package/kodi-visualisation-waveform: bump version 
* d608df6 - package/kodi-visualisation-spectrum: bump version 
* 10aaad1 - package/kodi-visualisation-shadertoy: bump version 

yet another patch for screensaver bumps:
* 3f26e24 - package/kodi-screensaver-stars: bump version 
* aa76a13 - package/kodi-screensaver-pyro: bump version 
* ccae71c - package/kodi-screensaver-pingpong: bump version 
* 8f8c82a - package/kodi-screensaver-greynetic: bump version 
* 0d4e7f6 - package/kodi-screensaver-biogenesis: bump version 
* 658b5eb - package/kodi-screensaver-asteroids: bump version 

What about the hash files to be added with the final patch series? Should 
they be included in the combined patches or shall I make seperate patches 
for each hash file added? If this is the case then I can keep the patch 
series as is because I will then include each hash file with the 
corresponding version bump patch. I kept the hash files out at this stage 
because the Kodi development is still in progress with on-going updates 
in the PVR area.

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Yann E. MORIN]

Thomas, All,

On 2015-12-20 14:16 +0100, Thomas Petazzoni spake thusly:
> On Sun, 20 Dec 2015 14:00:54 +0100, Yann E. MORIN wrote:
> > Well, I'm not too fond of that. But indeed, it's a pain to review either
> > way.
> > 
> > Maybe a middle-ground solution would be to bump all the screensavers in
> > one patch, all the audiocoders in a second one and so on?
> 
> I'm fine with this, but I'd like to keep my request to have the "simple
> bumps" grouped together in certain commits, but as soon as the bump is
> not just a mechanical one, it should be a separate patch. I.e for
> example:
> 
> 	kodi-screensaver-*: mechanical bumps
> 	kodi-screensaver-baz: bump version

Yes, agreed.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Yann E. MORIN]

Bernd, All,

On 2015-12-20 14:48 +0100, Bernd Kuhls spake thusly:
> Am Sun, 20 Dec 2015 14:16:13 +0100 schrieb Thomas Petazzoni:
[--SNIP--]
> > I think Bernd's intention was just to announce that he was going to post
> > all the patches as soon as Kodi 16 was out, but he wants to wait for
> > that release to happen before posting 100 patches on the list.
> 
> Hi Thomas,
> 
> yes, you got my intention right, and, btw, I just followed your advice ;) 
> http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/120960

Ah, OK! :-)

> @Yann: Thomas' comments were about license files and one missing SELECT 
> in Config.in and the format of a patch file, no big stuff.

Good!

> Just to get things right, these patches should be squashed into one patch 
> bumping all audio en-/decoder addons?
> 
> * 13b3dfb - package/kodi-audioencoder-wav: bump version 
> * cef928f - package/kodi-audioencoder-vorbis: bump version 
> * f5a66b6 - package/kodi-audioencoder-lame: bump version 
> * 603a6b6 - package/kodi-audioencoder-flac: bump version 
> * fd66f18 - package/kodi-audiodecoder-vgmstream: bump version 
> * 16a8773 - package/kodi-audiodecoder-timidity: bump version 
> * 91d7adf - package/kodi-audiodecoder-stsound: bump version 
> * 666a842 - package/kodi-audiodecoder-snesapu: bump version 
> * 7abfa7e - package/kodi-audiodecoder-sidplay: bump version 
> * 9476aa9 - package/kodi-audiodecoder-nosefart: bump version 
> * 6a13973 - package/kodi-audiodecoder-modplug: bump version 

As long as it is only a mechanical bump, without change to the .mk
files, and with n/removed patches (i.e. only the _VERSION variables are
changed), then yes, a single commit.

> These should be squashed into one patch to bump all pvr addons:
> * 909e692 - package/kodi-pvr-wmc: bump version 
> * 19e326d - package/kodi-pvr-vuplus: bump version 
> * f8db75b - package/kodi-pvr-vdr-vnsi: bump version 
> * 7e50b7d - package/kodi-pvr-vbox: bump version 
> * ebeea23 - package/kodi-pvr-stalker: bump version 
> * a988af9 - package/kodi-pvr-pctv: bump version 
> * 35557cb - package/kodi-pvr-njoy: bump version 
> * 24b0af6 - package/kodi-pvr-nextpvr: bump version 
> * 59045cb - package/kodi-pvr-mythtv: bump version 
> * dd75d83 - package/kodi-pvr-mediaportal-tvserver: bump version 
> * bc96596 - package/kodi-pvr-iptvsimple: bump version 
> * 8383797 - package/kodi-pvr-hts: bump version 
> * b0a5951 - package/kodi-pvr-filmon: bump version 
> * 5d8466f - package/kodi-pvr-dvbviewer: bump version 
> * c1d70ad - package/kodi-pvr-dvblink: bump version 
> * 21337f8 - package/kodi-pvr-argustv: bump version 

Yup. And possibly kodi-addon-xvdr too, no?

> and one patch for visualisation bumps:
> * 304d2be - package/kodi-visualisation-waveform: bump version 
> * d608df6 - package/kodi-visualisation-spectrum: bump version 
> * 10aaad1 - package/kodi-visualisation-shadertoy: bump version 

Yup.

> yet another patch for screensaver bumps:
> * 3f26e24 - package/kodi-screensaver-stars: bump version 
> * aa76a13 - package/kodi-screensaver-pyro: bump version 
> * ccae71c - package/kodi-screensaver-pingpong: bump version 
> * 8f8c82a - package/kodi-screensaver-greynetic: bump version 
> * 0d4e7f6 - package/kodi-screensaver-biogenesis: bump version 
> * 658b5eb - package/kodi-screensaver-asteroids: bump version 

Yup.

> What about the hash files to be added with the final patch series? Should 
> they be included in the combined patches or shall I make seperate patches 
> for each hash file added? If this is the case then I can keep the patch 
> series as is because I will then include each hash file with the 
> corresponding version bump patch. I kept the hash files out at this stage 
> because the Kodi development is still in progress with on-going updates 
> in the PVR area.

The hashes you include in the same patch as the bumps.

Thanks! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sun, 20 Dec 2015 15:51:53 +0100 schrieb Yann E. MORIN:

> As long as it is only a mechanical bump, without change to the .mk
> files, and with n/removed patches (i.e. only the _VERSION variables are
> changed), then yes, a single commit.

Hi Yann,

done: https://github.com/bkuhls/buildroot/commits/kodi16

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sun, 20 Dec 2015 15:51:53 +0100 schrieb Yann E. MORIN:

> Yup. And possibly kodi-addon-xvdr too, no?

Hi Yann,

there were no changes to its upstream repo, the current buildroot package 
reflects the latest version of the repo:
https://github.com/pipelka/xbmc-addon-xvdr/commits/master

But tbh I am not a vdr expert, personally I am happy with tvheadend.

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sun, 20 Dec 2015 21:37:09 +0100 schrieb Bernd Kuhls:

> Am Sun, 20 Dec 2015 15:51:53 +0100 schrieb Yann E. MORIN:
> 
>> As long as it is only a mechanical bump, without change to the .mk
>> files, and with n/removed patches (i.e. only the _VERSION variables are
>> changed), then yes, a single commit.
> 
> Hi Yann,
> 
> done: https://github.com/bkuhls/buildroot/commits/kodi16
> 
> Regards, Bernd

Hi @all:

Kodi 16.0-rc1 was released this week, I updated my github repo.

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Thomas Petazzoni]

Bernd,

On Sun, 24 Jan 2016 14:44:31 +0100, Bernd Kuhls wrote:

> Hi @all:
> 
> Kodi 16.0-rc1 was released this week, I updated my github repo.

Do you know when the final 16 release will be published ? If it's
before end of January, then we can include it in 2016.02 and you should
post the patches for -rc1 as soon as possible.

However, if it's scheduled to be released after end of January, then it
will only make it for Buildroot 2016.05, in which case you can wait
just after the release of 2016.02 to post your patch series.

How does that sound?

(BTW, if you want a specific reaction from me from a mail posted on the
mailing list, try to Cc me.)

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sun, 24 Jan 2016 15:56:06 +0100 schrieb Thomas Petazzoni:

> Bernd,
> 
> On Sun, 24 Jan 2016 14:44:31 +0100, Bernd Kuhls wrote:
> 
>> Hi @all:
>> 
>> Kodi 16.0-rc1 was released this week, I updated my github repo.
> 
> Do you know when the final 16 release will be published ?

Hi Thomas,

unfortunately I have no idea, let's wait and see ;)

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sun, 24 Jan 2016 14:44:31 +0100 schrieb Bernd Kuhls:

> Am Sun, 20 Dec 2015 21:37:09 +0100 schrieb Bernd Kuhls:
> 
>> Am Sun, 20 Dec 2015 15:51:53 +0100 schrieb Yann E. MORIN:
>> 
>>> As long as it is only a mechanical bump, without change to the .mk
>>> files, and with n/removed patches (i.e. only the _VERSION variables
>>> are changed), then yes, a single commit.
>> 
>> Hi Yann,
>> 
>> done: https://github.com/bkuhls/buildroot/commits/kodi16
>> 
>> Regards, Bernd
> 
> Hi @all:
> 
> Kodi 16.0-rc1 was released this week, I updated my github repo.
> 
> Regards, Bernd

Hi @all:

Kodi 16.0-rc2 was released this week, I updated my github repo.
http://kodi.tv/kodi-16-0-jarvis-release-candidate-2/

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sun, 31 Jan 2016 17:38:17 +0100 schrieb Bernd Kuhls:

> Am Sun, 24 Jan 2016 14:44:31 +0100 schrieb Bernd Kuhls:
> 
>> Am Sun, 20 Dec 2015 21:37:09 +0100 schrieb Bernd Kuhls:
>> 
>>> Am Sun, 20 Dec 2015 15:51:53 +0100 schrieb Yann E. MORIN:
>>> 
>>>> As long as it is only a mechanical bump, without change to the .mk
>>>> files, and with n/removed patches (i.e. only the _VERSION variables
>>>> are changed), then yes, a single commit.
>>> 
>>> Hi Yann,
>>> 
>>> done: https://github.com/bkuhls/buildroot/commits/kodi16
>>> 
>>> Regards, Bernd
>> 
>> Hi @all:
>> 
>> Kodi 16.0-rc1 was released this week, I updated my github repo.
>> 
>> Regards, Bernd
> 
> Hi @all:
> 
> Kodi 16.0-rc2 was released this week, I updated my github repo.
> http://kodi.tv/kodi-16-0-jarvis-release-candidate-2/
> 
> Regards, Bernd

Hi,

I just rebased the patch series.

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Thu, 04 Feb 2016 21:39:28 +0100 schrieb Bernd Kuhls:

> Am Sun, 31 Jan 2016 17:38:17 +0100 schrieb Bernd Kuhls:
>> Am Sun, 24 Jan 2016 14:44:31 +0100 schrieb Bernd Kuhls:
>>> Am Sun, 20 Dec 2015 21:37:09 +0100 schrieb Bernd Kuhls:
>>>> Am Sun, 20 Dec 2015 15:51:53 +0100 schrieb Yann E. MORIN:
>>>>> As long as it is only a mechanical bump, without change to the .mk
>>>>> files, and with n/removed patches (i.e. only the _VERSION variables
>>>>> are changed), then yes, a single commit.
>>>> 
>>>> Hi Yann,
>>>> 
>>>> done: https://github.com/bkuhls/buildroot/commits/kodi16
>>> 
>>> Hi @all:
>>> 
>>> Kodi 16.0-rc1 was released this week, I updated my github repo.
>> 
>> Hi @all:
>> 
>> Kodi 16.0-rc2 was released this week, I updated my github repo.
>> http://kodi.tv/kodi-16-0-jarvis-release-candidate-2/
> 
> I just rebased the patch series.
> 

Hi,

right now I am preparing the updated patch series for Kodi 16.0 rc3 which 
was released this week. Because I do not expect any changes to my patch 
series when 16.0 is finally released I would like to ask if you accept 
the Kodi rc3 patch series before buildroot enters rc1 state with the 
final version bump (and addition of hash files, of course ;)) in the next 
weeks?

Regards, Bernd

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Thomas Petazzoni]

Dear Bernd Kuhls,

(Please try to Cc: me explicitly on such questions, otherwise I miss
them.)

On Sun, 07 Feb 2016 14:41:02 +0100, Bernd Kuhls wrote:

> right now I am preparing the updated patch series for Kodi 16.0 rc3 which 
> was released this week. Because I do not expect any changes to my patch 
> series when 16.0 is finally released I would like to ask if you accept 
> the Kodi rc3 patch series before buildroot enters rc1 state with the 
> final version bump (and addition of hash files, of course ;)) in the next 
> weeks?

Are we sure that Kodi 16.0 will be released by the end of February ? If
that's the case, then I think I'm OK with taking the -rc3 patches right
now, and then bump to 16.0 when it gets released, before we
release 2016.02.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] RFC: Patch series for Kodi 16-Jarvis

[Bernd Kuhls]

Am Sun, 07 Feb 2016 14:58:59 +0100 schrieb Thomas Petazzoni:

> Are we sure that Kodi 16.0 will be released by the end of February ? If
> that's the case, then I think I'm OK with taking the -rc3 patches right
> now, and then bump to 16.0 when it gets released, before we release
> 2016.02.

Hi Thomas,

I marked the whole Kodi series as "deferred" in patchworks to reduce the 
number of patches there. When Kodi 16.0 is finally released I will send 
an updated version with hashes ;)

Regards, Bernd