All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Simon Horman <horms@verge.net.au>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar
Date: Wed, 06 Jan 2016 08:35:36 +0000	[thread overview]
Message-ID: <20160106083536.GC1525@katana> (raw)
In-Reply-To: <1451998831-27705-3-git-send-email-phil.edworthy@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

On Tue, Jan 05, 2016 at 01:00:29PM +0000, Phil Edworthy wrote:
> The R-Car PCIe host controller does not handle L1 ASPM. Instead, the
> hardware needs assistance to transition to L1. When the controller
> has received a PM_ENTER_L1 DLLP, we can't access a card's config regs
> until we have got it out of L1 link state. The host controller will
> handle this as long as it has also been transitioned to L1 link state.
> 
> So, when attempting a config access, check to see if the card has gone
> into L1, and if so, do the same for the host controller.
> 
> This is based on a patch by Hien Dang <hien.dang.eb@rvc.renesas.com>
> 
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> ---
> v2:
>  - Use readl_poll_timeout_atomic when waiting until we are in L1.

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Simon Horman <horms@verge.net.au>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar
Date: Wed, 6 Jan 2016 09:35:36 +0100	[thread overview]
Message-ID: <20160106083536.GC1525@katana> (raw)
In-Reply-To: <1451998831-27705-3-git-send-email-phil.edworthy@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

On Tue, Jan 05, 2016 at 01:00:29PM +0000, Phil Edworthy wrote:
> The R-Car PCIe host controller does not handle L1 ASPM. Instead, the
> hardware needs assistance to transition to L1. When the controller
> has received a PM_ENTER_L1 DLLP, we can't access a card's config regs
> until we have got it out of L1 link state. The host controller will
> handle this as long as it has also been transitioned to L1 link state.
> 
> So, when attempting a config access, check to see if the card has gone
> into L1, and if so, do the same for the host controller.
> 
> This is based on a patch by Hien Dang <hien.dang.eb@rvc.renesas.com>
> 
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> ---
> v2:
>  - Use readl_poll_timeout_atomic when waiting until we are in L1.

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-01-06  8:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 13:00 [PATCH v2 0/4] Various R-Car PCIe patches Phil Edworthy
2016-01-05 13:00 ` Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Phil Edworthy
2016-01-05 13:00   ` Phil Edworthy
2016-01-08  1:50   ` Simon Horman
2016-01-08  1:50     ` Simon Horman
2016-01-08 21:06     ` Bjorn Helgaas
2016-01-08 21:06       ` Bjorn Helgaas
2016-01-11 11:23       ` Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 2/4] PCI: rcar: Support runtime PM link state L1 handling " Phil Edworthy
2016-01-05 13:00   ` Phil Edworthy
2016-01-06  8:35   ` Wolfram Sang [this message]
2016-01-06  8:35     ` Wolfram Sang
2016-01-08 21:31   ` Bjorn Helgaas
2016-01-08 21:31     ` Bjorn Helgaas
2016-01-11 11:42     ` Phil Edworthy
2016-01-11 11:42       ` Phil Edworthy
2016-01-13 16:58     ` Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar Phil Edworthy
2016-01-05 13:00   ` Phil Edworthy
2016-01-06  8:35   ` Wolfram Sang
2016-01-06  8:35     ` Wolfram Sang
2016-01-06  8:45     ` Geert Uytterhoeven
2016-01-06  8:45       ` Geert Uytterhoeven
2016-01-06  8:50       ` Wolfram Sang
2016-01-06  8:50         ` Wolfram Sang
2016-01-05 13:00 ` [PATCH v2 4/4] PCI: rcar: Add Gen2 PHY setup " Phil Edworthy
2016-01-05 13:00   ` Phil Edworthy
2016-01-06  8:39   ` Wolfram Sang
2016-01-06  8:39     ` Wolfram Sang
2016-01-11 14:48 ` [PATCH v2 0/4] Various R-Car PCIe patches Bjorn Helgaas
2016-01-11 14:48   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160106083536.GC1525@katana \
    --to=wsa@the-dreams.de \
    --cc=bhelgaas@google.com \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=phil.edworthy@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.