From: Bjorn Helgaas <helgaas@kernel.org>
To: Simon Horman <horms@verge.net.au>
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Wolfram Sang <wsa@the-dreams.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar
Date: Fri, 08 Jan 2016 21:06:35 +0000 [thread overview]
Message-ID: <20160108210635.GL5354@localhost> (raw)
In-Reply-To: <20160108015056.GB9600@verge.net.au>
On Fri, Jan 08, 2016 at 10:50:57AM +0900, Simon Horman wrote:
> Hi Phil,
>
> On Tue, Jan 05, 2016 at 01:00:28PM +0000, Phil Edworthy wrote:
> > Commit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource
> > with global function pointer") removed the struct pci_sys_data
> > dependency from the ARM pcibios functions, so remove it from this
> > driver.
>
> I am a little confused by this as I still see two instances of
> the following in bios32.c as of the commit above.
>
> struct pci_sys_data *sys = dev->sysdata;
This patch only removes a pci_sys_data struct from pcie-rcar.c. That
struct was previously used by pci_common_init_dev() and by the ARM
pcibios_align_resource().
After cbce7900598c ("PCI: designware: Make driver arch-agnostic"), none of
the DesignWare drivers use pci_common_init_dev(), and after b3a72384fe29,
ARM doesn't need pci_sys_data for pcibios_align_resource().
Phil can correct me if I'm wrong, but I think this patch is probably OK.
I guess we can tell after I apply it and get a build test :)
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Simon Horman <horms@verge.net.au>
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Wolfram Sang <wsa@the-dreams.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar
Date: Fri, 8 Jan 2016 15:06:35 -0600 [thread overview]
Message-ID: <20160108210635.GL5354@localhost> (raw)
In-Reply-To: <20160108015056.GB9600@verge.net.au>
On Fri, Jan 08, 2016 at 10:50:57AM +0900, Simon Horman wrote:
> Hi Phil,
>
> On Tue, Jan 05, 2016 at 01:00:28PM +0000, Phil Edworthy wrote:
> > Commit b3a72384fe29 ("ARM/PCI: Replace pci_sys_data->align_resource
> > with global function pointer") removed the struct pci_sys_data
> > dependency from the ARM pcibios functions, so remove it from this
> > driver.
>
> I am a little confused by this as I still see two instances of
> the following in bios32.c as of the commit above.
>
> struct pci_sys_data *sys = dev->sysdata;
This patch only removes a pci_sys_data struct from pcie-rcar.c. That
struct was previously used by pci_common_init_dev() and by the ARM
pcibios_align_resource().
After cbce7900598c ("PCI: designware: Make driver arch-agnostic"), none of
the DesignWare drivers use pci_common_init_dev(), and after b3a72384fe29,
ARM doesn't need pci_sys_data for pcibios_align_resource().
Phil can correct me if I'm wrong, but I think this patch is probably OK.
I guess we can tell after I apply it and get a build test :)
Bjorn
next prev parent reply other threads:[~2016-01-08 21:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 13:00 [PATCH v2 0/4] Various R-Car PCIe patches Phil Edworthy
2016-01-05 13:00 ` Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 1/4] PCI: rcar: remove unused pci_sys_data structure in pcie-rcar Phil Edworthy
2016-01-05 13:00 ` Phil Edworthy
2016-01-08 1:50 ` Simon Horman
2016-01-08 1:50 ` Simon Horman
2016-01-08 21:06 ` Bjorn Helgaas [this message]
2016-01-08 21:06 ` Bjorn Helgaas
2016-01-11 11:23 ` Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 2/4] PCI: rcar: Support runtime PM link state L1 handling " Phil Edworthy
2016-01-05 13:00 ` Phil Edworthy
2016-01-06 8:35 ` Wolfram Sang
2016-01-06 8:35 ` Wolfram Sang
2016-01-08 21:31 ` Bjorn Helgaas
2016-01-08 21:31 ` Bjorn Helgaas
2016-01-11 11:42 ` Phil Edworthy
2016-01-11 11:42 ` Phil Edworthy
2016-01-13 16:58 ` Phil Edworthy
2016-01-05 13:00 ` [PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar Phil Edworthy
2016-01-05 13:00 ` Phil Edworthy
2016-01-06 8:35 ` Wolfram Sang
2016-01-06 8:35 ` Wolfram Sang
2016-01-06 8:45 ` Geert Uytterhoeven
2016-01-06 8:45 ` Geert Uytterhoeven
2016-01-06 8:50 ` Wolfram Sang
2016-01-06 8:50 ` Wolfram Sang
2016-01-05 13:00 ` [PATCH v2 4/4] PCI: rcar: Add Gen2 PHY setup " Phil Edworthy
2016-01-05 13:00 ` Phil Edworthy
2016-01-06 8:39 ` Wolfram Sang
2016-01-06 8:39 ` Wolfram Sang
2016-01-11 14:48 ` [PATCH v2 0/4] Various R-Car PCIe patches Bjorn Helgaas
2016-01-11 14:48 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108210635.GL5354@localhost \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.