All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] omap_hdq: fix usecount handling
@ 2016-01-16 12:48 Andreas Kemnade
  2016-01-19 11:56 ` Vignesh R
  2016-01-19 16:38   ` Evgeniy Polyakov
  0 siblings, 2 replies; 6+ messages in thread
From: Andreas Kemnade @ 2016-01-16 12:48 UTC (permalink / raw)
  To: Evgeniy Polyakov, hns, Fabian Frederick, gregkh, linux-kernel,
	linux-omap
  Cc: Andreas Kemnade

hdq_usecount was set to zero after a successful read, so
omap_hdq_put could not properly free resources which leads
e.g. to increasing usecounts in lsmod output

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 drivers/w1/masters/omap_hdq.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
index 0e2f43b..a2eec97 100644
--- a/drivers/w1/masters/omap_hdq.c
+++ b/drivers/w1/masters/omap_hdq.c
@@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
 
 	hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
 			      ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
-	hdq_data->hdq_usecount = 0;
 
 	/* Write followed by a read, release the module */
 	if (hdq_data->init_trans) {
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] omap_hdq: fix usecount handling
  2016-01-16 12:48 [PATCH RESEND] omap_hdq: fix usecount handling Andreas Kemnade
@ 2016-01-19 11:56 ` Vignesh R
  2016-01-19 16:38   ` Evgeniy Polyakov
  1 sibling, 0 replies; 6+ messages in thread
From: Vignesh R @ 2016-01-19 11:56 UTC (permalink / raw)
  To: Andreas Kemnade, Evgeniy Polyakov, hns, Fabian Frederick
  Cc: gregkh, linux-kernel, linux-omap



On 01/16/2016 06:18 PM, Andreas Kemnade wrote:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---

Reviewed-by: Vignesh R <vigneshr@ti.com>

Thanks,

>  drivers/w1/masters/omap_hdq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>  
>  	hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
>  			      ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> -	hdq_data->hdq_usecount = 0;
>  
>  	/* Write followed by a read, release the module */
>  	if (hdq_data->init_trans) {
> 

-- 
Regards
Vignesh

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] omap_hdq: fix usecount handling
  2016-01-16 12:48 [PATCH RESEND] omap_hdq: fix usecount handling Andreas Kemnade
@ 2016-01-19 16:38   ` Evgeniy Polyakov
  2016-01-19 16:38   ` Evgeniy Polyakov
  1 sibling, 0 replies; 6+ messages in thread
From: Evgeniy Polyakov @ 2016-01-19 16:38 UTC (permalink / raw)
  To: Andreas Kemnade, hns, Fabian Frederick, gregkh, linux-kernel, linux-omap

Hi Andreas

>From w1 perspective this doesn't break things :)
Greg, please pull it into your tree if no one objects.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

16.01.2016, 15:48, "Andreas Kemnade" <andreas@kemnade.info>:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/w1/masters/omap_hdq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
>          hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
>                                ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
>          /* Write followed by a read, release the module */
>          if (hdq_data->init_trans) {
> --
> 2.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] omap_hdq: fix usecount handling
@ 2016-01-19 16:38   ` Evgeniy Polyakov
  0 siblings, 0 replies; 6+ messages in thread
From: Evgeniy Polyakov @ 2016-01-19 16:38 UTC (permalink / raw)
  To: Andreas Kemnade, hns, Fabian Frederick, gregkh, linux-kernel, linux-omap

Hi Andreas

From w1 perspective this doesn't break things :)
Greg, please pull it into your tree if no one objects.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

16.01.2016, 15:48, "Andreas Kemnade" <andreas@kemnade.info>:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/w1/masters/omap_hdq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
>          hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
>                                ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
>          /* Write followed by a read, release the module */
>          if (hdq_data->init_trans) {
> --
> 2.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] omap_hdq: fix usecount handling
  2016-01-19 16:38   ` Evgeniy Polyakov
  (?)
@ 2016-01-19 18:13   ` gregkh
  2016-02-07 19:22     ` Andreas Kemnade
  -1 siblings, 1 reply; 6+ messages in thread
From: gregkh @ 2016-01-19 18:13 UTC (permalink / raw)
  To: Evgeniy Polyakov
  Cc: Andreas Kemnade, hns, Fabian Frederick, linux-kernel, linux-omap

On Tue, Jan 19, 2016 at 07:38:28PM +0300, Evgeniy Polyakov wrote:
> Hi Andreas
> 
> >From w1 perspective this doesn't break things :)
> Greg, please pull it into your tree if no one objects.
> 
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

Thanks, will do after 4.5-rc1 is out.

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] omap_hdq: fix usecount handling
  2016-01-19 18:13   ` gregkh
@ 2016-02-07 19:22     ` Andreas Kemnade
  0 siblings, 0 replies; 6+ messages in thread
From: Andreas Kemnade @ 2016-02-07 19:22 UTC (permalink / raw)
  To: gregkh; +Cc: Evgeniy Polyakov, hns, Fabian Frederick, linux-kernel, linux-omap

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

ping...

On Tue, 19 Jan 2016 10:13:04 -0800
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> wrote:

> On Tue, Jan 19, 2016 at 07:38:28PM +0300, Evgeniy Polyakov wrote:
> > Hi Andreas
> > 
> > >From w1 perspective this doesn't break things :)
> > Greg, please pull it into your tree if no one objects.
> > 
> > Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> 
> Thanks, will do after 4.5-rc1 is out.
> 
> greg k-h
> 
> 

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-07 19:22 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-16 12:48 [PATCH RESEND] omap_hdq: fix usecount handling Andreas Kemnade
2016-01-19 11:56 ` Vignesh R
2016-01-19 16:38 ` Evgeniy Polyakov
2016-01-19 16:38   ` Evgeniy Polyakov
2016-01-19 18:13   ` gregkh
2016-02-07 19:22     ` Andreas Kemnade

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.