From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> To: Andrey Pronin <apronin@chromium.org> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, groeck@chromium.org, smbarber@chromium.org, dianders@chromium.org, Christophe Ricard <christophe.ricard@gmail.com> Subject: Re: [PATCH 2/2] tpm: add driver for cr50 on SPI Date: Wed, 20 Jul 2016 11:03:36 -0600 [thread overview] Message-ID: <20160720170336.GC21460@obsidianresearch.com> (raw) In-Reply-To: <20160720002411.GA147098@apronin> On Tue, Jul 19, 2016 at 05:24:11PM -0700, Andrey Pronin wrote: > The only two things that bother me with such approach are > (1) whatever names I pick for the new set of functions, they > will be similar to and thus might be confused with the > original tpm_tis_read/writeXX; tpm_tis_helper_read16 ? > (2) these functions are phy-specific, so possibly it's better > to create tpm_tis_spi.h and put them there with proper > name prefixes. And then use in tpm_tis_spi and cr50_spi. No, they are generic to any tis phy that implements read only through read_bytes. (Honestly, I'm not sure we made the best choice here having phy functions for all the versions, we are not that performance sensitive, just getting rid of everything but read_bytes from the phy_ops would probably also be a reasonable thing to do.) Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> To: Andrey Pronin <apronin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Cc: Christophe Ricard <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, smbarber-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org Subject: Re: [PATCH 2/2] tpm: add driver for cr50 on SPI Date: Wed, 20 Jul 2016 11:03:36 -0600 [thread overview] Message-ID: <20160720170336.GC21460@obsidianresearch.com> (raw) In-Reply-To: <20160720002411.GA147098@apronin> On Tue, Jul 19, 2016 at 05:24:11PM -0700, Andrey Pronin wrote: > The only two things that bother me with such approach are > (1) whatever names I pick for the new set of functions, they > will be similar to and thus might be confused with the > original tpm_tis_read/writeXX; tpm_tis_helper_read16 ? > (2) these functions are phy-specific, so possibly it's better > to create tpm_tis_spi.h and put them there with proper > name prefixes. And then use in tpm_tis_spi and cr50_spi. No, they are generic to any tis phy that implements read only through read_bytes. (Honestly, I'm not sure we made the best choice here having phy functions for all the versions, we are not that performance sensitive, just getting rid of everything but read_bytes from the phy_ops would probably also be a reasonable thing to do.) Jason ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev
next prev parent reply other threads:[~2016-07-20 17:03 UTC|newest] Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-15 2:20 [PATCH 0/2] tpm: add driver for cr50 on SPI Andrey Pronin 2016-07-15 2:20 ` [PATCH 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin 2016-07-15 2:20 ` Andrey Pronin 2016-07-15 4:05 ` Guenter Roeck 2016-07-15 17:31 ` Andrey Pronin 2016-07-15 17:31 ` Andrey Pronin 2016-07-15 18:28 ` Guenter Roeck 2016-07-15 18:28 ` Guenter Roeck 2016-07-17 13:28 ` Rob Herring 2016-07-17 13:28 ` Rob Herring 2016-07-15 2:20 ` [PATCH 2/2] tpm: add driver for cr50 on SPI Andrey Pronin 2016-07-15 2:20 ` Andrey Pronin 2016-07-15 3:32 ` Jason Gunthorpe 2016-07-15 3:32 ` Jason Gunthorpe 2016-07-15 3:44 ` Andrey Pronin 2016-07-15 3:44 ` Andrey Pronin 2016-07-19 12:55 ` Jarkko Sakkinen 2016-07-19 12:55 ` Jarkko Sakkinen 2016-07-20 0:24 ` Andrey Pronin 2016-07-20 0:24 ` Andrey Pronin 2016-07-20 17:03 ` Jason Gunthorpe [this message] 2016-07-20 17:03 ` Jason Gunthorpe 2016-07-21 18:10 ` Andrey Pronin 2016-07-21 18:10 ` Andrey Pronin 2016-07-21 21:00 ` Jason Gunthorpe 2016-07-21 21:00 ` Jason Gunthorpe 2016-07-15 2:28 ` [PATCH 0/2] " Peter Huewe 2016-07-15 2:28 ` Peter Huewe 2016-07-15 2:50 ` Andrey Pronin 2016-07-15 3:28 ` Jason Gunthorpe 2016-07-15 3:28 ` Jason Gunthorpe 2016-07-15 17:15 ` Andrey Pronin 2016-07-15 17:15 ` Andrey Pronin 2016-07-19 12:56 ` Jarkko Sakkinen 2016-07-20 3:41 ` [PATCH v2 " Andrey Pronin 2016-07-20 3:41 ` Andrey Pronin 2016-07-20 3:41 ` [PATCH v2 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin 2016-07-20 3:41 ` Andrey Pronin 2016-07-20 19:03 ` Rob Herring 2016-07-20 19:49 ` Andrey Pronin 2016-07-20 19:49 ` Andrey Pronin 2016-07-20 19:54 ` Jason Gunthorpe 2016-07-20 19:54 ` Jason Gunthorpe 2016-07-27 21:02 ` Andrey Pronin 2016-07-27 21:02 ` Andrey Pronin 2016-07-21 21:03 ` Rob Herring 2016-07-21 21:03 ` Rob Herring 2016-07-27 21:00 ` Andrey Pronin 2016-07-27 21:00 ` Andrey Pronin 2016-07-20 3:41 ` [PATCH v2 2/2] tpm: add driver for cr50 on SPI Andrey Pronin 2016-07-20 3:41 ` Andrey Pronin 2016-07-25 17:09 ` Aw: [PATCH v2 0/2] " Peter Huewe 2016-07-25 17:09 ` Peter Huewe 2016-07-27 21:12 ` Andrey Pronin 2016-07-28 4:25 ` [PATCH v3 " Andrey Pronin 2016-07-28 4:25 ` Andrey Pronin 2016-07-28 4:25 ` [PATCH v3 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin 2016-07-28 4:25 ` Andrey Pronin 2016-07-28 4:25 ` [PATCH v3 2/2] tpm: add driver for cr50 on SPI Andrey Pronin 2016-07-28 4:25 ` Andrey Pronin 2016-07-28 23:01 ` Dmitry Torokhov 2016-07-28 23:17 ` Jason Gunthorpe 2016-07-28 23:17 ` Jason Gunthorpe 2016-07-29 3:01 ` Andrey Pronin 2016-07-29 3:01 ` Andrey Pronin 2016-07-29 1:55 ` [PATCH v4 0/2] " Andrey Pronin 2016-07-29 1:55 ` Andrey Pronin 2016-07-29 1:55 ` [PATCH v4 1/2] tpm: devicetree: document properties for cr50 Andrey Pronin 2016-07-29 1:55 ` Andrey Pronin 2016-07-29 17:27 ` Jason Gunthorpe 2016-07-29 17:27 ` Jason Gunthorpe 2016-07-29 21:42 ` Rob Herring 2016-07-29 21:42 ` Rob Herring 2016-08-09 10:08 ` Jarkko Sakkinen 2016-08-09 10:08 ` Jarkko Sakkinen 2016-07-29 1:55 ` [PATCH v4 2/2] tpm: add driver for cr50 on SPI Andrey Pronin 2016-07-29 1:55 ` Andrey Pronin 2016-08-09 10:20 ` Jarkko Sakkinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160720170336.GC21460@obsidianresearch.com \ --to=jgunthorpe@obsidianresearch.com \ --cc=apronin@chromium.org \ --cc=christophe.ricard@gmail.com \ --cc=dianders@chromium.org \ --cc=groeck@chromium.org \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peterhuewe@gmx.de \ --cc=smbarber@chromium.org \ --cc=tpmdd-devel@lists.sourceforge.net \ --cc=tpmdd@selhorst.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.