All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Linux Containers <containers@lists.linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>, Jann Horn <jann@thejh.net>,
	Kees Cook <keescook@chromium.org>,
	Nikolay Borisov <kernel@kyup.com>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Seth Forshee <seth.forshee@canonical.com>,
	linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH v2 10/10] mntns: Add a limit on the number of mount namespaces.
Date: Thu, 21 Jul 2016 11:40:14 -0500	[thread overview]
Message-ID: <20160721164014.17534-10-ebiederm@xmission.com> (raw)
In-Reply-To: <20160721164014.17534-1-ebiederm@xmission.com>

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
 fs/namespace.c                 | 19 ++++++++++++++++++-
 include/linux/user_namespace.h |  1 +
 kernel/user_namespace.c        |  1 +
 3 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index aabe8e397fc3..3942ae6c34f5 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2718,9 +2718,20 @@ dput_out:
 	return retval;
 }
 
+static bool inc_mnt_namespaces(struct user_namespace *ns)
+{
+	return inc_ucount(ns, UCOUNT_MNT_NAMESPACES);
+}
+
+static void dec_mnt_namespaces(struct user_namespace *ns)
+{
+	dec_ucount(ns, UCOUNT_MNT_NAMESPACES);
+}
+
 static void free_mnt_ns(struct mnt_namespace *ns)
 {
 	ns_free_inum(&ns->ns);
+	dec_mnt_namespaces(ns->user_ns);
 	put_user_ns(ns->user_ns);
 	kfree(ns);
 }
@@ -2739,12 +2750,18 @@ static struct mnt_namespace *alloc_mnt_ns(struct user_namespace *user_ns)
 	struct mnt_namespace *new_ns;
 	int ret;
 
+	if (!inc_mnt_namespaces(user_ns))
+		return ERR_PTR(-ENFILE);
+
 	new_ns = kmalloc(sizeof(struct mnt_namespace), GFP_KERNEL);
-	if (!new_ns)
+	if (!new_ns) {
+		dec_mnt_namespaces(user_ns);
 		return ERR_PTR(-ENOMEM);
+	}
 	ret = ns_alloc_inum(&new_ns->ns);
 	if (ret) {
 		kfree(new_ns);
+		dec_mnt_namespaces(user_ns);
 		return ERR_PTR(ret);
 	}
 	new_ns->ns.ops = &mntns_operations;
diff --git a/include/linux/user_namespace.h b/include/linux/user_namespace.h
index f86afa536baf..ee0e9d7b2e67 100644
--- a/include/linux/user_namespace.h
+++ b/include/linux/user_namespace.h
@@ -28,6 +28,7 @@ enum ucounts {
 	UCOUNT_UTS_NAMESPACES,
 	UCOUNT_IPC_NAMESPACES,
 	UCOUNT_NET_NAMESPACES,
+	UCOUNT_MNT_NAMESPACES,
 	UCOUNT_CGROUP_NAMESPACES,
 	UCOUNT_COUNTS,
 };
diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
index e326ca722ae0..f6702d84afab 100644
--- a/kernel/user_namespace.c
+++ b/kernel/user_namespace.c
@@ -81,6 +81,7 @@ static struct ctl_table userns_table[] = {
 	UCOUNT_ENTRY("max_uts_namespaces"),
 	UCOUNT_ENTRY("max_ipc_namespaces"),
 	UCOUNT_ENTRY("max_net_namespaces"),
+	UCOUNT_ENTRY("max_mnt_namespaces"),
 	UCOUNT_ENTRY("max_cgroup_namespaces"),
 	{ }
 };
-- 
2.8.3

  parent reply	other threads:[~2016-07-21 16:54 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20  1:13 [PATCH 0/10] userns: sysctl limits for namespaces Eric W. Biederman
     [not found] ` <8737n5dscy.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-20  1:21   ` [PATCH 01/10] sysctl: Stop implicitly passing current into sysctl_table_root.lookup Eric W. Biederman
     [not found]     ` <20160720012138.7894-1-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-20  1:21       ` [PATCH 02/10] userns: Add per user namespace sysctls Eric W. Biederman
     [not found]         ` <20160720012138.7894-2-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-20  5:12           ` Serge E. Hallyn
     [not found]             ` <20160720051226.GC16885-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-07-20 15:55               ` Eric W. Biederman
     [not found]                 ` <87shv49ud0.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-20 16:43                   ` Serge E. Hallyn
     [not found]                     ` <20160720164347.GA24378-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-07-21 14:41                       ` Eric W. Biederman
     [not found]                         ` <87invz9hpz.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-21 15:07                           ` Serge E. Hallyn
2016-07-20  6:28           ` Nikolay Borisov
     [not found]             ` <578F1A00.6030701-6AxghH7DbtA@public.gmane.org>
2016-07-21 15:37               ` Eric W. Biederman
2016-07-20  1:21       ` [PATCH 03/10] userns: Add a limit on the number of user namespaces Eric W. Biederman
     [not found]         ` <20160720012138.7894-3-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-20  7:03           ` Nikolay Borisov
     [not found]             ` <578F2233.2040708-6AxghH7DbtA@public.gmane.org>
2016-07-21 15:23               ` Eric W. Biederman
2016-07-20  1:21       ` [PATCH 04/10] userns: Generalize the user namespace count into ucount Eric W. Biederman
2016-07-20  1:21       ` [PATCH 05/10] pidns: Add a limit on the number of pid namespaces Eric W. Biederman
2016-07-20  1:21       ` [PATCH 06/10] utsns: Add a limit on the number of uts namespaces Eric W. Biederman
2016-07-20  1:21       ` [PATCH 07/10] ipcns: Add a limit on the number of ipc namespaces Eric W. Biederman
2016-07-20  1:21       ` [PATCH 08/10] cgroupns: Add a limit on the number of cgroup namespaces Eric W. Biederman
2016-07-20  1:21       ` [PATCH 09/10] netns: Add a limit on the number of net namespaces Eric W. Biederman
2016-07-20  1:21       ` [PATCH 10/10] mntns: Add a limit on the number of mount namespaces Eric W. Biederman
2016-07-20  1:58       ` [PATCH 01/10] sysctl: Stop implicitly passing current into sysctl_table_root.lookup Eric W. Biederman
2016-07-20  5:06       ` Serge E. Hallyn
2016-07-20  4:02   ` [PATCH 0/10] userns: sysctl limits for namespaces Kees Cook
     [not found]     ` <CAGXu5jKWjHKxtPSGuogjR+XE+SbNWiUp2bOxugpD+hUex9QeZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-21 14:49       ` Eric W. Biederman
2016-07-21 16:58       ` Eric W. Biederman
     [not found]         ` <871t2n53o5.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-21 18:46           ` Kees Cook
2016-07-21 16:39   ` [PATCH v2 00/10] " Eric W. Biederman
2016-07-21 16:39     ` Eric W. Biederman
2016-07-22 13:33     ` Colin Walters
     [not found]       ` <1469194399.3817016.673814953.7581706C-2RFepEojUI2N1INw9kWLP6GC3tUn3ZHUQQ4Iyu8u01E@public.gmane.org>
2016-07-22 18:45         ` Eric W. Biederman
2016-07-22 18:45           ` Eric W. Biederman
2016-07-22 21:46           ` Kees Cook
2016-07-23  2:11             ` Eric W. Biederman
2016-07-23  2:11               ` Eric W. Biederman
2016-07-23  2:11               ` Eric W. Biederman
     [not found]             ` <CAGXu5j+X7eWggkwpBpABsFe4hqK5LN1mYJ2TH91qj3iSe6rtcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-23  2:11               ` Eric W. Biederman
     [not found]           ` <87poq5y0jw.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-22 21:46             ` Kees Cook
     [not found]     ` <87d1m754jc.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-21 16:40       ` [PATCH v2 01/10] sysctl: Stop implicitly passing current into sysctl_table_root.lookup Eric W. Biederman
2016-07-21 16:40         ` Eric W. Biederman
2016-07-21 16:40         ` [PATCH v2 04/10] userns: Generalize the user namespace count into ucount Eric W. Biederman
     [not found]           ` <20160721164014.17534-4-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-25 23:09             ` Serge E. Hallyn
2016-07-25 23:09           ` Serge E. Hallyn
2016-07-25 23:09             ` Serge E. Hallyn
2016-07-21 16:40         ` [PATCH v2 06/10] utsns: Add a limit on the number of uts namespaces Eric W. Biederman
     [not found]           ` <20160721164014.17534-6-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-25 23:09             ` Serge E. Hallyn
2016-07-25 23:09               ` Serge E. Hallyn
     [not found]         ` <20160721164014.17534-1-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-21 16:40           ` [PATCH v2 02/10] userns: Add per user namespace sysctls Eric W. Biederman
2016-07-21 16:40             ` Eric W. Biederman
     [not found]             ` <20160721164014.17534-2-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-26  0:02               ` Eric W. Biederman
2016-07-26  0:02                 ` Eric W. Biederman
     [not found]                 ` <878twp6zd2.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-26  0:24                   ` David Miller
2016-07-26  0:24                     ` David Miller
     [not found]                     ` <20160725.172406.352408511647766870.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-07-26  0:44                       ` Eric W. Biederman
2016-07-26  0:44                         ` Eric W. Biederman
     [not found]                         ` <87k2g95it9.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-26  2:58                           ` David Miller
2016-07-26  2:58                             ` David Miller
     [not found]                             ` <20160725.195836.1881375122073635224.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-07-26  4:00                               ` Eric W. Biederman
2016-07-26  4:00                             ` Eric W. Biederman
2016-07-26  4:00                               ` Eric W. Biederman
2016-07-21 16:40           ` [PATCH v2 03/10] userns: Add a limit on the number of user namespaces Eric W. Biederman
2016-07-21 16:40             ` Eric W. Biederman
     [not found]             ` <20160721164014.17534-3-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-25 23:05               ` Serge E. Hallyn
2016-07-25 23:05             ` Serge E. Hallyn
2016-07-21 16:40           ` [PATCH v2 04/10] userns: Generalize the user namespace count into ucount Eric W. Biederman
2016-07-21 16:40           ` [PATCH v2 05/10] pidns: Add a limit on the number of pid namespaces Eric W. Biederman
2016-07-21 16:40             ` Eric W. Biederman
     [not found]             ` <20160721164014.17534-5-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-25 23:09               ` Serge E. Hallyn
2016-07-25 23:09                 ` Serge E. Hallyn
2016-07-21 16:40           ` [PATCH v2 06/10] utsns: Add a limit on the number of uts namespaces Eric W. Biederman
2016-07-21 16:40           ` [PATCH v2 07/10] ipcns: Add a limit on the number of ipc namespaces Eric W. Biederman
2016-07-21 16:40             ` Eric W. Biederman
2016-07-25 23:10             ` Serge E. Hallyn
     [not found]             ` <20160721164014.17534-7-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-25 23:10               ` Serge E. Hallyn
2016-07-21 16:40           ` [PATCH v2 08/10] cgroupns: Add a limit on the number of cgroup namespaces Eric W. Biederman
2016-07-21 16:40             ` Eric W. Biederman
2016-07-25 23:12             ` Serge E. Hallyn
2016-07-25 23:12               ` Serge E. Hallyn
     [not found]             ` <20160721164014.17534-8-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-25 23:12               ` Serge E. Hallyn
2016-07-21 16:40           ` [PATCH v2 09/10] netns: Add a limit on the number of net namespaces Eric W. Biederman
2016-07-21 16:40             ` Eric W. Biederman
2016-07-25 23:13             ` Serge E. Hallyn
     [not found]             ` <20160721164014.17534-9-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-25 23:13               ` Serge E. Hallyn
2016-07-26  6:01               ` Andrei Vagin
2016-07-26  6:01                 ` Andrei Vagin
     [not found]                 ` <CANaxB-zfkvu9XYkuYB47tYFGLeVnWBhpgEUaSrGD4+-O8ThcNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-26 20:00                   ` Eric W. Biederman
2016-07-26 20:00                     ` Eric W. Biederman
2016-07-21 16:40           ` [PATCH v2 10/10] mntns: Add a limit on the number of mount namespaces Eric W. Biederman
2016-07-21 16:40         ` Eric W. Biederman [this message]
     [not found]           ` <20160721164014.17534-10-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-07-25 23:15             ` Serge E. Hallyn
2016-07-25 23:15               ` Serge E. Hallyn
2016-07-22 13:33       ` [PATCH v2 00/10] userns: sysctl limits for namespaces Colin Walters
2016-07-26 10:27       ` Michael Kerrisk (man-pages)
2016-07-26 10:27         ` Michael Kerrisk (man-pages)
     [not found]         ` <94b608ae-1d06-5c41-cbd5-94e663a2163a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-07-26 15:14           ` Eric W. Biederman
2016-07-26 15:14             ` Eric W. Biederman
2016-07-26 15:14             ` Eric W. Biederman
2016-07-26 10:30       ` Michael Kerrisk (man-pages)
2016-07-26 10:30         ` Michael Kerrisk (man-pages)
     [not found]         ` <6be70177-a81d-7ed8-d2c9-a596d4d6a165-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-07-26 15:06           ` Eric W. Biederman
2016-07-26 15:06         ` Eric W. Biederman
2016-07-26 15:06           ` Eric W. Biederman
2016-07-26 15:06           ` Eric W. Biederman
2016-07-26 16:52           ` Kees Cook
2016-07-26 16:52             ` Kees Cook
     [not found]             ` <CAGXu5j+ZtZAFpW0ajnnBTRZk17ez6XYF=meEJY_rF7wwgyZB5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-26 17:29               ` Michael Kerrisk (man-pages)
2016-07-26 17:29             ` Michael Kerrisk (man-pages)
2016-07-26 17:29               ` Michael Kerrisk (man-pages)
     [not found]               ` <CAKgNAkhCvb-WkBbwebbBw6cfhg0FJ-SSbvK=aS1WK+BQ55eO5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-26 20:44                 ` Kees Cook
2016-07-26 20:44               ` Kees Cook
     [not found]           ` <87shuwtp4c.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-07-26 16:52             ` Kees Cook
2016-08-08 21:16       ` Eric W. Biederman
2016-08-08 21:16         ` Eric W. Biederman
2016-08-08 21:16         ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160721164014.17534-10-ebiederm@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=jann@thejh.net \
    --cc=keescook@chromium.org \
    --cc=kernel@kyup.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=netdev@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.